Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove hard coded dependency version in ConditionalDependenciesTest #19724

Merged
merged 1 commit into from
Aug 27, 2021
Merged

Remove hard coded dependency version in ConditionalDependenciesTest #19724

merged 1 commit into from
Aug 27, 2021

Conversation

glefloch
Copy link
Member

As discussed here #19692 this introduces two simple projects. One depend on the other and we validate that module exclusion works as expected.

close #18838

@quarkus-bot quarkus-bot bot added the area/gradle Gradle label Aug 27, 2021
aloubyansky
aloubyansky approved these changes Aug 27, 2021
View reviewed changes
Copy link
Member

@aloubyansky aloubyansky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @glefloch

gastaldi
gastaldi approved these changes Aug 27, 2021
View reviewed changes
Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@gastaldi gastaldi mentioned this pull request Aug 27, 2021
Closed
@gastaldi gastaldi added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Aug 27, 2021
gsmet
gsmet approved these changes Aug 27, 2021
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's very cool, thanks, this one has been bothering me for a while.

@gsmet gsmet merged commit a2ca69b into quarkusio:main Aug 27, 2021
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Aug 27, 2021
@quarkus-bot quarkus-bot bot added this to the 2.3 - main milestone Aug 27, 2021
@glefloch glefloch deleted the fix/18838 branch August 27, 2021 14:06
@gsmet gsmet modified the milestones: 2.3 - main, 2.2.2.Final Sep 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet approved these changes

@aloubyansky aloubyansky aloubyansky approved these changes

@gastaldi gastaldi gastaldi approved these changes

@famod famod Awaiting requested review from famod

Assignees
No one assigned
Labels
area/gradle Gradle
Projects
None yet
Milestone
2.2.2.Final
Development

Successfully merging this pull request may close these issues.

ConditionalDependenciesTest shouldn't hardcode the byte-buddy version
4 participants
@glefloch @gastaldi @aloubyansky @gsmet