Fix "Response head already sent" #19708

stuartwdouglas · 2021-08-27T02:00:29Z

Fixes #19621

quarkus-bot · 2021-08-27T02:08:06Z

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building `8f46cd9`

Status	Name	Step	Test failures	Logs	Raw logs
✖	Initial JDK 11 Build	`Build`	⚠️ Check →	Logs	Raw logs

quarkus-bot · 2021-08-27T04:10:00Z

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building `0c20b77`

Status	Name	Step	Test failures	Logs	Raw logs
✖	JVM Tests - JDK 11	`Build`	Test failures	Logs	Raw logs
✖	JVM Tests - JDK 11 Windows	`Build`	Test failures	Logs	Raw logs
✖	JVM Tests - JDK 16	`Build`	Test failures	Logs	Raw logs

Full information is available in the Build summary check run.

Test Failures

⚙️ JVM Tests - JDK 11 #

📦 extensions/vertx-web/deployment

✖ io.quarkus.vertx.web.mutiny.NdjsonMultiRouteTest.testNdjsonMultiRoute line 50 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Response body doesn't match expectation.
Expected: a string containing "boom"
  Actual: "Hello"


	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
	at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:490)
	at org.codehaus.groovy.reflection.CachedConstructor.invoke(CachedConstructor.java:72)
	at org.codehaus.groovy.reflection.CachedConstructor.doConstructorInvoke(CachedConstructor.java:59)
	at org.codehaus.groovy.runtime.callsite.ConstructorSite$ConstructorSiteNoUnwrap.callConstructor(ConstructorSite.java:84)
	at org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCallConstructor(CallSiteArray.java:59)
	at org.codehaus.groovy.runti...

✖ io.quarkus.vertx.web.mutiny.SSEMultiRouteTest.testSSEMultiRoute line 47 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Response body doesn't match expectation.
Expected: a string containing "boom"
  Actual: data: Hello
id: 0



	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
	at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:490)
	at org.codehaus.groovy.reflection.CachedConstructor.invoke(CachedConstructor.java:72)
	at org.codehaus.groovy.reflection.CachedConstructor.doConstructorInvoke(CachedConstructor.java:59)
	at org.codehaus.groovy.runtime.callsite.ConstructorSite$ConstructorSiteNoUnwrap.callConstructor(ConstructorSite.java:84)
	at org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCallConstructor(CallSiteArray.java:59)
	at org.codehaus.g...

⚙️ JVM Tests - JDK 11 Windows #

📦 extensions/vertx-web/deployment

✖ io.quarkus.vertx.web.mutiny.NdjsonMultiRouteTest.testNdjsonMultiRoute line 50 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Response body doesn't match expectation.
Expected: a string containing "boom"
  Actual: "Hello"


	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
	at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:490)
	at org.codehaus.groovy.reflection.CachedConstructor.invoke(CachedConstructor.java:72)
	at org.codehaus.groovy.reflection.CachedConstructor.doConstructorInvoke(CachedConstructor.java:59)
	at org.codehaus.groovy.runtime.callsite.ConstructorSite$ConstructorSiteNoUnwrap.callConstructor(ConstructorSite.java:84)
	at org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCallConstructor(CallSiteArray.java:59)
	at org.codehaus.groovy.runti...

✖ io.quarkus.vertx.web.mutiny.SSEMultiRouteTest.testSSEMultiRoute line 47 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Response body doesn't match expectation.
Expected: a string containing "boom"
  Actual: data: Hello
id: 0



	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
	at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:490)
	at org.codehaus.groovy.reflection.CachedConstructor.invoke(CachedConstructor.java:72)
	at org.codehaus.groovy.reflection.CachedConstructor.doConstructorInvoke(CachedConstructor.java:59)
	at org.codehaus.groovy.runtime.callsite.ConstructorSite$ConstructorSiteNoUnwrap.callConstructor(ConstructorSite.java:84)
	at org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCallConstructor(CallSiteArray.java:59)
	at org.codehaus.g...

⚙️ JVM Tests - JDK 16 #

📦 extensions/vertx-web/deployment

✖ io.quarkus.vertx.web.mutiny.NdjsonMultiRouteTest.testNdjsonMultiRoute line 50 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Response body doesn't match expectation.
Expected: a string containing "boom"
  Actual: "Hello"


	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:78)
	at java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
	at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:499)
	at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:480)
	at org.codehaus.groovy.reflection.CachedConstructor.invoke(CachedConstructor.java:72)
	at org.codehaus.groovy.runtime.callsite.ConstructorSite$ConstructorSiteNoUnwrapNoCoerce.callConstructor(ConstructorSite.java:105)
	at org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCallConstructor(CallSiteArray.java:59)
	at org.codehaus.groovy.runtime....

✖ io.quarkus.vertx.web.mutiny.SSEMultiRouteTest.testSSEMultiRoute line 47 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Response body doesn't match expectation.
Expected: a string containing "boom"
  Actual: data: Hello
id: 0



	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:78)
	at java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
	at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:499)
	at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:480)
	at org.codehaus.groovy.reflection.CachedConstructor.invoke(CachedConstructor.java:72)
	at org.codehaus.groovy.runtime.callsite.ConstructorSite$ConstructorSiteNoUnwrapNoCoerce.callConstructor(ConstructorSite.java:105)
	at org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCallConstructor(CallSiteArray.java:59)
	at org.codehaus.groo...

stuartwdouglas · 2021-08-27T05:53:13Z

The failure is related, but I am not sure if the test is really correct. Should we be writing exception details to a request that is already being written to the client?

geoand · 2021-08-27T06:09:44Z

Hm... That does look weird indeed... But I guess it's one for @cescoffier to answer

cescoffier · 2021-08-27T08:21:26Z

No, we should not add the exception to something already written, even only the HEAD.
Imagine a 200-OK followed with a stack trace, that's not correct.

gsmet · 2021-08-30T16:26:53Z

@stuartwdouglas any chance you could finalize this one? It looks like a good candidate for 2.2.1

Fixes quarkusio#19621

quarkus-bot · 2021-08-31T00:15:51Z

Failing Jobs - Building `9c55363`

Status	Name	Step	Failures	Logs	Raw logs
✖	Gradle Tests - JDK 11 Windows	`Build`	Failures	Logs	Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ Gradle Tests - JDK 11 Windows #

- Failing:

📦

✖ Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test (default-test) on project quarkus-integration-test-gradle-plugin: There are test failures.

Please refer to D:\a\quarkus\quarkus\integration-tests\gradle\target\surefire-reports for the individual test results. Please refer to dump files (if any exist) [date].dump, [date]-jvmRun[N].dump and [date].dumpstream.

📦 integration-tests/gradle

✖ io.quarkus.gradle.devmode.QuarkusDevDependencyDevModeTest.main line 14 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.test.devmode.util.DevModeTestUtils that uses java.util.function.Supplier, java.util.function.Supplierjava.util.concurrent.atomic.AtomicReference, java.util.concurrent.atomic.AtomicReferencejava.lang.String, java.lang.Stringboolean was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:166)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

stuartwdouglas requested a review from geoand August 27, 2021 02:00

quarkus-bot bot added the area/vertx label Aug 27, 2021

stuartwdouglas force-pushed the 19621 branch from 8f46cd9 to 0c20b77 Compare August 27, 2021 02:11

geoand approved these changes Aug 27, 2021

View reviewed changes

cescoffier approved these changes Aug 27, 2021

View reviewed changes

gsmet added triage/backport? labels Aug 27, 2021

Fix "Response head already sent"

9c55363

Fixes quarkusio#19621

stuartwdouglas force-pushed the 19621 branch from 0c20b77 to 9c55363 Compare August 30, 2021 20:55

gastaldi added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Aug 30, 2021

stuartwdouglas merged commit 4e009a2 into quarkusio:main Aug 31, 2021

quarkus-bot bot added this to the 2.3 - main milestone Aug 31, 2021

quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Aug 31, 2021

gsmet modified the milestones: 2.3 - main, 2.2.1.Final Aug 31, 2021

gsmet removed triage/backport? labels Aug 31, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix "Response head already sent" #19708

Fix "Response head already sent" #19708

stuartwdouglas commented Aug 27, 2021

quarkus-bot bot commented Aug 27, 2021 •

edited

Loading

Failing Jobs - Building `8f46cd9`

quarkus-bot bot commented Aug 27, 2021 •

edited

Loading

Failing Jobs - Building `0c20b77`

Test Failures

⚙️ JVM Tests - JDK 11 #

📦 extensions/vertx-web/deployment

⚙️ JVM Tests - JDK 11 Windows #

📦 extensions/vertx-web/deployment

⚙️ JVM Tests - JDK 16 #

📦 extensions/vertx-web/deployment

stuartwdouglas commented Aug 27, 2021

geoand commented Aug 27, 2021 •

edited

Loading

cescoffier commented Aug 27, 2021

gsmet commented Aug 30, 2021

quarkus-bot bot commented Aug 31, 2021

Fix "Response head already sent" #19708

Fix "Response head already sent" #19708

Conversation

stuartwdouglas commented Aug 27, 2021

quarkus-bot bot commented Aug 27, 2021 • edited Loading

Failing Jobs - Building 8f46cd9

quarkus-bot bot commented Aug 27, 2021 • edited Loading

Failing Jobs - Building 0c20b77

Test Failures

⚙️ JVM Tests - JDK 11 #

📦 extensions/vertx-web/deployment

⚙️ JVM Tests - JDK 11 Windows #

📦 extensions/vertx-web/deployment

⚙️ JVM Tests - JDK 16 #

📦 extensions/vertx-web/deployment

stuartwdouglas commented Aug 27, 2021

geoand commented Aug 27, 2021 • edited Loading

cescoffier commented Aug 27, 2021

gsmet commented Aug 30, 2021

quarkus-bot bot commented Aug 31, 2021

Failing Jobs - Building 9c55363

Failures

⚙️ Gradle Tests - JDK 11 Windows #

📦

📦 integration-tests/gradle

quarkus-bot bot commented Aug 27, 2021 •

edited

Loading

Failing Jobs - Building `8f46cd9`

quarkus-bot bot commented Aug 27, 2021 •

edited

Loading

Failing Jobs - Building `0c20b77`

geoand commented Aug 27, 2021 •

edited

Loading

Failing Jobs - Building `9c55363`