-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fallback to the original registry repo config in case applied mirror/proxy from settings didn't work #19693
Fallback to the original registry repo config in case applied mirror/proxy from settings didn't work #19693
Conversation
…proxy from settings didn't work, better logs
@gastaldi The mirror sync error makes me think our registry should be also providing the platform JSON catalogs we deploy to Central. |
@aloubyansky can you elaborate on why the registry should do that if the JSON is already published in central? |
Some users/organizations setup mirrors for central. They will be synced periodically but there will be an out-of-sync interval at some point when a new catalog has been published to Central but not yet available in the mirror. Our registry will recommend that catalog but it won't be available in the mirror yet and will cause the client to fail. |
It sounds like it's the mirror's fault for not synchronizing yet? I am not 100% convinced we should be adding that feature to the registry because:
|
@gastaldi this is not a change in the registry - its the client going directly to registry if mirror/proxy access fail, right ? |
No, it happens when it resolves the https://repo1.maven.org/maven2/io/quarkus/quarkus-bom-quarkus-platform-descriptor/2.1.4.Final. These aren't provided by the registry. |
The fact that the JARs won't be available in that case anyway, makes it look less like a fix. |
#19695 reports a better message in case of 3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This change provides a better user experience when Maven mirrors and/or proxies are present in the local Maven settings.
ADDING A * MIRROR
1.2. Maven plugin:
2.1. Maven plugin:
2.2. CLI:
3.1. CLI error:
3.2. Maven plugin error: