Show example of executing a single Maven Invoker test #19643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoand
force-pushed
the
maven-invoker-single
branch
from
5b4718d to
7e5b33b
Compare
gsmet
approved these changes
Aug 25, 2021
famod
reviewed
Aug 25, 2021
| For example, in order to only run the MySQL test project of the container-image tests, the Maven command would be: | ||
|
|
||
| ``` | ||
| ./mvnw verify -f integration-tests/container-image/maven-invoker-way verify -Dinvoker.test=container-build-jib-with-mysql |
There was a problem hiding this comment.
@geoand The doube-verify is probably a mistake as it yields:
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-jar-plugin:3.1.2:jar (default-jar) on project quarkus-integration-test-container-image-invoker: You have to use a classifier to attach supplemental artifacts to the project instead of replacing them.
Also, this very specific module also requires -Dstart-containers.
That's what you get for being helpful by documenting things for others. 😉
There was a problem hiding this comment.
Ouch on the double verify...
For the other flags, I was on the fence on whether to add them or not, because they don't bring any value to the specific section.
Feel free to update the doc how you best see fit :)
There was a problem hiding this comment.
If you are fixing that double-verify, you could add one one-liner note on that this is just an example and that further parameters might be needed. 🤷
There was a problem hiding this comment.
Here it is: #19651 :)
geoand
added a commit
to geoand/quarkus
that referenced
this pull request
Aug 25, 2021
Based on feedback from quarkusio#19643 (comment)
geoand
added a commit
to geoand/quarkus
that referenced
this pull request
Aug 25, 2021
Based on feedback from quarkusio#19643 (comment)
famod
added a commit
that referenced
this pull request
Aug 25, 2021
Fix and enhance Maven Invoker example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.