Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump kotlin to 1.5.30, coroutines to 1.5.1, dokka to 1.5.0 #19632

Merged
merged 1 commit into from
Aug 25, 2021
Merged

Bump kotlin to 1.5.30, coroutines to 1.5.1, dokka to 1.5.0 #19632

merged 1 commit into from
Aug 25, 2021

Conversation

famod
Copy link
Member

@famod famod commented Aug 24, 2021

Fixes the two Gradle tests on Java 17 EA (#18372 (comment)).

I bumped the other two for general alignment. I ran dokka-maven-plugin via -Ddokka and it LGTM.

PS: Both kapt and dokka (would) still need add-opens. Only that NoSuchMethodError should be gone now: https://youtrack.jetbrains.com/issue/KT-47583

@quarkus-bot quarkus-bot bot added area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/gradle Gradle area/kotlin area/platform Issues related to definition and interaction with Quarkus Platform labels Aug 24, 2021
Copy link
Member

@evanchooly evanchooly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if .30 will fix all our Java 16+ issues with needing all the flags to open up modules. I'm on PTO until tomorrow but can take a look thursday.

@famod
Copy link
Member Author

famod commented Aug 24, 2021

I wonder if .30 will fix all our Java 16+ issues with needing all the flags to open up modules.

No, that's what I tried to say with:

PS: Both kapt and dokka (would) still need add-opens.

though I haven't checked whether fewer flags are needed. It still needs at least "java.util".

This doesn't look so great either: https://youtrack.jetbrains.com/issue/KT-45545#focus=Comments-27-5141183.0-0

@gastaldi gastaldi merged commit f4c16c7 into quarkusio:main Aug 25, 2021
@quarkus-bot quarkus-bot bot added this to the 2.3 - main milestone Aug 25, 2021
@famod famod deleted the kotlin-1.5.30-coroutines-1.5.1 branch August 25, 2021 08:33
@MartinX3
Copy link

Can this be backported to 2.2 or is it easy to migrate to 2.3 (and does it come soon)?

@famod
Copy link
Member Author

famod commented Sep 17, 2021

@MartinX3
The release plan is here: https://github.com/quarkusio/quarkus/wiki/Release-Planning#23
And the known migration tasks at this point are here: https://github.com/quarkusio/quarkus/wiki/Migration-Guide-2.3

I might find some time to check whether this would backport cleanly, but I cannot promise anyting.

@famod
Copy link
Member Author

famod commented Sep 19, 2021

@MartinX3 I created #20260 to backport the latest kotlin versions. If it gets merged it will end up in the next 2.2.x.

@famod
Copy link
Member Author

famod commented Sep 20, 2021

@MartinX3 I have been told that the next 2.2.x will take a while, so you might be better off updating to 2.3 when it's out.

@MartinX3
Copy link

@famod Oh
Thank you for the information, luckily until now every quarkus migration to a newer version was quite easy :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/gradle Gradle area/kotlin area/platform Issues related to definition and interaction with Quarkus Platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants