Never propagate a WebApplicationException from the client #19630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a call fails on the server it should be treated as an internal server error, it should not be propagating the response back to the original request. Fixes quarkusio#19488
gastaldi
reviewed
Aug 25, 2021
| var res = super.unwrapException(t); | ||
| if (res instanceof WebApplicationException) { | ||
| WebApplicationException webApplicationException = (WebApplicationException) res; | ||
| return new ClientWebApplicationException(webApplicationException.getMessage(), webApplicationException, |
There was a problem hiding this comment.
The WebApplicationException cause should be propagated here?
There was a problem hiding this comment.
I think it should.
I'm only wondering if it wouldn't be slightly better if webApplication.getCause() was passed as the cause and not webApplication
There was a problem hiding this comment.
I'm not sure, it does loose a bit of context as to where the original exception came from (e.g. a filter could directly throw it with no cause.)
michalszynkiewicz
approved these changes
Aug 25, 2021
geoand
approved these changes
Aug 25, 2021
This was referenced Feb 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a call fails on the server it should be treated as an internal server
error, it should not be propagating the response back to the original
request.
Fixes #19488