-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve documentation of "Separating Java and native image compilation" section #19610
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I spotted a couple of things.
1. register the output of the step executing `./mvnw ...` command (i.e. directory `target/native-image`) as build artifact, | ||
2. require this artifact in the step executing the `native-image ...` command, and | ||
3. register the output of the step executing the `native-image ...` command (i.e. files matching `target/*runner`) as build artifact. | ||
A CI/CD pipeline a high level overview of the various steps would look like so: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there is a word missing after pipeline
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see it fixed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess I hadn't pushed 🤦🏼 . Should be OK now
…n" section Fixes: quarkusio#19460 Co-authored-by: Guillaume Smet <[email protected]>
Fixes: #19460