Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation of "Separating Java and native image compilation" section #19610

Merged
merged 1 commit into from
Aug 24, 2021

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Aug 24, 2021

Fixes: #19460

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I spotted a couple of things.

docs/src/main/asciidoc/building-native-image.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/building-native-image.adoc Outdated Show resolved Hide resolved
1. register the output of the step executing `./mvnw ...` command (i.e. directory `target/native-image`) as build artifact,
2. require this artifact in the step executing the `native-image ...` command, and
3. register the output of the step executing the `native-image ...` command (i.e. files matching `target/*runner`) as build artifact.
A CI/CD pipeline a high level overview of the various steps would look like so:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is a word missing after pipeline?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, fixed

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see it fixed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess I hadn't pushed 🤦🏼 . Should be OK now

@gsmet gsmet added triage/waiting-for-ci Ready to merge when CI successfully finishes triage/backport-2.1? labels Aug 24, 2021
@geoand geoand merged commit dd92fc1 into quarkusio:main Aug 24, 2021
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Aug 24, 2021
@quarkus-bot quarkus-bot bot added this to the 2.3 - main milestone Aug 24, 2021
@geoand geoand deleted the #19460 branch August 24, 2021 11:50
@gsmet gsmet modified the milestones: 2.3 - main, 2.2.0.Final Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Separating Java and native image compilation" docs different to actual behaviour
2 participants