Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leverage gradle daemon in integration tests #19584

Merged
merged 1 commit into from
Aug 24, 2021

Conversation

glefloch
Copy link
Member

This branch removes gradle daemon deactivation.

Gradle CI jobs normally takes around 40min on linux and 1h on windows.
On my fork with the daemon, it tooks 20min on linux and 38min on windows without any failures.

cc @ebullient

@glefloch glefloch requested review from aloubyansky and gsmet August 23, 2021 13:01
@quarkus-bot quarkus-bot bot added the area/gradle Gradle label Aug 23, 2021
@famod
Copy link
Member

famod commented Aug 23, 2021

Are we sure this is not introducing any side-effects or "caching anomalies"? Maybe an opt out (or opt in) makes sense?

@ebullient
Copy link
Member

ebullient commented Aug 23, 2021

Are we sure this is not introducing any side-effects or "caching anomalies"? Maybe an opt out (or opt in) makes sense?

Gradle always uses a daemon, even if you "disable" it. When we run our builds by turning off the daemon, we just extend the build time as it starts and stops an entire daemon process.
Also.. gradle is used within our maven targets.. so the maven dependency order will influence what gradle sees / doesn't see.

@famod
Copy link
Member

famod commented Aug 23, 2021

I guess what I was trying to ask is: Are we sure that running test B with the same daemon as test A is always providing the necessary test isolation?
But what do I know, feel free to ignore me. 😉

@aloubyansky aloubyansky merged commit 5d72a32 into quarkusio:main Aug 24, 2021
@quarkus-bot quarkus-bot bot added this to the 2.3 - main milestone Aug 24, 2021
@famod famod mentioned this pull request Sep 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants