-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conscious Language Updates #19547
Conscious Language Updates #19547
Conversation
/cc @ebullient, @jmartisk |
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building 1af1737
Test Failures⚙️ Gradle Tests - JDK 11 Windows #📦 integration-tests/gradle✖ ⚙️ JVM Tests - JDK 11 #📦 extensions/resteasy-classic/resteasy/deployment✖ 📦 extensions/undertow/deployment✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ⚙️ JVM Tests - JDK 11 Windows #📦 extensions/resteasy-classic/resteasy/deployment✖ 📦 extensions/undertow/deployment✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ⚙️ JVM Tests - JDK 16 #📦 extensions/resteasy-classic/resteasy/deployment✖ 📦 extensions/undertow/deployment✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ⚙️ MicroProfile TCKs Tests #📦 tcks/microprofile-health✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ 📦 tcks/microprofile-rest-client-reactive✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ 📦 tcks/microprofile-rest-client✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ⚙️ Native Tests - HTTP #📦 integration-tests/virtual-http✖ |
...ain/java/io/quarkus/elasticsearch/restclient/common/runtime/graal/Substitute_RestClient.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good, except for the @Alias
feature that @machi1990 pointed out in https://github.com/quarkusio/quarkus/pull/19547/files#r693152986
...ions/undertow/deployment/src/main/java/io/quarkus/undertow/deployment/UndertowBuildStep.java
Show resolved
Hide resolved
...ain/java/io/quarkus/elasticsearch/restclient/common/runtime/graal/Substitute_RestClient.java
Outdated
Show resolved
Hide resolved
1af1737
to
5483df8
Compare
I fixed the issues and force pushed. Let's see what CI has to say. |
Thanks @gsmet, sorry I didn't get to the changes promptly. Damn those People Managers doing some code!! |
Here's a few 'Conscious Language Updates'. It doesn't cover all the problematic language occurrences, but it does cover those that i could have a go at fixing before it was home time.
The changes are based on the guidance in https://source.redhat.com/aboutredhat/weareredhat/inclusion/diversity__inclusion_wiki/conscious_language_project_faq.
In many cases I didn't know the full intent of the code, so a better alternative might be appropriate. Let me know, and I'll fix.