Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kafka serializer null handling #19543

Merged
merged 2 commits into from
Aug 22, 2021
Merged

Kafka serializer null handling #19543

merged 2 commits into from
Aug 22, 2021

Conversation

loicmathieu
Copy link
Contributor

  • Allow serializing null as null via a Kafka properties
  • Add test and documentation for list serialization as it's missing

cescoffier
cescoffier approved these changes Aug 20, 2021
View reviewed changes
Copy link
Member

@cescoffier cescoffier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@cescoffier cescoffier merged commit 8445d00 into quarkusio:main Aug 22, 2021
@quarkus-bot quarkus-bot bot added this to the 2.3 - main milestone Aug 22, 2021
@gsmet
Copy link
Member

gsmet commented Aug 22, 2021

@cescoffier should this be backported to 2.2?

@cescoffier
Copy link
Member

It can, but it's a new feature. I let you decide if we accept that category of PR.

The changes are simple and there are flags, so there are no big risk.

@loicmathieu loicmathieu deleted the kafka-serializer-null-handling branch August 30, 2021 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cescoffier cescoffier cescoffier approved these changes

@geoand geoand Awaiting requested review from geoand

Assignees
No one assigned
Labels
area/documentation area/kafka
Projects
None yet
Milestone
2.3.0.CR1
Development

Successfully merging this pull request may close these issues.
3 participants
@loicmathieu @gsmet @cescoffier