Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use MultivaluedHashMap in examples #19542

Merged
merged 1 commit into from
Aug 21, 2021

Conversation

RuggeroDAlo
Copy link
Contributor

The documentation for adding headers for the reactive client doesn't compile:

https://quarkus.io/version/main/guides/rest-client-reactive#custom-headers-support

since MultivaluedMapImpl is part of resteasy-core which is not a dependency of quarkus-rest-client-reactive.

From what I understand the "standard" non reactive client example compiles because resteasy-core is a dependency of quarkus-resteasy-common which is a dependency of quarkus-rest-client.

I've changed all MultivaluedMapImpl for consistency, let me know if only fixing the reactive case is preferred.

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I agree it's better to use the spec one if it works correctly.

Let's see what CI has to say.

@quarkus-bot
Copy link

quarkus-bot bot commented Aug 20, 2021

Failing Jobs - Building 0ebb530

Status Name Step Test failures Logs Raw logs
JVM Tests - JDK 11 Build Test failures Logs Raw logs
✔️ JVM Tests - JDK 16

Full information is available in the Build summary check run.

Test Failures

⚙️ JVM Tests - JDK 11 #

📦 extensions/smallrye-reactive-messaging-kafka/deployment

io.quarkus.smallrye.reactivemessaging.kafka.deployment.testing.KafkaDevServicesContinuousTestingTestCase.testContinuousTestingScenario1 line 64 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <1> but was: <0>
	at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)
	at org.junit.jupiter.api.AssertionUtils.failNotEqual(AssertionUtils.java:62)
	at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:166)
	at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:161)
	at org.junit.jupiter.api.Assertions.assertEquals(Assertions.java:611)
	at io.quarkus.smallrye.reactivemessaging.kafka.deployment.testing.KafkaDevServicesContinuousTestingTestCase.testContinuousTestingScenario1(KafkaDevServicesContinuousTestingTestCase.java:64)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
	at org.junit.pla...

@gsmet gsmet merged commit f2f568f into quarkusio:main Aug 21, 2021
@quarkus-bot quarkus-bot bot added this to the 2.3 - main milestone Aug 21, 2021
@gsmet gsmet modified the milestones: 2.3 - main, 2.1.4.Final Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants