-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Normalize the quarkus.http.root-path at config level #19501
Conversation
Converting to draft for now. I'll have a closer look at what's going on. |
Should be ready now. |
This is a bit of a can of worms. I'm making additional adjustments. |
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building 5062b6c
Full information is available in the Build summary check run. Test Failures⚙️ JVM Tests - JDK 11 #📦 extensions/micrometer/deployment✖
⚙️ JVM Tests - JDK 11 Windows #📦 extensions/micrometer/deployment✖
⚙️ JVM Tests - JDK 16 #📦 extensions/micrometer/deployment✖
|
LGTM in theory, but the failures look related. |
Yeah... the servlet part is quite a mess on this side and the Micrometer tests are using servlet. I'm trying to clean this up and will push an update tomorrow morning once I have run more tests. |
Removing the backport labels as it ends up being far more intrusive than I would have expected. |
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building 90aa803
Full information is available in the Build summary check run. Test Failures⚙️ Gradle Tests - JDK 11 Windows #📦 integration-tests/gradle✖
⚙️ JVM Tests - JDK 11 #📦 extensions/vertx-http/deployment✖
⚙️ JVM Tests - JDK 11 Windows #📦 extensions/vertx-http/deployment✖
⚙️ JVM Tests - JDK 16 #📦 extensions/vertx-http/deployment✖
⚙️ Native Tests - Data7 #📦 integration-tests/reactive-mysql-client✖
|
756eccc
to
c234c9a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ebullient I tweaked a few more things as the servlet path was not happy (and you use it in your Micrometer tests). I think I whacked all the moles but let's see what CI has to say.
I added a few comments at your intention. Could you have a look?
Also, I'll squash everything once settled.
core/deployment/src/main/java/io/quarkus/deployment/util/UriNormalizationUtil.java
Show resolved
Hide resolved
...steasy/deployment/src/main/java/io/quarkus/resteasy/deployment/ResteasyServletProcessor.java
Show resolved
Hide resolved
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building c234c9a
Full information is available in the Build summary check run. Test Failures⚙️ Gradle Tests - JDK 11 Windows #📦 integration-tests/gradle✖
|
...rc/main/java/io/quarkus/resteasy/server/common/deployment/ResteasyServerCommonProcessor.java
Outdated
Show resolved
Hide resolved
...steasy/deployment/src/main/java/io/quarkus/resteasy/deployment/ResteasyServletProcessor.java
Show resolved
Hide resolved
extensions/undertow/deployment/src/main/java/io/quarkus/undertow/deployment/ServletConfig.java
Outdated
Show resolved
Hide resolved
...tx-http/deployment/src/main/java/io/quarkus/vertx/http/deployment/HttpRootPathBuildItem.java
Outdated
Show resolved
Hide resolved
...tx-http/deployment/src/main/java/io/quarkus/vertx/http/deployment/HttpRootPathBuildItem.java
Outdated
Show resolved
Hide resolved
...tx-http/deployment/src/main/java/io/quarkus/vertx/http/deployment/HttpRootPathBuildItem.java
Outdated
Show resolved
Hide resolved
...tx-http/deployment/src/main/java/io/quarkus/vertx/http/deployment/HttpRootPathBuildItem.java
Outdated
Show resolved
Hide resolved
@ebullient I included your comments and squashed the whole thing. It should be ready now. Figuring out the purpose of the build items and properly documenting them is a task for another day. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made the same mistake twice in my suggestions. 🙄 sorry.
...rc/main/java/io/quarkus/resteasy/server/common/deployment/ResteasyServerCommonProcessor.java
Outdated
Show resolved
Hide resolved
extensions/undertow/deployment/src/main/java/io/quarkus/undertow/deployment/ServletConfig.java
Outdated
Show resolved
Hide resolved
…config level Make sure both paths always start and end with a '/' so that we don't have any risk of having logic working with '/test' and not with '/test/'. Adjust the servlet context path too. Also simplify a few things thanks to that. Fixes quarkusio#19492
@ebullient fixed. |
Failing Jobs - Building 4a66f79
Full information is available in the Build summary check run. Test Failures⚙️ JVM Tests - JDK 16 #📦 integration-tests/elytron-undertow✖
📦 integration-tests/hibernate-reactive-panache✖
|
Make sure the quarkus.http.root-path always starts and ends with a '/'
so that we don't have any risk of having logic working with '/test' and
not with '/test/'.
Fixes #19492