Document reactive health check #19478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ladicek
reviewed
Aug 18, 2021
|
Looks good to me. Maybe @xstefank should review? |
loicmathieu
force-pushed
the
doc/reactive-health
branch
from
3f53309 to
a37710d
Compare
|
@Ladicek I apply your suggestions. |
|
@Ladicek can I have your approval so I can merge this one? |
|
I hoped that @xstefank would review, but... |
Ladicek
approved these changes
Aug 23, 2021
|
Thanks @Ladicek he can still have a look and propose improvements later. |
xstefank
reviewed
Aug 30, 2021
| import javax.enterprise.context.ApplicationScoped; | ||
|
|
||
| @Liveness | ||
| @ApplicationScoped |
There was a problem hiding this comment.
I believe that AppScoped is not required because quarkus makes Liveness a bean-defining annotation, but I can check that later. Nothing big.
|
LGTM! I guess I can't take PTO @Ladicek ?? :D |
|
Haha sorry! :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.