OpenAPI: Added AutoTag and Response for Auto Security Requirement

[phillip-kruger]

This PR adds a AutoTag filter that will tag an operation with the class name. (if it's not explicitly tagged in annotations)
It also refactors the Auto Roles Allowed filter into it's own filer (from the SecurityConfig Filter) so it can apply even if security in not added with config.

Signed-off-by:Phillip Kruger [email protected]

[quarkus-bot]

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building f16c03f

Status	Name	Step	Test failures	Logs	Raw logs
✖	MicroProfile TCKs Tests	Verify	Test failures	Logs	Raw logs

Full information is available in the Build summary check run.

Test Failures

⚙️ MicroProfile TCKs Tests #

📦 tcks/microprofile-openapi

✖ org.eclipse.microprofile.openapi.tck.AirlinesAppTest.testTagsInOperations[JSON](1) line 736 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
JSON path paths.'/bookings/{id}'.delete.tags doesn't match.
Expected: not a collection with size a value greater than <0>
  Actual: <[Booking Resource]>

	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
	at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:490)
	at org.codehaus.groovy.reflection.CachedConstructor.invoke(CachedConstructor.java:72)
	at org.codehaus.groovy.reflection.CachedConstructor.doConstructorInvoke(CachedConstructor.java:59)
	at org.codehaus.groovy.runtime.callsite.ConstructorSite$ConstructorSiteNoUnwrap.callConstructor(ConstructorSite.java:84)
	at org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCallConstruc...

✖ org.eclipse.microprofile.openapi.tck.AirlinesAppTest.testTagsInOperations[YAML](2) line 736 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
JSON path paths.'/bookings/{id}'.delete.tags doesn't match.
Expected: not a collection with size a value greater than <0>
  Actual: <[Booking Resource]>

	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
	at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:490)
	at org.codehaus.groovy.reflection.CachedConstructor.invoke(CachedConstructor.java:72)
	at org.codehaus.groovy.reflection.CachedConstructor.doConstructorInvoke(CachedConstructor.java:59)
	at org.codehaus.groovy.runtime.callsite.ConstructorSite$ConstructorSiteNoUnwrap.callConstructor(ConstructorSite.java:84)
	at org.codehaus.groovy.runtime.callsite.AbstractCallSite.callConstructor(...

[geoand]

It would probably be best to get a review from someone else (@michalszynkiewicz maybe?) because I won't be back for a few more days

[phillip-kruger]

Thanks, apologies I did not know you are away.

[geoand]

NP!

[sberyozkin]

@phillip-kruger Hi, I'm not very familiar with this code but the idea of the AutoRolesAllowed makes sense, +1.

What does AutoTag help with ?

thanks

[phillip-kruger]

@sberyozkin at the moment if an operation is not tagged, it's all grouped under "default" (see swagger ui screen). This will group them automatically by class (using the ClassName but making it readable, so Class Name). A user can still use the tag annotation, and in that case we will not auto tag.

[sberyozkin]

LGTM