-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Netty to 4.1.67 #19426
Update Netty to 4.1.67 #19426
Conversation
It should also fix #18962 |
It should also fix #14695 |
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building f9bee36
Full information is available in the Build summary check run. Test Failures⚙️ Gradle Tests - JDK 11 Windows #📦 integration-tests/gradle✖
⚙️ JVM Tests - JDK 11 #📦 integration-tests/grpc-mutual-auth✖
✖
⚙️ JVM Tests - JDK 11 Windows #📦 integration-tests/grpc-mutual-auth✖
⚙️ JVM Tests - JDK 16 #📦 integration-tests/grpc-mutual-auth✖
✖
⚙️ Native Tests - Misc1 #📦 integration-tests/maven✖
⚙️ Native Tests - Misc4 #📦 integration-tests/gradle✖
✖
|
I have pushed some new substitutions, lets see what CI says. |
Failing Jobs - Building d9667e3
Full information is available in the Build summary check run. Test Failures⚙️ JVM Tests - JDK 11 #📦 integration-tests/grpc-mutual-auth✖
✖
⚙️ JVM Tests - JDK 11 Windows #📦 integration-tests/grpc-mutual-auth✖
⚙️ JVM Tests - JDK 16 #📦 integration-tests/grpc-mutual-auth✖
✖
⚙️ Native Tests - gRPC #📦 integration-tests/grpc-mutual-auth✖
|
|
Not totally surprising, gRPC is a bit strict in term of netty version. I need to check if there is a compatible version. |
Yeah, we are way behind in terms of gRPC versions. |
Does not seem to have any compatible version yet. We can try to update to a newer one and see. |
No luck with the latest grpc-java version. I guess we are kind of stuck until a suitable version gets released. |
The last compatible version of netty is 4.1.65. |
@gsmet and @cescoffier What do you say to grpc/grpc-java#8416 (comment)? |
This PR fixes the GRPC issues: vert-x3/vertx-grpc#106 |
Closing this as it will come with a Vert.x upgrade. |
Update Netty version to 4.1.67.
Unlike previous Netty update, this one is motivated by https://github.com/quarkusio/quarkus/issues/18469.