Avoid exception wrapping when native image build error

[gsmet]

@stuartwdouglas this was part of a larger work to get the errors of the native image build injected into the exception so I could grab them with the bot.

Unfortunately, when I'm not using inherit IO to be able to get the output, the output is all garbled. It seems our existing infra doesn't support disabling IO inheritance very well. Not sure if it's the ErrorReplacingProcessReader competing with the ones of ProcessUtil or if it's something more involved.

I wasn't too sure also if it would work well with Gradle to not inherit the IO.

I'll see if I can put more time into it but it you have ideas, I'm all ears.

[quarkus-bot]

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 0a1cb72

Status	Name	Step	Test failures	Logs	Raw logs
✖	Gradle Tests - JDK 11 Windows	Build	⚠️ Check →	Logs	Raw logs
✖	JVM Tests - JDK 11	Build	Test failures	Logs	Raw logs
✔️	JVM Tests - JDK 16
✖	Native Tests - Data4	Build	Test failures	Logs	Raw logs

Full information is available in the Build summary check run.

Test Failures

⚙️ JVM Tests - JDK 11 #

📦 extensions/scheduler/deployment

✖ io.quarkus.scheduler.test.metrics.MicrometerTimedTest.testTimedMethod line 63 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: Count=0 ==> expected: <true> but was: <false>
	at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)
	at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:40)
	at org.junit.jupiter.api.Assertions.assertTrue(Assertions.java:193)
	at io.quarkus.scheduler.test.metrics.MicrometerTimedTest.testTimedMethod(MicrometerTimedTest.java:63)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
	at io.quarkus.test.QuarkusUnitTest.runExtensionMethod(QuarkusUnitTest.java:363)
	at io.quarkus.test.QuarkusUnitTest.interceptTestMethod(QuarkusUnitTest.java:331)
	at org.junit.jupiter.engine.execution.ExecutableInvoker$ReflectiveInterceptorCall.la...

---

⚙️ Native Tests - Data4 #

📦 integration-tests/mongodb-rest-data-panache

✖ io.quarkus.it.mongodb.rest.data.panache.MongoDbRestDataPanacheIT.shouldNotCreateOrDeleteAuthor - More details - Source on GitHub

java.lang.RuntimeException: 
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.mongodb.deployment.DevServicesMongoProcessor#startMongo threw an exception: org.testcontainers.containers.ContainerLaunchException: Container startup failed
	at org.testcontainers.containers.GenericContainer.doStart(GenericContainer.java:330)
	at org.testcontainers.containers.GenericContainer.start(GenericContainer.java:311)
	at io.quarkus.mongodb.deployment.DevServicesMongoProcessor.startMongo(DevServicesMongoProcessor.java:167)
	at io.quarkus.mongodb.deployment.DevServicesMongoProcessor.startMongo(DevServicesMongoProcessor.java:88)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43...

[stuartwdouglas]

I just did some testing and I don't think ErrorReplacingProcessReader actually works any more, so feel free to remove it.

[stuartwdouglas]

Also in terms of the output being garbled is it STDERR and STDOUT appearing in the wrong order? Because they are read by different threads they can easily end up in a different order to what they would appear in the terminal.