Support @ConfigMapping in Extensions #19230

radcortez · 2021-08-04T14:54:29Z

Requires Improve API integration for ConfigMappings smallrye/smallrye-config#626
Requires Update SmallRye Config to 2.5.0 #20168
Requires Register @ConfigMappings directly into the Config builder #20103

Fixes the following @ConfigRoot issues by allowing to use @ConfigMapping instead:

Does not support constructor injection in Recorders. This can be added later.

quarkus-bot · 2021-09-30T13:38:40Z

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building `fca338b`

Status	Name	Step	Failures	Logs	Raw logs
✖	Initial JDK 11 Build	`Build`	Failures	Logs	Raw logs

Failures

⚙️ Initial JDK 11 Build #

- Failing: extensions/elytron-security-properties-file/runtime extensions/kubernetes/vanilla/deployment extensions/micrometer/runtime and 1 more
! Skipped: devtools/bom-descriptor-json docs extensions/agroal/deployment and 200 more

📦 extensions/elytron-security-properties-file/runtime

✖ Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1-jboss-2:compile (default-compile) on project quarkus-elytron-security-properties-file: Fatal error compiling

📦 extensions/kubernetes/vanilla/deployment

✖ Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1-jboss-2:compile (default-compile) on project quarkus-kubernetes-deployment: Fatal error compiling

📦 extensions/micrometer/runtime

✖ Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1-jboss-2:compile (default-compile) on project quarkus-micrometer: Fatal error compiling

📦 extensions/oidc-common/runtime

✖ Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1-jboss-2:compile (default-compile) on project quarkus-oidc-common: Fatal error compiling

quarkus-bot · 2021-09-30T14:14:41Z

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building `fca338b`

Status	Name	Step	Failures	Logs	Raw logs
✖	Initial JDK 11 Build	`Build`	Failures	Logs	Raw logs

Failures

⚙️ Initial JDK 11 Build #

- Failing: extensions/elytron-security-properties-file/runtime extensions/kubernetes/vanilla/deployment extensions/micrometer/runtime and 1 more
! Skipped: devtools/bom-descriptor-json docs extensions/agroal/deployment and 200 more

📦 extensions/elytron-security-properties-file/runtime

✖ Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1-jboss-2:compile (default-compile) on project quarkus-elytron-security-properties-file: Fatal error compiling

📦 extensions/kubernetes/vanilla/deployment

✖ Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1-jboss-2:compile (default-compile) on project quarkus-kubernetes-deployment: Fatal error compiling

📦 extensions/micrometer/runtime

✖ Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1-jboss-2:compile (default-compile) on project quarkus-micrometer: Fatal error compiling

📦 extensions/oidc-common/runtime

✖ Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1-jboss-2:compile (default-compile) on project quarkus-oidc-common: Fatal error compiling

quarkus-bot · 2021-10-14T12:18:41Z

This workflow status is outdated as a new workflow run has been triggered.

🚫 This workflow run has been cancelled.

Failing Jobs - Building `48c30ab`

⚠️ Artifacts of the workflow run were not available thus the report misses some details.

Status	Name	Failures	Logs	Raw logs
⌛	Initial JDK 11 Build	⚠️ Check →	Logs	Raw logs
⌛	Attach pull request number	⚠️ Check →	Logs	Raw logs
⌛	CI Sanity Check	⚠️ Check →	Logs	Raw logs

quarkus-bot · 2021-11-11T20:48:44Z

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building `35ca89b`

Status	Name	Step	Failures	Logs	Raw logs
✖	MicroProfile TCKs Tests	`Verify`	Failures	Logs	Raw logs
✖	Native Tests - Windows - hibernate-validator	`Build`	Failures	Logs	Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ MicroProfile TCKs Tests #

- Failing: tcks/microprofile-fault-tolerance

📦 tcks/microprofile-fault-tolerance

✖ org.eclipse.microprofile.fault.tolerance.tck.TimeoutUninterruptableTest.testTimeoutAsyncBulkhead line 190 - More details - Source on GitHub

java.lang.AssertionError: Unexpected exception thrown from Future
	at org.testng.Assert.fail(Assert.java:85)
	at org.eclipse.microprofile.fault.tolerance.tck.util.Exceptions.expect(Exceptions.java:98)

⚙️ Native Tests - Windows - hibernate-validator #

- Failing: integration-tests/hibernate-validator

📦 integration-tests/hibernate-validator

✖ Failed to execute goal io.quarkus:quarkus-maven-plugin:999-SNAPSHOT:build (default) on project quarkus-integration-test-hibernate-validator: Failed to build quarkus application

gsmet · 2022-01-12T16:37:23Z

@radcortez this one fell through the cracks. Is it still needed? If so it needs a big rebase.

radcortez · 2022-01-12T16:45:40Z

@radcortez this one fell through the cracks. Is it still needed? If so it needs a big rebase.

Yes, it will give us the ability to use SR @ConfigMapping for extensions. It allows us to create config structures not currently possible with the @ConfigRoot and in a VERY distant future consolidate on a single configuration mechanism :)

quarkus-bot · 2022-01-12T17:13:40Z

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building `81f4578`

Status	Name	Step	Failures	Logs	Raw logs
✖	Initial JDK 11 Build	`Build`	Failures	Logs	Raw logs

Failures

⚙️ Initial JDK 11 Build #

- Failing: core/deployment 
! Skipped: core/test-extension/deployment core/test-extension/runtime devtools/bom-descriptor-json and 613 more

📦 core/deployment

✖ Failed to execute goal net.revelc.code.formatter:formatter-maven-plugin:2.17.1:validate (default) on project quarkus-core-deployment: File '/home/runner/work/quarkus/quarkus/core/deployment/src/main/java/io/quarkus/deployment/configuration/ConfigMappingUtils.java' has not been previously formatted. Please format file and commit before running validation!

quarkus-bot · 2022-01-12T17:27:55Z

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building `be5a242`

Status	Name	Step	Failures	Logs	Raw logs
✖	Initial JDK 11 Build	`Build`	Failures	Logs	Raw logs

Failures

⚙️ Initial JDK 11 Build #

- Failing: devtools/gradle/gradle-model 
! Skipped: devtools/gradle/gradle-application-plugin devtools/gradle/gradle-extension-plugin integration-tests/gradle

📦 devtools/gradle/gradle-model

✖ Failed to execute goal org.codehaus.mojo:exec-maven-plugin:3.0.0:exec (gradle) on project quarkus-gradle-model: Command execution failed.

quarkus-bot · 2022-01-12T21:47:59Z

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building `be5a242`

Status	Name	Step	Failures	Logs	Raw logs
✖	Gradle Tests - JDK 11	`Build`	Failures	Logs	Raw logs
✖	Gradle Tests - JDK 11 Windows	`Build`	Failures	Logs	Raw logs
✖	JVM Tests - JDK 11	`Build`	Failures	Logs	Raw logs
✔️	JVM Tests - JDK 17

Full information is available in the Build summary check run.

Failures

⚙️ Gradle Tests - JDK 11 #

- Failing: integration-tests/gradle

📦 integration-tests/gradle

✖ io.quarkus.gradle.BeanInTestSourcesTest.testBasicMultiModuleBuild line 15 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: "SUCCESS"

✖ io.quarkus.gradle.devmode.MultiModuleKotlinProjectDevModeTest.main line 23 - More details - Source on GitHub

java.lang.AssertionError: 

Expecting actual:

✖ io.quarkus.gradle.KotlinGRPCProjectBuildTest.testBasicMultiModuleBuild line 15 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: "SUCCESS"

✖ io.quarkus.gradle.MultiModuleKotlinProjectBuildTest.testBasicMultiModuleBuild line 15 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: "SUCCESS"

✖ io.quarkus.gradle.MultiSourceProjectTest.shouldRunTest line 16 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: "SUCCESS"

⚙️ Gradle Tests - JDK 11 Windows #

- Failing: integration-tests/gradle

📦 integration-tests/gradle

✖ io.quarkus.gradle.BeanInTestSourcesTest.testBasicMultiModuleBuild line 15 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: "SUCCESS"

✖ io.quarkus.gradle.devmode.MultiModuleKotlinProjectDevModeTest.main line 23 - More details - Source on GitHub

java.lang.AssertionError: 

Expecting actual:

✖ io.quarkus.gradle.KotlinGRPCProjectBuildTest.testBasicMultiModuleBuild line 15 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: "SUCCESS"

✖ io.quarkus.gradle.MultiModuleKotlinProjectBuildTest.testBasicMultiModuleBuild line 15 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: "SUCCESS"

✖ io.quarkus.gradle.MultiSourceProjectTest.shouldRunTest line 16 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: "SUCCESS"

⚙️ JVM Tests - JDK 11 #

- Failing: devtools/gradle/gradle-model 
! Skipped: devtools/gradle/gradle-application-plugin devtools/gradle/gradle-extension-plugin

📦 devtools/gradle/gradle-model

✖ Failed to execute goal org.codehaus.mojo:exec-maven-plugin:3.0.0:exec (gradle) on project quarkus-gradle-model: Command execution failed.

...ocessor/src/main/java/io/quarkus/annotation/processor/generate_doc/ConfigDocItemScanner.java

quarkus-bot · 2022-02-15T14:20:18Z

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building `590f5ea`

Status	Name	Step	Failures	Logs	Raw logs
✖	Initial JDK 11 Build	`Build`	Failures	Logs	Raw logs

Failures

⚙️ Initial JDK 11 Build #

- Failing: extensions/elytron-security-properties-file/runtime extensions/oidc-common/runtime extensions/resteasy-classic/rest-client-config/runtime 
! Skipped: devtools/bom-descriptor-json docs extensions/agroal/deployment and 242 more

📦 extensions/elytron-security-properties-file/runtime

✖ Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1:compile (default-compile) on project quarkus-elytron-security-properties-file: Fatal error compiling

📦 extensions/oidc-common/runtime

✖ Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1:compile (default-compile) on project quarkus-oidc-common: Fatal error compiling

📦 extensions/resteasy-classic/rest-client-config/runtime

✖ Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1:compile (default-compile) on project quarkus-rest-client-config: Fatal error compiling

quarkus-bot · 2022-02-17T19:48:57Z

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building `3e49b08`

Status	Name	Step	Failures	Logs	Raw logs
✖	Initial JDK 11 Build	`Build`	Failures	Logs	Raw logs

Failures

⚙️ Initial JDK 11 Build #

- Failing: docs

📦 docs

✖ Failed to execute goal org.asciidoctor:asciidoctor-maven-plugin:2.0.0:process-asciidoc (output-html) on project quarkus-documentation: Found 1 issue(s) of severity WARN or higher during conversion

quarkus-bot · 2022-02-22T17:38:36Z

Milestone is already set for some of the items:

Issue Add "prefix" to @ConfigRoot #9791

We haven't automatically updated the milestones for these items.

This message is automatically generated by a bot.

radcortez · 2022-02-22T17:52:41Z

Uh oh!

quarkus-bot bot added area/arc Issue related to ARC (dependency injection) area/config area/core area/dependencies Pull requests that update a dependency file area/hibernate-validator Hibernate Validator labels Aug 4, 2021

radcortez force-pushed the mappings-extensions branch from 4934c1d to 91562ba Compare September 17, 2021 12:33

quarkus-bot bot added the area/documentation label Sep 17, 2021

radcortez force-pushed the mappings-extensions branch from 91562ba to fca338b Compare September 30, 2021 13:25

radcortez marked this pull request as ready for review September 30, 2021 13:26

radcortez force-pushed the mappings-extensions branch from fca338b to 30c6fe1 Compare September 30, 2021 16:48

radcortez force-pushed the mappings-extensions branch 2 times, most recently from 48c30ab to 0b179b8 Compare October 14, 2021 12:13

quarkus-bot bot added area/reactive-messaging area/smallrye labels Oct 14, 2021

radcortez force-pushed the mappings-extensions branch from 0b179b8 to 35ca89b Compare November 11, 2021 16:18

radcortez force-pushed the mappings-extensions branch from 35ca89b to 0c2b434 Compare December 6, 2021 15:38

gsmet assigned radcortez Jan 12, 2022

gsmet added the triage/needs-rebase This PR needs to be rebased first because it has merge conflicts label Jan 12, 2022

radcortez force-pushed the mappings-extensions branch from 0c2b434 to 81f4578 Compare January 12, 2022 17:09

radcortez force-pushed the mappings-extensions branch from 81f4578 to be5a242 Compare January 12, 2022 17:15

radcortez marked this pull request as draft January 24, 2022 21:11

radcortez force-pushed the mappings-extensions branch from be5a242 to 4375a01 Compare January 27, 2022 17:51

radcortez force-pushed the mappings-extensions branch 2 times, most recently from c454faf to ce8de3f Compare February 14, 2022 16:19

radcortez marked this pull request as ready for review February 14, 2022 16:30

radcortez removed the triage/needs-rebase This PR needs to be rebased first because it has merge conflicts label Feb 14, 2022

gastaldi reviewed Feb 14, 2022

View reviewed changes

...ocessor/src/main/java/io/quarkus/annotation/processor/generate_doc/ConfigDocItemScanner.java Outdated Show resolved Hide resolved

radcortez force-pushed the mappings-extensions branch from ce8de3f to 590f5ea Compare February 15, 2022 13:55

radcortez force-pushed the mappings-extensions branch from 590f5ea to 3e49b08 Compare February 17, 2022 19:29

radcortez force-pushed the mappings-extensions branch from 3e49b08 to 663c170 Compare February 21, 2022 16:06

Support ConfigMappings in Extensions

3e5fd1f

radcortez force-pushed the mappings-extensions branch from 663c170 to 3e5fd1f Compare February 21, 2022 16:20

gastaldi approved these changes Feb 22, 2022

View reviewed changes

gastaldi merged commit 0d51827 into quarkusio:main Feb 22, 2022

quarkus-bot bot added this to the 2.8 - main milestone Feb 22, 2022

quarkus-bot bot added kind/bugfix kind/enhancement New feature or request labels Feb 22, 2022

radcortez mentioned this pull request Jul 27, 2022

Use ConfigMapping to map duplicated properties and avoid unknown config warning #26967

Merged

Sgitario mentioned this pull request Sep 1, 2022

The config reference is not generated for child config classes annotated with @ConfigMapping #27668

Closed

radcortez deleted the mappings-extensions branch December 16, 2022 11:35

Support @ConfigMapping in Extensions #19230

Support @ConfigMapping in Extensions #19230

Conversation

radcortez commented Aug 4, 2021 • edited Loading

quarkus-bot bot commented Sep 30, 2021 • edited Loading

Failing Jobs - Building fca338b

Failures

⚙️ Initial JDK 11 Build #

📦 extensions/elytron-security-properties-file/runtime

📦 extensions/kubernetes/vanilla/deployment

📦 extensions/micrometer/runtime

📦 extensions/oidc-common/runtime

quarkus-bot bot commented Sep 30, 2021 • edited Loading

Failing Jobs - Building fca338b

Failures

⚙️ Initial JDK 11 Build #

📦 extensions/elytron-security-properties-file/runtime

📦 extensions/kubernetes/vanilla/deployment

📦 extensions/micrometer/runtime

📦 extensions/oidc-common/runtime

quarkus-bot bot commented Oct 14, 2021 • edited Loading

Failing Jobs - Building 48c30ab

quarkus-bot bot commented Nov 11, 2021 • edited Loading

Failing Jobs - Building 35ca89b

Failures

⚙️ MicroProfile TCKs Tests #

📦 tcks/microprofile-fault-tolerance

⚙️ Native Tests - Windows - hibernate-validator #

📦 integration-tests/hibernate-validator

gsmet commented Jan 12, 2022

radcortez commented Jan 12, 2022

quarkus-bot bot commented Jan 12, 2022 • edited Loading

Failing Jobs - Building 81f4578

Failures

⚙️ Initial JDK 11 Build #

📦 core/deployment

quarkus-bot bot commented Jan 12, 2022 • edited Loading

Failing Jobs - Building be5a242

Failures

⚙️ Initial JDK 11 Build #

📦 devtools/gradle/gradle-model

quarkus-bot bot commented Jan 12, 2022 • edited Loading

Failing Jobs - Building be5a242

Failures

⚙️ Gradle Tests - JDK 11 #

📦 integration-tests/gradle

⚙️ Gradle Tests - JDK 11 Windows #

📦 integration-tests/gradle

⚙️ JVM Tests - JDK 11 #

📦 devtools/gradle/gradle-model

quarkus-bot bot commented Feb 15, 2022 • edited Loading

Failing Jobs - Building 590f5ea

Failures

⚙️ Initial JDK 11 Build #

📦 extensions/elytron-security-properties-file/runtime

📦 extensions/oidc-common/runtime

📦 extensions/resteasy-classic/rest-client-config/runtime

quarkus-bot bot commented Feb 17, 2022 • edited Loading

Failing Jobs - Building 3e49b08

Failures

⚙️ Initial JDK 11 Build #

📦 docs

quarkus-bot bot commented Feb 22, 2022

radcortez commented Feb 22, 2022

radcortez commented Aug 4, 2021 •

edited

Loading

quarkus-bot bot commented Sep 30, 2021 •

edited

Loading

Failing Jobs - Building `fca338b`

quarkus-bot bot commented Sep 30, 2021 •

edited

Loading

Failing Jobs - Building `fca338b`

quarkus-bot bot commented Oct 14, 2021 •

edited

Loading

Failing Jobs - Building `48c30ab`

quarkus-bot bot commented Nov 11, 2021 •

edited

Loading

Failing Jobs - Building `35ca89b`

quarkus-bot bot commented Jan 12, 2022 •

edited

Loading

Failing Jobs - Building `81f4578`

quarkus-bot bot commented Jan 12, 2022 •

edited

Loading

Failing Jobs - Building `be5a242`

quarkus-bot bot commented Jan 12, 2022 •

edited

Loading

Failing Jobs - Building `be5a242`

quarkus-bot bot commented Feb 15, 2022 •

edited

Loading

Failing Jobs - Building `590f5ea`

quarkus-bot bot commented Feb 17, 2022 •

edited

Loading

Failing Jobs - Building `3e49b08`