Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Hibernate ORM 5.5.6.Final #19228

Merged
merged 1 commit into from
Aug 5, 2021
Merged

Conversation

Sanne
Copy link
Member

@Sanne Sanne commented Aug 4, 2021

No description provided.

@Sanne Sanne added the area/hibernate-orm Hibernate ORM label Aug 4, 2021
@Sanne Sanne requested a review from gsmet August 4, 2021 14:25
@quarkus-bot quarkus-bot bot added the area/dependencies Pull requests that update a dependency file label Aug 4, 2021
@gsmet
Copy link
Member

gsmet commented Aug 4, 2021

@famod can you check your issues are gone with this version?

@quarkus-bot
Copy link

quarkus-bot bot commented Aug 4, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building e03efc7

Status Name Step Test failures Logs Raw logs
Initial JDK 11 Build Build ⚠️ Check → Logs Raw logs

@Sanne
Copy link
Member Author

Sanne commented Aug 4, 2021

Build failed because of

Caused by: org.eclipse.aether.transfer.ArtifactNotFoundException: Could not find artifact org.hibernate:hibernate-core:jar:5.5.6.Final in google-maven-central (https://maven-central.storage-download.googleapis.com/maven2/)

Weird, I could fetch it locally. I'll trigger the build again in a few hours.

@famod
Copy link
Member

famod commented Aug 4, 2021

My company's Artifactory doesn't seem to have it yet. Will try again later.

@quarkus-bot
Copy link

quarkus-bot bot commented Aug 4, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building cc187c1

Status Name Step Test failures Logs Raw logs
Initial JDK 11 Build Build ⚠️ Check → Logs Raw logs

@famod
Copy link
Member

famod commented Aug 4, 2021

@Sanne Um...have you changed the versioning scheme? I can see (and download/use) 5.5.6 but not 5.5.6.Final?

@famod
Copy link
Member

famod commented Aug 4, 2021

The modelgen part is fixed for sure, but I cannot test 5.5.6 (without .Final) in my current project because we are using Blaze-Persistence and com.blazebit.persistence.integration.hibernate.base.function.AbstractHibernateEntityManagerFactoryIntegrator chokes on the missing version suffix.
/cc @beikov (but I suppose the missing suffix was a mishap during release...?)

@beikov
Copy link
Contributor

beikov commented Aug 4, 2021

@Sanne might be worth re-doing the release?

@Sanne
Copy link
Member Author

Sanne commented Aug 4, 2021

@beikov yes I'll repeat the process. Sorry all :(

@Sanne
Copy link
Member Author

Sanne commented Aug 4, 2021

The 5.5.6.Final artifacts have been released correctly now, but it will take a little longer for Maven to synch.

@Sanne
Copy link
Member Author

Sanne commented Aug 4, 2021

It's available, restarting CI....

@quarkus-bot
Copy link

quarkus-bot bot commented Aug 5, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building cc187c1

Status Name Step Test failures Logs Raw logs
Native Tests - Data6 Build ⚠️ Check → Logs Raw logs

@Sanne
Copy link
Member Author

Sanne commented Aug 5, 2021

FWIW, the error:

Error:  Failed to execute goal io.fabric8:docker-maven-plugin:0.31.0:start (docker-start) on project quarkus-integration-test-hibernate-reactive-panache: I/O Error: Unable to pull 'postgres:13.1' : {"message":"Head https://registry-1.docker.io/v2/library/postgres/manifests/13.1: unknown: unable to scan account service account row from query: context deadline exceeded"} (Internal Server Error: 500) -> [Help 1]

I'm restarting it.

@famod
Copy link
Member

famod commented Aug 5, 2021

Looking good in my project now! Hitting another problem in SR Config though, but that's not related.

@quarkus-bot
Copy link

quarkus-bot bot commented Aug 5, 2021

Failing Jobs - Building cc187c1

Status Name Step Test failures Logs Raw logs
Gradle Tests - JDK 11 Windows Build ⚠️ Check → Logs Raw logs

@gsmet gsmet merged commit 68c9a86 into quarkusio:main Aug 5, 2021
@quarkus-bot quarkus-bot bot added this to the 2.2 - main milestone Aug 5, 2021
@Sanne Sanne deleted the ORMUpgrade branch August 5, 2021 13:01
@gsmet gsmet modified the milestones: 2.2 - main, 2.1.2.Final Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file area/hibernate-orm Hibernate ORM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants