Run reactive rest client on Vertx same context #19225

FroMage · 2021-08-04T12:51:03Z

Fixes #18977

geoand · 2021-08-04T12:57:18Z

LGTM, but I would like @stuartwdouglas to take a look as well because he had opened #19144

FroMage · 2021-08-04T13:03:04Z

We could make a PR with both sets of commits.

geoand · 2021-08-04T13:04:10Z

The question is though, are they both needed?

Sanne · 2021-08-04T13:05:30Z

I'm not sure what Stuart was aiming to do, but I'm quite certain that we need the "run on context" that Stef introduced here.

I would suggest to merge this one first and then ask Stuart if he wants to either drop his PR or rebase it on top.

geoand · 2021-08-04T13:08:17Z

Yeah, I agree that this should be enough

geoand · 2021-08-04T13:10:40Z

@FroMage I assume that this should also fix #16949, right?

FroMage · 2021-08-04T13:39:38Z

I thought so too, but I tried, and no: we get notified on the IO thread, so we will in turn notify on that same IO thread, which is different to the original worker thread.

I'm not sure if we should aim to do that, though. This feels like a broader discussion, because if Vert.x doesn't do thread affinity with worker threads, there's probably a good reason?

geoand · 2021-08-04T13:41:24Z

I'm not sure if we should aim to do that, though. This feels like a broader discussion, because if Vert.x doesn't do thread affinity with worker threads, there's probably a good reason?

I wouldn't know TBH, but I guess :)

quarkus-bot · 2021-08-04T14:21:15Z

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building `bf3fdd0`

Status	Name	Step	Test failures	Logs	Raw logs
✖	JVM Tests - JDK 11	`Build`	Test failures	Logs	Raw logs
✖	JVM Tests - JDK 11 Windows	`Build`	Test failures	Logs	Raw logs
✖	JVM Tests - JDK 16	`Build`	Test failures	Logs	Raw logs

Full information is available in the Build summary check run.

Test Failures

⚙️ JVM Tests - JDK 11 #

📦 extensions/resteasy-reactive/rest-client-reactive/deployment

✖ io.quarkus.rest.client.reactive.provider.ProviderDisabledAutodiscoveryTest. - More details - Source on GitHub

java.lang.RuntimeException: 
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.arc.deployment.ArcProcessor#validate threw an exception: javax.enterprise.inject.spi.DeploymentException: javax.enterprise.inject.UnsatisfiedResolutionException: Unsatisfied dependency for type io.quarkus.rest.client.reactive.HelloClient2 and qualifiers [@RestClient]
	- java member: io.quarkus.rest.client.reactive.HelloResource#client2
	- declared on CLASS bean [types=[io.quarkus.rest.client.reactive.HelloResource, java.lang.Object], qualifiers=[@Default, @Any], target=io.quarkus.rest.client.reactive.HelloResource]
	at io.quarkus.arc.processor.BeanDeployment.processErrors(BeanDeployment.java:1100)
	at io.quarkus.arc.processor.BeanDeployment.init(BeanDeployment.java:265)
	at io.quarkus.arc.processor.BeanProcessor.initialize(BeanProcessor.java:129)
	at io.quarkus.arc.deployment.ArcProcessor.validate(ArcProcessor.java:418)...

✖ io.quarkus.rest.client.reactive.provider.ProviderPriorityTest. - More details - Source on GitHub

java.lang.RuntimeException: 
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.arc.deployment.ArcProcessor#validate threw an exception: javax.enterprise.inject.spi.DeploymentException: javax.enterprise.inject.UnsatisfiedResolutionException: Unsatisfied dependency for type io.quarkus.rest.client.reactive.HelloClient2 and qualifiers [@RestClient]
	- java member: io.quarkus.rest.client.reactive.HelloResource#client2
	- declared on CLASS bean [types=[io.quarkus.rest.client.reactive.HelloResource, java.lang.Object], qualifiers=[@Default, @Any], target=io.quarkus.rest.client.reactive.HelloResource]
	at io.quarkus.arc.processor.BeanDeployment.processErrors(BeanDeployment.java:1100)
	at io.quarkus.arc.processor.BeanDeployment.init(BeanDeployment.java:265)
	at io.quarkus.arc.processor.BeanProcessor.initialize(BeanProcessor.java:129)
	at io.quarkus.arc.deployment.ArcProcessor.validate(ArcProcessor.java:418)...

✖ io.quarkus.rest.client.reactive.provider.ProviderTest. - More details - Source on GitHub

java.lang.RuntimeException: 
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.arc.deployment.ArcProcessor#validate threw an exception: javax.enterprise.inject.spi.DeploymentException: javax.enterprise.inject.UnsatisfiedResolutionException: Unsatisfied dependency for type io.quarkus.rest.client.reactive.HelloClient2 and qualifiers [@RestClient]
	- java member: io.quarkus.rest.client.reactive.HelloResource#client2
	- declared on CLASS bean [types=[io.quarkus.rest.client.reactive.HelloResource, java.lang.Object], qualifiers=[@Default, @Any], target=io.quarkus.rest.client.reactive.HelloResource]
	at io.quarkus.arc.processor.BeanDeployment.processErrors(BeanDeployment.java:1100)
	at io.quarkus.arc.processor.BeanDeployment.init(BeanDeployment.java:265)
	at io.quarkus.arc.processor.BeanProcessor.initialize(BeanProcessor.java:129)
	at io.quarkus.arc.deployment.ArcProcessor.validate(ArcProcessor.java:418)...

⚙️ JVM Tests - JDK 11 Windows #

📦 extensions/resteasy-reactive/rest-client-reactive/deployment

✖ io.quarkus.rest.client.reactive.provider.ProviderDisabledAutodiscoveryTest. - More details - Source on GitHub

java.lang.RuntimeException: 
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.arc.deployment.ArcProcessor#validate threw an exception: javax.enterprise.inject.spi.DeploymentException: javax.enterprise.inject.UnsatisfiedResolutionException: Unsatisfied dependency for type io.quarkus.rest.client.reactive.HelloClient2 and qualifiers [@RestClient]
	- java member: io.quarkus.rest.client.reactive.HelloResource#client2
	- declared on CLASS bean [types=[io.quarkus.rest.client.reactive.HelloResource, java.lang.Object], qualifiers=[@Default, @Any], target=io.quarkus.rest.client.reactive.HelloResource]
	at io.quarkus.arc.processor.BeanDeployment.processErrors(BeanDeployment.java:1100)
	at io.quarkus.arc.processor.BeanDeployment.init(BeanDeployment.java:265)
	at io.quarkus.arc.processor.BeanProcessor.initialize(BeanProcessor.java:129)
	at io.quarkus.arc.deployment.ArcProcessor.validate(ArcProcessor.java:418)...

✖ io.quarkus.rest.client.reactive.provider.ProviderPriorityTest. - More details - Source on GitHub

java.lang.RuntimeException: 
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.arc.deployment.ArcProcessor#validate threw an exception: javax.enterprise.inject.spi.DeploymentException: javax.enterprise.inject.UnsatisfiedResolutionException: Unsatisfied dependency for type io.quarkus.rest.client.reactive.HelloClient2 and qualifiers [@RestClient]
	- java member: io.quarkus.rest.client.reactive.HelloResource#client2
	- declared on CLASS bean [types=[io.quarkus.rest.client.reactive.HelloResource, java.lang.Object], qualifiers=[@Default, @Any], target=io.quarkus.rest.client.reactive.HelloResource]
	at io.quarkus.arc.processor.BeanDeployment.processErrors(BeanDeployment.java:1100)
	at io.quarkus.arc.processor.BeanDeployment.init(BeanDeployment.java:265)
	at io.quarkus.arc.processor.BeanProcessor.initialize(BeanProcessor.java:129)
	at io.quarkus.arc.deployment.ArcProcessor.validate(ArcProcessor.java:418)...

✖ io.quarkus.rest.client.reactive.provider.ProviderTest. - More details - Source on GitHub

java.lang.RuntimeException: 
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.arc.deployment.ArcProcessor#validate threw an exception: javax.enterprise.inject.spi.DeploymentException: javax.enterprise.inject.UnsatisfiedResolutionException: Unsatisfied dependency for type io.quarkus.rest.client.reactive.HelloClient2 and qualifiers [@RestClient]
	- java member: io.quarkus.rest.client.reactive.HelloResource#client2
	- declared on CLASS bean [types=[io.quarkus.rest.client.reactive.HelloResource, java.lang.Object], qualifiers=[@Default, @Any], target=io.quarkus.rest.client.reactive.HelloResource]
	at io.quarkus.arc.processor.BeanDeployment.processErrors(BeanDeployment.java:1100)
	at io.quarkus.arc.processor.BeanDeployment.init(BeanDeployment.java:265)
	at io.quarkus.arc.processor.BeanProcessor.initialize(BeanProcessor.java:129)
	at io.quarkus.arc.deployment.ArcProcessor.validate(ArcProcessor.java:418)...

⚙️ JVM Tests - JDK 16 #

📦 extensions/resteasy-reactive/rest-client-reactive/deployment

✖ io.quarkus.rest.client.reactive.provider.ProviderDisabledAutodiscoveryTest. - More details - Source on GitHub

java.lang.RuntimeException: 
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.arc.deployment.ArcProcessor#validate threw an exception: javax.enterprise.inject.spi.DeploymentException: javax.enterprise.inject.UnsatisfiedResolutionException: Unsatisfied dependency for type io.quarkus.rest.client.reactive.HelloClient2 and qualifiers [@RestClient]
	- java member: io.quarkus.rest.client.reactive.HelloResource#client2
	- declared on CLASS bean [types=[io.quarkus.rest.client.reactive.HelloResource, java.lang.Object], qualifiers=[@Default, @Any], target=io.quarkus.rest.client.reactive.HelloResource]
	at io.quarkus.arc.processor.BeanDeployment.processErrors(BeanDeployment.java:1100)
	at io.quarkus.arc.processor.BeanDeployment.init(BeanDeployment.java:265)
	at io.quarkus.arc.processor.BeanProcessor.initialize(BeanProcessor.java:129)
	at io.quarkus.arc.deployment.ArcProcessor.validate(ArcProcessor.java:418)...

✖ io.quarkus.rest.client.reactive.provider.ProviderPriorityTest. - More details - Source on GitHub

java.lang.RuntimeException: 
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.arc.deployment.ArcProcessor#validate threw an exception: javax.enterprise.inject.spi.DeploymentException: javax.enterprise.inject.UnsatisfiedResolutionException: Unsatisfied dependency for type io.quarkus.rest.client.reactive.HelloClient2 and qualifiers [@RestClient]
	- java member: io.quarkus.rest.client.reactive.HelloResource#client2
	- declared on CLASS bean [types=[io.quarkus.rest.client.reactive.HelloResource, java.lang.Object], qualifiers=[@Default, @Any], target=io.quarkus.rest.client.reactive.HelloResource]
	at io.quarkus.arc.processor.BeanDeployment.processErrors(BeanDeployment.java:1100)
	at io.quarkus.arc.processor.BeanDeployment.init(BeanDeployment.java:265)
	at io.quarkus.arc.processor.BeanProcessor.initialize(BeanProcessor.java:129)
	at io.quarkus.arc.deployment.ArcProcessor.validate(ArcProcessor.java:418)...

✖ io.quarkus.rest.client.reactive.provider.ProviderTest. - More details - Source on GitHub

java.lang.RuntimeException: 
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.arc.deployment.ArcProcessor#validate threw an exception: javax.enterprise.inject.spi.DeploymentException: javax.enterprise.inject.UnsatisfiedResolutionException: Unsatisfied dependency for type io.quarkus.rest.client.reactive.HelloClient2 and qualifiers [@RestClient]
	- java member: io.quarkus.rest.client.reactive.HelloResource#client2
	- declared on CLASS bean [types=[io.quarkus.rest.client.reactive.HelloResource, java.lang.Object], qualifiers=[@Default, @Any], target=io.quarkus.rest.client.reactive.HelloResource]
	at io.quarkus.arc.processor.BeanDeployment.processErrors(BeanDeployment.java:1100)
	at io.quarkus.arc.processor.BeanDeployment.init(BeanDeployment.java:265)
	at io.quarkus.arc.processor.BeanProcessor.initialize(BeanProcessor.java:129)
	at io.quarkus.arc.deployment.ArcProcessor.validate(ArcProcessor.java:418)...

gsmet · 2021-08-04T18:20:22Z

Pretty sure the CI failures are related.

stuartwdouglas · 2021-08-05T00:37:10Z

So my PR basically makes sure that if we are dispatching back to the IO thread we pick the same IO thread that is tied to the connection, rather than a random IO thread. This mimics the server behavior.

We have to be really careful with mutltiple threads being involved in reactive requests, there is a lot of potential for hard to debug races.

stuartwdouglas · 2021-08-05T00:38:54Z

.../runtime/src/main/java/org/jboss/resteasy/reactive/client/impl/RestClientRequestContext.java

@@ -202,7 +203,14 @@ public HttpClientResponse getVertxClientResponse() {
    @Override
    protected Executor getEventLoop() {
        if (httpClientRequest == null) {
-            return restClient.getVertx().nettyEventLoopGroup().next();
+            // make sure we execute the client callbacks on the same context as the current thread


This is not right, if this is being called from a worker then it will dispatch on the worker. You still need to actually dispatch to the relevant IO thread.

How can this be called from a worker thread, though? I've always seen it called from an IO thread.

It could be called by the user in org.jboss.resteasy.reactive.client.spi.ResteasyReactiveClientRequestContext from a org.jboss.resteasy.reactive.client.spi.ResteasyReactiveClientRequestFilter, which could be called from pretty much anywhere.

TBH I am really worried about this 'swapping threads' approach. It opens the door to lots of subtle bugs as we now need to ensure that we always do some kind of safe hand off between the threads. We also need to be super careful with IO, as things work differently if you are not on your IO thread, because as soon as you resume IO its possible another IO thread has started running the input handler, so you need to thing about the thread safety semantics of that.

From a performance point of view it also sucks, as it will involve multiple IO threads waking up selectors that don't belong to them, which is terrible from a performance POV.

I agree with the concerns, there's many similar difficulties with Hibernate Reactive.

As a user, I think I'd be fine to have to deal with stronger restrictions in exchange for less [potential] trouble.

Maybe we should just merge this for now (once the tests are passing), but look to the possibility of moving to a single thread model in future.

Thinking about it I am not sure how practical it will be, as having basically a pool of connections per IO thread is not going to be great for databases which have connection limits.

So can we merge this or not? Not trying to be pushy, but Hibernate Transactions are still broken without this (or a similar) fix :)

I think we should merge it for now, as I said above. I have rebased so lets see what CI says.

quarkus-bot · 2021-09-03T00:20:35Z

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building `61d5785`

Status	Name	Step	Failures	Logs	Raw logs
✖	JVM Tests - JDK 11	`Build`	Failures	Logs	Raw logs
✖	JVM Tests - JDK 11 Windows	`Build`	Failures	Logs	Raw logs
✖	JVM Tests - JDK 16	`Build`	Failures	Logs	Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 #

- Failing: extensions/resteasy-reactive/rest-client-reactive/deployment 
! Skipped: docs extensions/oidc-client-reactive-filter/deployment extensions/resteasy-reactive/rest-client-reactive-jackson/deployment and 5 more

📦 extensions/resteasy-reactive/rest-client-reactive/deployment

✖ io.quarkus.rest.client.reactive.provider.ProviderDisabledAutodiscoveryTest. - More details - Source on GitHub

java.lang.RuntimeException: 
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.arc.deployment.ArcProcessor#validate threw an exception: javax.enterprise.inject.spi.DeploymentException: javax.enterprise.inject.UnsatisfiedResolutionException: Unsatisfied dependency for type io.quarkus.rest.client.reactive.HelloClient2 and qualifiers [@RestClient]

✖ io.quarkus.rest.client.reactive.provider.ProviderPriorityTest. - More details - Source on GitHub

java.lang.RuntimeException: 
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.arc.deployment.ArcProcessor#validate threw an exception: javax.enterprise.inject.spi.DeploymentException: javax.enterprise.inject.UnsatisfiedResolutionException: Unsatisfied dependency for type io.quarkus.rest.client.reactive.HelloClient2 and qualifiers [@RestClient]

✖ io.quarkus.rest.client.reactive.provider.ProviderTest. - More details - Source on GitHub

java.lang.RuntimeException: 
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.arc.deployment.ArcProcessor#validate threw an exception: javax.enterprise.inject.spi.DeploymentException: javax.enterprise.inject.UnsatisfiedResolutionException: Unsatisfied dependency for type io.quarkus.rest.client.reactive.HelloClient2 and qualifiers [@RestClient]

⚙️ JVM Tests - JDK 11 Windows #

- Failing: extensions/resteasy-reactive/rest-client-reactive/deployment 
! Skipped: docs extensions/oidc-client-reactive-filter/deployment extensions/resteasy-reactive/rest-client-reactive-jackson/deployment and 5 more

📦 extensions/resteasy-reactive/rest-client-reactive/deployment

✖ io.quarkus.rest.client.reactive.provider.ProviderDisabledAutodiscoveryTest. - More details - Source on GitHub

java.lang.RuntimeException: 
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.arc.deployment.ArcProcessor#validate threw an exception: javax.enterprise.inject.spi.DeploymentException: javax.enterprise.inject.UnsatisfiedResolutionException: Unsatisfied dependency for type io.quarkus.rest.client.reactive.HelloClient2 and qualifiers [@RestClient]

✖ io.quarkus.rest.client.reactive.provider.ProviderPriorityTest. - More details - Source on GitHub

java.lang.RuntimeException: 
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.arc.deployment.ArcProcessor#validate threw an exception: javax.enterprise.inject.spi.DeploymentException: javax.enterprise.inject.UnsatisfiedResolutionException: Unsatisfied dependency for type io.quarkus.rest.client.reactive.HelloClient2 and qualifiers [@RestClient]

✖ io.quarkus.rest.client.reactive.provider.ProviderTest. - More details - Source on GitHub

java.lang.RuntimeException: 
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.arc.deployment.ArcProcessor#validate threw an exception: javax.enterprise.inject.spi.DeploymentException: javax.enterprise.inject.UnsatisfiedResolutionException: Unsatisfied dependency for type io.quarkus.rest.client.reactive.HelloClient2 and qualifiers [@RestClient]

⚙️ JVM Tests - JDK 16 #

- Failing: extensions/resteasy-reactive/rest-client-reactive/deployment extensions/smallrye-reactive-messaging-kafka/deployment 
! Skipped: docs extensions/oidc-client-reactive-filter/deployment extensions/resteasy-reactive/rest-client-reactive-jackson/deployment and 7 more

📦 extensions/resteasy-reactive/rest-client-reactive/deployment

✖ io.quarkus.rest.client.reactive.provider.ProviderDisabledAutodiscoveryTest. - More details - Source on GitHub

java.lang.RuntimeException: 
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.arc.deployment.ArcProcessor#validate threw an exception: javax.enterprise.inject.spi.DeploymentException: javax.enterprise.inject.UnsatisfiedResolutionException: Unsatisfied dependency for type io.quarkus.rest.client.reactive.HelloClient2 and qualifiers [@RestClient]

✖ io.quarkus.rest.client.reactive.provider.ProviderPriorityTest. - More details - Source on GitHub

java.lang.RuntimeException: 
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.arc.deployment.ArcProcessor#validate threw an exception: javax.enterprise.inject.spi.DeploymentException: javax.enterprise.inject.UnsatisfiedResolutionException: Unsatisfied dependency for type io.quarkus.rest.client.reactive.HelloClient2 and qualifiers [@RestClient]

✖ io.quarkus.rest.client.reactive.provider.ProviderTest. - More details - Source on GitHub

java.lang.RuntimeException: 
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.arc.deployment.ArcProcessor#validate threw an exception: javax.enterprise.inject.spi.DeploymentException: javax.enterprise.inject.UnsatisfiedResolutionException: Unsatisfied dependency for type io.quarkus.rest.client.reactive.HelloClient2 and qualifiers [@RestClient]

📦 extensions/smallrye-reactive-messaging-kafka/deployment

✖ io.quarkus.smallrye.reactivemessaging.kafka.deployment.testing.KafkaDevServicesContinuousTestingTestCase.testContinuousTestingScenario2 line 75 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Failed to wait for test run 2 State{lastRun=1, running=true, inProgress=false, run=1, passed=0, failed=1, skipped=0, isBrokenOnly=false, isTestOutput=false, isInstrumentationBasedReload=false, isLiveReload=true}
	at io.quarkus.test.ContinuousTestingTestUtils.waitForNextCompletion(ContinuousTestingTestUtils.java:43)
	at io.quarkus.smallrye.reactivemessaging.kafka.deployment.testing.KafkaDevServicesContinuousTestingTestCase.testContinuousTestingScenario2(KafkaDevServicesContinuousTestingTestCase.java:75)

Fixes quarkusio#18977

FroMage · 2021-09-09T09:15:19Z

Force-rebased, fixed the three tests. The kafka one on JDK16 I hope is unrelated. Let's see what CI says.

FroMage · 2021-09-09T09:16:05Z

I can confirm this fixes the issue I have in my cheese shop demo, where each REST client has its own IO thread, and I'm not sure what vert.x context they share.

FroMage · 2021-09-09T12:23:59Z

All checks passed, so it's up to @stuartwdouglas to reassess his review :)

ambition-consulting · 2021-09-15T06:58:15Z

Hi, when will this be released? We want to go to production next week and would really like to have our ELK working by then.

geoand · 2021-09-15T07:00:29Z

@FroMage @stuartwdouglas I am kinda hesitant to backport this, but if you think we should then I will.

stuartwdouglas · 2021-09-15T07:02:48Z

I think we should, it's pretty broken ATM.

geoand · 2021-09-15T07:05:39Z

Okay

ambition-consulting · 2021-09-15T07:54:20Z

Thank you - greatly appreciated. :)

geoand · 2021-09-15T08:02:53Z

So likely to be included in 2.2.4.Final which hopefully will be out next week sometime

ambition-consulting · 2021-09-16T11:58:18Z

I built the 2.2.3.Final with the changes from this PR locally, retested, and successfully verified that it should fix the problem.

FroMage requested review from stuartwdouglas and geoand August 4, 2021 12:51

quarkus-bot bot added the area/rest label Aug 4, 2021

FroMage mentioned this pull request Aug 4, 2021

Reactive REST Client breaks Hibernate Reactive Transactions #18977

Closed

Sanne approved these changes Aug 4, 2021

View reviewed changes

geoand changed the title ~~RR client: run client on same context~~ Run reactive rest client on Vertx same context Aug 4, 2021

stuartwdouglas requested changes Aug 5, 2021

View reviewed changes

stuartwdouglas force-pushed the 18977 branch from bf3fdd0 to 61d5785 Compare September 2, 2021 23:11

RR client: run client on same context

8dd0af4

Fixes quarkusio#18977

FroMage force-pushed the 18977 branch from 61d5785 to 8dd0af4 Compare September 9, 2021 09:14

stuartwdouglas approved these changes Sep 9, 2021

View reviewed changes

stuartwdouglas merged commit 300d8e8 into quarkusio:main Sep 9, 2021

quarkus-bot bot added this to the 2.3 - main milestone Sep 9, 2021

geoand added the triage/backport? label Sep 15, 2021

ambition-consulting mentioned this pull request Sep 16, 2021

Tracing broken when mixing JAX-RS reactive with reactive routes #15182

Closed

gsmet modified the milestones: 2.3.0.CR1, 2.2.4.Final Nov 30, 2021

gsmet removed the triage/backport-2.2? label Nov 30, 2021

Run reactive rest client on Vertx same context #19225

Run reactive rest client on Vertx same context #19225

Conversation

FroMage commented Aug 4, 2021

geoand commented Aug 4, 2021

FroMage commented Aug 4, 2021

geoand commented Aug 4, 2021

Sanne commented Aug 4, 2021

geoand commented Aug 4, 2021

geoand commented Aug 4, 2021

FroMage commented Aug 4, 2021

geoand commented Aug 4, 2021

quarkus-bot bot commented Aug 4, 2021 • edited Loading

Failing Jobs - Building bf3fdd0

Test Failures

⚙️ JVM Tests - JDK 11 #

📦 extensions/resteasy-reactive/rest-client-reactive/deployment

⚙️ JVM Tests - JDK 11 Windows #

📦 extensions/resteasy-reactive/rest-client-reactive/deployment

⚙️ JVM Tests - JDK 16 #

📦 extensions/resteasy-reactive/rest-client-reactive/deployment

gsmet commented Aug 4, 2021

stuartwdouglas commented Aug 5, 2021

stuartwdouglas Aug 5, 2021

Choose a reason for hiding this comment

FroMage Aug 5, 2021

Choose a reason for hiding this comment

stuartwdouglas Aug 10, 2021

Choose a reason for hiding this comment

Sanne Aug 10, 2021

Choose a reason for hiding this comment

stuartwdouglas Aug 12, 2021

Choose a reason for hiding this comment

markusdlugi Aug 27, 2021

Choose a reason for hiding this comment

stuartwdouglas Sep 2, 2021

Choose a reason for hiding this comment

quarkus-bot bot commented Sep 3, 2021 • edited Loading

Failing Jobs - Building 61d5785

Failures

⚙️ JVM Tests - JDK 11 #

📦 extensions/resteasy-reactive/rest-client-reactive/deployment

⚙️ JVM Tests - JDK 11 Windows #

📦 extensions/resteasy-reactive/rest-client-reactive/deployment

⚙️ JVM Tests - JDK 16 #

📦 extensions/resteasy-reactive/rest-client-reactive/deployment

📦 extensions/smallrye-reactive-messaging-kafka/deployment

FroMage commented Sep 9, 2021

FroMage commented Sep 9, 2021

FroMage commented Sep 9, 2021

ambition-consulting commented Sep 15, 2021

geoand commented Sep 15, 2021

stuartwdouglas commented Sep 15, 2021

geoand commented Sep 15, 2021

ambition-consulting commented Sep 15, 2021

geoand commented Sep 15, 2021

ambition-consulting commented Sep 16, 2021 • edited Loading

quarkus-bot bot commented Aug 4, 2021 •

edited

Loading

Failing Jobs - Building `bf3fdd0`

quarkus-bot bot commented Sep 3, 2021 •

edited

Loading

Failing Jobs - Building `61d5785`

ambition-consulting commented Sep 16, 2021 •

edited

Loading