Honor read timeout in reactive rest client #19223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This workflow status is outdated as a new workflow run has been triggered. 🚫 This workflow run has been cancelled. Failing Jobs - Building 8119002
|
geoand
commented
Aug 4, 2021
...time/src/main/java/org/jboss/resteasy/reactive/client/handlers/ClientSendRequestHandler.java
Outdated
Show resolved
Hide resolved
geoand
commented
Aug 4, 2021
| @@ -197,8 +195,8 @@ public Response get() { | |||
| throw new BlockingNotAllowedException(); | |||
| } | |||
| try { | |||
| return c.get(readTimeoutMs, TimeUnit.MILLISECONDS); | |||
There was a problem hiding this comment.
This is no longer needed (and is actually incorrect) as the timeout handling is performed by Vert.x
michalszynkiewicz
approved these changes
Aug 4, 2021
Before this change the read timeout only had an effect when doing a synchronous call (and even then it didn't result in the proper Vert.x exception) The connect timeout handling doesn't need any changes because it is properly handled when org.jboss.resteasy.reactive.client.impl.ClientImpl is created Fixes: quarkusio#17526
Yeah, that's a good follow up :) |
geoand
added
the
triage/waiting-for-ci
|
This workflow status is outdated as a new workflow run has been triggered. 🚫 This workflow run has been cancelled. Failing Jobs - Building f6cd978
|
quarkus-bot
bot
removed
the
triage/waiting-for-ci
geoand
added a commit
to geoand/quarkus
that referenced
this pull request
Aug 5, 2021
Follow up on: quarkusio#19223
geoand
added a commit
to geoand/quarkus
that referenced
this pull request
Aug 5, 2021
Follow up on: quarkusio#19223
geoand
added a commit
that referenced
this pull request
Aug 19, 2021
Add test for rest-client reactive timeout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change the read timeout only had an effect when doing
a synchronous call (and even then it didn't result in the proper Vert.x exception)
The connect timeout handling doesn't need any changes because it is properly handled
when org.jboss.resteasy.reactive.client.impl.ClientImpl is created
Fixes: #17526