Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure various non-bean JAX-RS components work in native #19201

Merged
merged 1 commit into from
Aug 3, 2021
Merged

Ensure various non-bean JAX-RS components work in native #19201

merged 1 commit into from
Aug 3, 2021
+24 −3

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Aug 3, 2021

Fixes: #16211

@geoand geoand requested a review from stuartwdouglas August 3, 2021 12:25
@geoand geoand mentioned this pull request Aug 3, 2021
Closed
@quarkus-bot
Copy link

quarkus-bot bot commented Aug 3, 2021

Failing Jobs - Building 12c47ad

Status Name Step Test failures Logs Raw logs
✖ Gradle Tests - JDK 11 Windows Build ⚠️ Check → Logs Raw logs

gsmet
gsmet approved these changes Aug 3, 2021
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes sense and it can't hurt so I'm merging this to get it into 2.1.1.Final.

@gsmet gsmet merged commit 2a43b29 into quarkusio:main Aug 3, 2021
@quarkus-bot quarkus-bot bot added this to the 2.2 - main milestone Aug 3, 2021
@geoand geoand deleted the #16211 branch August 3, 2021 16:57
@geoand
Copy link
Contributor Author

geoand commented Aug 3, 2021

Thanks 👍

@gsmet gsmet modified the milestones: 2.2 - main, 2.1.1.Final Aug 3, 2021
FroMage
FroMage reviewed Aug 4, 2021
View reviewed changes
Copy link
Member

@FroMage FroMage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would probably have benefited from a native test…

@geoand
Copy link
Contributor Author

geoand commented Aug 4, 2021

Indeed, I'll keep it in mind

geoand added a commit to geoand/quarkus that referenced this pull request Aug 4, 2021
@geoand
Use RESTEasy Reactive in oidc integration test
bf87765 
This is done in order to address:
quarkusio#19201 (review)
@geoand geoand mentioned this pull request Aug 4, 2021
Merged
@geoand
Copy link
Contributor Author

geoand commented Aug 4, 2021

@FroMage here you go: #19227. It also uncovered an unrelated RR bug

@FroMage
Copy link
Member

FroMage commented Aug 5, 2021

Wow :)

geoand added a commit that referenced this pull request Aug 5, 2021
@geoand
Merge pull request #19227 from geoand/#19201-follow-up
f14f9a7 
Use RESTEasy Reactive in oidc integration test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FroMage FroMage FroMage left review comments

@gsmet gsmet gsmet approved these changes

@stuartwdouglas stuartwdouglas Awaiting requested review from stuartwdouglas

Assignees
No one assigned
Labels
area/rest
Projects
None yet
Milestone
2.1.1.Final
Development

Successfully merging this pull request may close these issues.

Reactive resteasy native exception
3 participants
@geoand @FroMage @gsmet