-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Init bootstrap gradle plugin #19067
Init bootstrap gradle plugin #19067
Conversation
distributionUrl=https\://services.gradle.org/distributions/gradle-6.9-all.zip | ||
======= | ||
distributionUrl=https\://services.gradle.org/distributions/gradle-6.8-bin.zip | ||
>>>>>>> d232aad03c (Add wrapper) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a leftover from a merge?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh right, this is a mistake.
I am not sure bootstrap is the right place for it though. Which is also true for the corresponding Maven goal. It's related to the extension building. Perhaps it should be |
This comment has been minimized.
This comment has been minimized.
5a330d4
to
f439bd1
Compare
@aloubyansky, I fixed the conflict and renamed the plugin. Should I move it somewhere else or is |
Perhaps we could make https://github.com/quarkusio/quarkus/tree/main/devtools/gradle a common parent for the |
It could probably be a multi-module gradle project? |
Not sure though whether it helps from the release/publishing perspective. |
We'll need to start some "Quarkus extension development with Gradle" docs too :) |
We could move it under ˋdevtools/gradle` but not sure if it helps.. |
This workflow status is outdated as a new workflow run has been triggered. |
I thought that way both plugins could share a common parent config and would be built and released at the same time. Otherwise, if they are two independent projects they would have to be released kind of separately. Or is it not exactly true? @gsmet, wdyt? As to docs, sure, they can take time. |
Yes I think that would make sense to release both plugin at the same time. And the gradle part would be only in one place. |
f439bd1
to
190490a
Compare
@aloubyansky I created a multi-module gradle project that contains both plugins. |
|
||
testImplementation "io.quarkus:quarkus-project-core-extension-codestarts:${version}" | ||
testImplementation 'org.assertj:assertj-core:3.20.2' | ||
testImplementation 'org.junit.jupiter:junit-jupiter:5.7.2' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The above versions seem to be common for both plugins, could we define them in the parent project?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh right, fixed, with other common dependencies.
@gsmet we should check how this will affect the release process/scripts. |
190490a
to
149651e
Compare
149651e
to
bbe14c4
Compare
bbe14c4
to
9b54bd6
Compare
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building 9b54bd6
Full information is available in the Build summary check run. Test Failures⚙️ JVM Tests - JDK 11 #📦 extensions/scheduler/deployment✖
⚙️ JVM Tests - JDK 11 Windows #📦 extensions/opentelemetry/opentelemetry/deployment✖
⚙️ JVM Tests - JDK 16 #📦 extensions/scheduler/deployment✖
📦 integration-tests/oidc-wiremock✖
✖
✖
✖
|
9b54bd6
to
8f59a5b
Compare
This workflow status is outdated as a new workflow run has been triggered. |
dabe400
to
422e8b7
Compare
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building 422e8b7
Full information is available in the Build summary check run. Test Failures⚙️ JVM Tests - JDK 16 #📦 extensions/smallrye-reactive-messaging-kafka/deployment✖
|
@glefloch @famod @aloubyansky I suggest we wait for the Gradle 7.2 upgrade to get in before rebasing and merging this one. |
422e8b7
to
d7b5d3c
Compare
@gsmet sure, I rebased my branch to check if everything works with gradle 7. |
@gsmet can we merge this one? |
d7b5d3c
to
9f7b523
Compare
@glefloch is it good to merge in your opinion? |
I think so, most annoying gradle issues have been a fix. |
@geoand I would merge it ASAP but I'd like to make sure we are prepared to release it. It is second Gradle plugin. |
@glefloch please write at least a little doc describing how to use it and what it does. It could be in a separate PR. |
Gotcha! |
@gastaldi IIRC you handled the details of releasing the original plugin the first time around? |
@aloubyansky yes, I'm taking care of the doc today. |
Yes, that's right. |
So we'll probably summon you next week :) |
Publishing is easy, you can use the same token for the original plugin: https://github.com/quarkusio/quarkus-release/blob/main/release-gradle-plugin.sh#L24 |
We'll give it a shot :) |
I think this should still work and publish both plugins |
@glefloch little follow up request. Could you please add |
This branch introduce a new Gradle boostrap plugin that will help extension developer if they want to use gradle.
This is a first step that only generate the
quarkus-extension.properties
file and does not handle capabilities for now.One issue I see so far, is that the group id of the project corresponds to the plugin name, in that case
io.quarkus.bootstrap
.Can that be an issue when publishing artifacts?