Mongodb Liquibase extension #18573

loicmathieu · 2021-07-09T14:39:39Z

Fixes #18009, #9801

quarkus-bot · 2021-07-09T14:39:41Z

Thanks for your pull request!

The title of your pull request does not follow our editorial rules. Could you have a look?

title should count at least 2 words to describe the change properly

This message is automatically generated by a bot.

quarkus-bot · 2021-07-13T11:02:55Z

This workflow status is outdated as a new workflow run has been triggered.

🚫 This workflow run has been cancelled.

Failing Jobs - Building `3f65171`

⚠️ Artifacts of the workflow run were not available thus the report misses some details.

Status	Name	Step	Test failures	Logs	Raw logs
⌛	Attach pull request number	`Upload pull request number`	⚠️ Check →	Logs	Raw logs
⌛	CI Sanity Check	`Build`	⚠️ Check →	Logs	Raw logs

quarkus-bot · 2021-07-13T11:15:28Z

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building `3f65171`

Status	Name	Step	Test failures	Logs	Raw logs
✖	Initial JDK 11 Build	`Build`	⚠️ Check →	Logs	Raw logs

quarkus-bot · 2021-07-16T10:42:52Z

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building `3f65171`

Status	Name	Step	Test failures	Logs	Raw logs
✖	Initial JDK 11 Build	`Build`	⚠️ Check →	Logs	Raw logs

quarkus-bot · 2021-08-20T10:13:13Z

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building `62d6459`

Status	Name	Step	Test failures	Logs	Raw logs
✖	Initial JDK 11 Build	`Build`	⚠️ Check →	Logs	Raw logs

quarkus-bot · 2021-08-20T12:43:22Z

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building `a7dd23e`

Status	Name	Step	Test failures	Logs	Raw logs
✖	Initial JDK 11 Build	`Verify extension dependencies`	⚠️ Check →	Logs	Raw logs

quarkus-bot · 2021-08-20T18:03:46Z

This workflow status is outdated as a new workflow run has been triggered.

✖ This workflow run has failed but no jobs reported an error. Something weird happened, please check the workflow run page carefully: it might be an issue with the workflow configuration itself.

geoand · 2021-08-23T09:47:45Z

Nice! I have a large backlog to catch up on, so I am not sure I'll get to this in the next 48 hours.

loicmathieu · 2021-08-23T10:11:04Z

Nice! I have a large backlog to catch up on, so I am not sure I'll get to this in the next 48 hours.

Happy you're back and hope you have a good PTO.
It's not urgent, there is still plenty of time untill 2.3.

geoand

Seems pretty similar to the liquibase proper extension, so it looks good

...odb/deployment/src/main/java/io/quarkus/liquibase/mongodb/deployment/LiquibaseProcessor.java

quarkus-bot · 2021-08-25T15:48:29Z

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building `b77e500`

Status	Name	Step	Test failures	Logs	Raw logs
✖	Initial JDK 11 Build	`Build`	⚠️ Check →	Logs	Raw logs

Fixes quarkusio#18009, quarkusio#9801

evanchooly

Looks fine to me modulo a couple of style questions.

...ns/liquibase-mongodb/runtime/src/main/java/io/quarkus/liquibase/LiquibaseMongodbFactory.java

evanchooly · 2021-08-31T14:04:12Z

...odb/deployment/src/main/java/io/quarkus/liquibase/mongodb/deployment/LiquibaseProcessor.java

+                liquibase.database.jvm.JdbcConnection.class.getName()));
+
+        reflective.produce(new ReflectiveClassBuildItem(true, true, true,
+                liquibase.parser.ChangeLogParserCofiguration.class.getName(),


any reason for the FQCNs here?

Same reason as for your other comment.

Well, in fact if I use simple name this will ends up with tens of imports. I think that's why it has been done like this in the liquibase extension. Maybe using String would be better as it would avoid loading the class.

Howerver, when using String, you can ends up registering for reflection classes that didn't exist anymore as you'll not be notified when they'll deleted.

maybe @geoand have an advice on this ?

personally, i'd rather have imports i can collapse away but don't hold up the merge just for this.

It should be just fine the way you have it.

gsmet · 2021-08-31T15:55:33Z

bom/application/pom.xml

@@ -159,6 +159,7 @@
        <flyway.version>7.14.0</flyway.version>
        <yasson.version>1.0.9</yasson.version>
        <liquibase.version>4.4.3</liquibase.version>
+        <liquibase-mongodb.version>4.4.3</liquibase-mongodb.version>


A bit late to the party but is there a reason to have a separate version? Aren't they part of the same build?

Asking because it might be a pain for Dependabot.

I'll check, when I first start working on it month ago they had totally different versions, but the mongodb one was experimental.
If they are now always the same, I'll change it when I write the guide (before 2.3)

Cool, thanks. And yes, I just think it needs a change if we are guaranteed they are built at the same time. What I'm worried about is Dependabot updating one at a time and thus having partial failing PRs.

So the version of the mongodb extension follow the one of the core liquibase but it's not release on the same day. I may have up to 10 days between a release of the core liquibase lib and the mongodb one.
There also can exist patch version for bugfixes on the liquibase mongodb extension (for ex 4.1.1.1 that don't exist for liquibase core).

...ibase-mongodb/runtime/src/main/java/io/quarkus/liquibase/runtime/LiquibaseMongodbConfig.java

...godb/runtime/src/main/java/io/quarkus/liquibase/runtime/LiquibaseMongodbBuildTimeConfig.java

quarkus-bot bot added area/core area/dependencies Pull requests that update a dependency file labels Jul 9, 2021

loicmathieu changed the title ~~Mongodb/liquibase~~ Mongodb Liquibase extension Jul 9, 2021

loicmathieu force-pushed the mongodb/liquibase branch from 9dd7e9a to 3f65171 Compare July 13, 2021 10:57

loicmathieu marked this pull request as ready for review July 13, 2021 10:57

loicmathieu force-pushed the mongodb/liquibase branch from 3f65171 to 62d6459 Compare August 20, 2021 09:57

loicmathieu force-pushed the mongodb/liquibase branch from 62d6459 to a7dd23e Compare August 20, 2021 12:29

loicmathieu force-pushed the mongodb/liquibase branch from a7dd23e to 0dae7bf Compare August 20, 2021 13:30

loicmathieu added the area/mongodb label Aug 20, 2021

quarkus-bot bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/documentation labels Aug 20, 2021

loicmathieu added area/liquibase release/noteworthy-feature and removed area/documentation area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins labels Aug 20, 2021

loicmathieu requested review from evanchooly and geoand August 23, 2021 08:15

geoand reviewed Aug 24, 2021

View reviewed changes

...odb/deployment/src/main/java/io/quarkus/liquibase/mongodb/deployment/LiquibaseProcessor.java Outdated Show resolved Hide resolved

loicmathieu force-pushed the mongodb/liquibase branch from 0dae7bf to 53ff6fc Compare August 25, 2021 11:19

quarkus-bot bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/documentation labels Aug 25, 2021

loicmathieu force-pushed the mongodb/liquibase branch from 53ff6fc to 28fcf09 Compare August 25, 2021 11:22

quarkus-bot bot added the area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure label Aug 25, 2021

geoand approved these changes Aug 25, 2021

View reviewed changes

loicmathieu force-pushed the mongodb/liquibase branch from 28fcf09 to b77e500 Compare August 25, 2021 15:15

loicmathieu force-pushed the mongodb/liquibase branch from b77e500 to d7f3bbf Compare August 31, 2021 07:52

Liquibase MongoDB extension

48b365f

Fixes quarkusio#18009, quarkusio#9801

loicmathieu force-pushed the mongodb/liquibase branch from d7f3bbf to 48b365f Compare August 31, 2021 11:10

evanchooly approved these changes Aug 31, 2021

View reviewed changes

loicmathieu added this to the 2.3 - main milestone Aug 31, 2021

loicmathieu merged commit 650761a into quarkusio:main Aug 31, 2021

loicmathieu deleted the mongodb/liquibase branch August 31, 2021 15:22

gsmet reviewed Aug 31, 2021

View reviewed changes

machi1990 reviewed Aug 31, 2021

View reviewed changes

...ibase-mongodb/runtime/src/main/java/io/quarkus/liquibase/runtime/LiquibaseMongodbConfig.java Show resolved Hide resolved

machi1990 reviewed Aug 31, 2021

View reviewed changes

...godb/runtime/src/main/java/io/quarkus/liquibase/runtime/LiquibaseMongodbBuildTimeConfig.java Show resolved Hide resolved

loicmathieu mentioned this pull request Jan 31, 2022

mongodb-panache indexes #9801

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Mongodb Liquibase extension #18573

Mongodb Liquibase extension #18573

loicmathieu commented Jul 9, 2021 •

edited

Loading

quarkus-bot bot commented Jul 9, 2021

quarkus-bot bot commented Jul 13, 2021 •

edited

Loading

Failing Jobs - Building `3f65171`

quarkus-bot bot commented Jul 13, 2021 •

edited

Loading

Failing Jobs - Building `3f65171`

quarkus-bot bot commented Jul 16, 2021 •

edited

Loading

Failing Jobs - Building `3f65171`

quarkus-bot bot commented Aug 20, 2021 •

edited

Loading

Failing Jobs - Building `62d6459`

quarkus-bot bot commented Aug 20, 2021 •

edited

Loading

Failing Jobs - Building `a7dd23e`

quarkus-bot bot commented Aug 20, 2021 •

edited

Loading

geoand commented Aug 23, 2021

loicmathieu commented Aug 23, 2021

geoand left a comment

quarkus-bot bot commented Aug 25, 2021 •

edited

Loading

Failing Jobs - Building `b77e500`

evanchooly left a comment

evanchooly Aug 31, 2021

loicmathieu Aug 31, 2021

loicmathieu Aug 31, 2021

loicmathieu Aug 31, 2021

loicmathieu Aug 31, 2021

evanchooly Aug 31, 2021

geoand Aug 31, 2021

gsmet Aug 31, 2021

loicmathieu Aug 31, 2021

gsmet Aug 31, 2021

loicmathieu Sep 1, 2021

Mongodb Liquibase extension #18573

Mongodb Liquibase extension #18573

Conversation

loicmathieu commented Jul 9, 2021 • edited Loading

quarkus-bot bot commented Jul 9, 2021

quarkus-bot bot commented Jul 13, 2021 • edited Loading

Failing Jobs - Building 3f65171

quarkus-bot bot commented Jul 13, 2021 • edited Loading

Failing Jobs - Building 3f65171

quarkus-bot bot commented Jul 16, 2021 • edited Loading

Failing Jobs - Building 3f65171

quarkus-bot bot commented Aug 20, 2021 • edited Loading

Failing Jobs - Building 62d6459

quarkus-bot bot commented Aug 20, 2021 • edited Loading

Failing Jobs - Building a7dd23e

quarkus-bot bot commented Aug 20, 2021 • edited Loading

geoand commented Aug 23, 2021

loicmathieu commented Aug 23, 2021

geoand left a comment

Choose a reason for hiding this comment

quarkus-bot bot commented Aug 25, 2021 • edited Loading

Failing Jobs - Building b77e500

evanchooly left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

loicmathieu commented Jul 9, 2021 •

edited

Loading

quarkus-bot bot commented Jul 13, 2021 •

edited

Loading

Failing Jobs - Building `3f65171`

quarkus-bot bot commented Jul 13, 2021 •

edited

Loading

Failing Jobs - Building `3f65171`

quarkus-bot bot commented Jul 16, 2021 •

edited

Loading

Failing Jobs - Building `3f65171`

quarkus-bot bot commented Aug 20, 2021 •

edited

Loading

Failing Jobs - Building `62d6459`

quarkus-bot bot commented Aug 20, 2021 •

edited

Loading

Failing Jobs - Building `a7dd23e`

quarkus-bot bot commented Aug 20, 2021 •

edited

Loading

quarkus-bot bot commented Aug 25, 2021 •

edited

Loading

Failing Jobs - Building `b77e500`