-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Opentracing it #18169
Opentracing it #18169
Conversation
@kenfinnigan if you can have a look at it, it's still a draft as I need to find why the JDBC span is not created. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable from a first look through
...-tests/smallrye-opentracing/src/test/java/io/quarkus/it/opentracing/OpenTracingTestCase.java
Show resolved
Hide resolved
147e8f2
to
5eae36a
Compare
@loicmathieu Have you seen #18313? Are you ok with it? |
@kenfinnigan no, I'm OK to merge my changes on the new IT created for Zipkin compatibility when merged. |
5eae36a
to
21333f1
Compare
21333f1
to
5e748ca
Compare
@kenfinnigan I rebase my PR onto main now that zipkin compatibility mode has been merged. If you think testing zipkin compatibility is important, I can copy the existing test and include it as a QuarkusUnitTest inside the deployment module of quarkus-jaeger. |
5e748ca
to
ff4f072
Compare
...-tests/smallrye-opentracing/src/test/java/io/quarkus/it/opentracing/OpenTracingTestCase.java
Outdated
Show resolved
Hide resolved
If you could add the Zipkin compatibility test back in the deployment I think that would be good. Thanks |
OK, will do it |
ff4f072
to
2e0d93c
Compare
@kenfinnigan I fix the JDBC test. For Zipkin, there is already a test inside the jaeger extension: https://github.com/quarkusio/quarkus/blob/main/extensions/jaeger/deployment/src/test/java/io/quarkus/jaeger/test/QuarkusJaegerTracerTest.java#L29 |
This PR creates a Smallrye OpenTracing integration test (inspired by the OpenTelemetry one) and include a specific test for the JDBC instrumentation.
This is still a work in progress as the JDBC span is not created, but the test crash if we use the current JDBC driver version and pass if we use version 2.0.4 so it might have catch #18033 if we had it previously.