Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add selector to Deployment when missing #18136

Merged

Conversation

iocanel
Copy link
Contributor

@iocanel iocanel commented Jun 24, 2021

Resolves: #18095

@gsmet gsmet requested a review from geoand June 25, 2021 07:59
String base = basedir
File kubernetesYml = new File(base, "target/kubernetes/kubernetes.yml")
assert kubernetesYml.exists()
kubernetesYml.withInputStream { stream ->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a good reason to use the maven-invoker-way of testing?

I really dislike them as they are impossible to debug :)

Copy link
Contributor Author

@iocanel iocanel Jun 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using existing resources (via src/main/kubernetes) is not currently possible with QuarkusProdModeTest.

AFAIR, I tried to implement it in the past, but this would require creating a normal project structure under the hood (with a real pom, src folders etc).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, understood

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really dislike them as they are impossible to debug :)

It's a PITA to debug the verify script.
The groovy simplicity makes up for it (at least it does for me).

The actual build can be debugged using:

mvn clean install -pl :quarkus-integration-test-kubernetes-invoker -Dinvoker.test=kubernetes-with-existing-selectorless-manifest -Dinvoker.mavenExecutable=mvnDebug

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to know, thanks

@gsmet gsmet merged commit 7afaf16 into quarkusio:main Jun 28, 2021
@quarkus-bot quarkus-bot bot added this to the 2.1 - main milestone Jun 28, 2021
@gsmet gsmet modified the milestones: 2.1 - main, 2.0.1.Final Jun 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

quarkus-kubernetes: wrong kubernetes resource get generated when using an existing resource
3 participants