-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add selector to Deployment when missing #18136
Add selector to Deployment when missing #18136
Conversation
String base = basedir | ||
File kubernetesYml = new File(base, "target/kubernetes/kubernetes.yml") | ||
assert kubernetesYml.exists() | ||
kubernetesYml.withInputStream { stream -> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a good reason to use the maven-invoker-way
of testing?
I really dislike them as they are impossible to debug :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using existing resources (via src/main/kubernetes
) is not currently possible with QuarkusProdModeTest.
AFAIR, I tried to implement it in the past, but this would require creating a normal project structure under the hood (with a real pom, src folders etc).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, understood
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really dislike them as they are impossible to debug :)
It's a PITA to debug the verify script.
The groovy simplicity makes up for it (at least it does for me).
The actual build can be debugged using:
mvn clean install -pl :quarkus-integration-test-kubernetes-invoker -Dinvoker.test=kubernetes-with-existing-selectorless-manifest -Dinvoker.mavenExecutable=mvnDebug
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to know, thanks
Resolves: #18095