Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide actionable message when @QuarkusIntegrationTest is run before the Quarkus build #18081

Merged
merged 1 commit into from
Jun 22, 2021
Merged

Provide actionable message when @QuarkusIntegrationTest is run before the Quarkus build #18081

merged 1 commit into from
Jun 22, 2021

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Jun 22, 2021

This has come up a few times with this discussion being the latest one.

@geoand geoand requested a review from famod June 22, 2021 14:25
@geoand geoand force-pushed the integration-test-message branch from 65fb0a1 to 3ca3d6b Compare June 22, 2021 14:33
@quarkus-bot
Copy link

quarkus-bot bot commented Jun 22, 2021 •
edited
Loading

This workflow status is outdated as a new workflow run has been triggered.

🚫 This workflow run has been cancelled.

Failing Jobs - Building 65fb0a1

⚠️ Artifacts of the workflow run were not available thus the report misses some details.

Status Name Step Test failures Logs Raw logs
⌛ Initial JDK 11 Build Build ⚠️ Check → Logs Raw logs

@geoand geoand force-pushed the integration-test-message branch from 3ca3d6b to a6a7fa3 Compare June 22, 2021 14:44
@quarkus-bot
Copy link

quarkus-bot bot commented Jun 22, 2021 •
edited
Loading

This workflow status is outdated as a new workflow run has been triggered.

🚫 This workflow run has been cancelled.

Failing Jobs - Building 3ca3d6b

⚠️ Artifacts of the workflow run were not available thus the report misses some details.

Status Name Step Test failures Logs Raw logs
⌛ Initial JDK 11 Build Build ⚠️ Check → Logs Raw logs

famod
famod approved these changes Jun 22, 2021
View reviewed changes
Copy link
Member

@famod famod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested it myself but looks like a nice improvement of user experience! 👍

@geoand geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jun 22, 2021
@geoand geoand merged commit 51fc23b into quarkusio:main Jun 22, 2021
@quarkus-bot quarkus-bot bot added this to the 2.1 - main milestone Jun 22, 2021
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jun 22, 2021
@gsmet gsmet modified the milestones: 2.1 - main, 2.0.0.Final Jun 22, 2021
@geoand geoand deleted the integration-test-message branch June 23, 2021 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@famod famod famod approved these changes

Assignees
No one assigned
Labels
area/testing
Projects
None yet
Milestone
2.0.0.Final
Development

Successfully merging this pull request may close these issues.
3 participants
@geoand @famod @gsmet