-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scala 2.12 does not support a JDK 11 target #18067
Conversation
And in any case, it will need to be -target:11 when we switch to 2.13.
@famod I'm surprised this change triggered so many native builds? |
@gsmet I'll have a look later today. |
Interesting:
So, no changes have been detected. 🤔 I'll check that warning. PS: No changes means full build btw. because an empty list of changed modules is considered to be the "GIB disabled" case in CI. |
I have to take a closer look but I think this is a bug in GIB somewhere here: https://github.com/gitflow-incremental-builder/gitflow-incremental-builder/blob/master/src/main/java/com/vackosar/gitflowincrementalbuild/control/ChangedProjects.java#L47-L48 |
I suppose it's because the change was inside a nested Maven project maybe? |
Yes, I think so. I'll have to take into account |
I have a fix for this. I'll release GIB 3.14.3 in the next few days. |
And in any case, it will need to be -target:11 when we switch to 2.13.