Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cli cleanup #18013

Merged
merged 3 commits into from
Jun 21, 2021
Merged

Cli cleanup #18013

merged 3 commits into from
Jun 21, 2021

Conversation

ebullient
Copy link
Member

Support providing Java -D options at create time, too (just in case). Handle that better across commands.

Flip -S and -s, where -p and -s specify platform/stream, and -S is now for searching ..

Consistent specification of emoji, and use less-boring rocketship.

@quarkus-bot quarkus-bot bot added area/cli Related to quarkus cli (not maven/gradle/etc.) area/codestarts area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/documentation area/jbang Issues related to when using jbang.dev with Quarkus area/platform Issues related to definition and interaction with Quarkus Platform labels Jun 18, 2021
@ebullient ebullient mentioned this pull request Jun 18, 2021
Merged
@quarkus-bot
Copy link

quarkus-bot bot commented Jun 18, 2021 •
edited
Loading

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 31395a2

Status Name Step Test failures Logs Raw logs
✔️ JVM Tests - JDK 11
✖ JVM Tests - JDK 11 Windows Build Test failures Logs Raw logs
✔️ JVM Tests - JDK 16

Full information is available in the Build summary check run.

Test Failures

⚙️ JVM Tests - JDK 11 Windows #

📦 extensions/grpc/deployment

✖ io.quarkus.grpc.devconsole.DevConsoleUnaryMethodTest.websocketTest line 55 - More details - Source on GitHub

gsmet
gsmet reviewed Jun 21, 2021
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: is -P already taken? I would rather keep the most common option (i.e. search) with a lowercase character.

@ebullient
Copy link
Member Author

Question: is -P already taken? I would rather keep the most common option (i.e. search) with a lowercase character.

updated

@stuartwdouglas stuartwdouglas merged commit ac4188b into quarkusio:main Jun 21, 2021
@quarkus-bot quarkus-bot bot added this to the 2.1 - main milestone Jun 21, 2021
@gsmet gsmet modified the milestones: 2.1 - main, 2.0.0.Final Jun 22, 2021
@ebullient ebullient deleted the cli-cleanup branch June 29, 2021 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet left review comments

@stuartwdouglas stuartwdouglas stuartwdouglas approved these changes

@gastaldi gastaldi gastaldi approved these changes

Assignees
No one assigned
Labels
area/cli Related to quarkus cli (not maven/gradle/etc.) area/codestarts area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/documentation area/jbang Issues related to when using jbang.dev with Quarkus area/platform Issues related to definition and interaction with Quarkus Platform
Projects
None yet
Milestone
2.0.0.Final
Development

Successfully merging this pull request may close these issues.
4 participants
@ebullient @gastaldi @stuartwdouglas @gsmet