Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Devtools: support pulling in the complete platform catalog from a single member bom #18011

Merged

Conversation

aloubyansky
Copy link
Member

@aloubyansky aloubyansky commented Jun 18, 2021

This change allows to specify e.g. a single member bom with -p like

quarkus create -p io.quarkus.platform:quarkus-bom:999-SNAPSHOT hibernate-orm qpid

and install extensions from other member BOMs that belong to the same release. I.e.

    <quarkus.platform.artifact-id>quarkus-bom</quarkus.platform.artifact-id>
    <quarkus.platform.group-id>io.quarkus.platform</quarkus.platform.group-id>
    <quarkus.platform.version>999-SNAPSHOT</quarkus.platform.version>
    <surefire-plugin.version>3.0.0-M5</surefire-plugin.version>
  </properties>
  <dependencyManagement>
    <dependencies>
      <dependency>
        <groupId>${quarkus.platform.group-id}</groupId>
        <artifactId>quarkus-qpid-jms-bom</artifactId>
        <version>${quarkus.platform.version}</version>
        <type>pom</type>
        <scope>import</scope>
      </dependency>
      <dependency>
        <groupId>${quarkus.platform.group-id}</groupId>
        <artifactId>${quarkus.platform.artifact-id}</artifactId>
        <version>${quarkus.platform.version}</version>
        <type>pom</type>
        <scope>import</scope>
      </dependency>
    </dependencies>
  </dependencyManagement>
  <dependencies>
    <dependency>
      <groupId>io.quarkus</groupId>
      <artifactId>quarkus-hibernate-orm</artifactId>
    </dependency>
    <dependency>
      <groupId>org.amqphub.quarkus</groupId>
      <artifactId>quarkus-qpid-jms</artifactId>
    </dependency>

@quarkus-bot quarkus-bot bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/platform Issues related to definition and interaction with Quarkus Platform labels Jun 18, 2021
@aloubyansky aloubyansky changed the title SDevtools: spport pulling in the complete platform catalog from a single member bom Devtools: spport pulling in the complete platform catalog from a single member bom Jun 18, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented Jun 18, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 45fa3f1

Status Name Step Test failures Logs Raw logs
✔️ JVM Tests - JDK 11
JVM Tests - JDK 11 Windows Build Test failures Logs Raw logs
✔️ JVM Tests - JDK 16

Full information is available in the Build summary check run.

Test Failures

⚙️ JVM Tests - JDK 11 Windows #

📦 extensions/resteasy-reactive/jaxrs-client-reactive/deployment

io.quarkus.jaxrs.client.reactive.deployment.test.UniInvokerTestCase.testInjection line 48 - More details - Source on GitHub

📦 extensions/smallrye-reactive-messaging-amqp/deployment

io.quarkus.smallrye.reactivemessaging.amqp.devmode.nohttp.AmqpDevModeNoHttpTest.testProducerUpdate line 70 - More details - Source on GitHub

@aloubyansky aloubyansky force-pushed the member-to-full-platform-catalog branch from 45fa3f1 to 5c5db4c Compare June 18, 2021 20:21
@aloubyansky
Copy link
Member Author

@gastaldi do you mind reviewing this one?

@gastaldi gastaldi merged commit 9a44ccc into quarkusio:main Jun 19, 2021
@quarkus-bot quarkus-bot bot added this to the 2.1 - main milestone Jun 19, 2021
@gsmet gsmet changed the title Devtools: spport pulling in the complete platform catalog from a single member bom Devtools: support pulling in the complete platform catalog from a single member bom Jun 21, 2021
@gsmet gsmet modified the milestones: 2.1 - main, 2.0.0.Final Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/platform Issues related to definition and interaction with Quarkus Platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants