Update OidcClientImpl to throw ISE if the client is closed #17932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gastaldi
reviewed
Jun 15, 2021
extensions/oidc-client/runtime/src/main/java/io/quarkus/oidc/client/runtime/OidcClientImpl.java
Outdated
Show resolved
Hide resolved
gastaldi
approved these changes
Jun 15, 2021
|
@gastaldi Hi George, sure, I actually forgot about it :-), sorry about it... |
sberyozkin
force-pushed
the
oidc_client_close
branch
from
dfde79f to
2719875
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16472
OidcClientcan be injected or obtained viaOidcClientsand one way or the other it will be eventually closed. So this PR updatesOidcClientto throw ISE if itsgetTokensorrefreshTokensis called after it has been closed