Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mongodb-client BuildStep that includes org.bson.types.* classes to Jandex index #17895

Merged
merged 1 commit into from
Jun 15, 2021
Merged

Add mongodb-client BuildStep that includes org.bson.types.* classes to Jandex index #17895

merged 1 commit into from
Jun 15, 2021

Conversation

afedotov
Copy link
Contributor

@afedotov afedotov commented Jun 14, 2021 •
edited by gastaldi
Loading

This PR fixes #17893.

@quarkus-bot
Copy link

quarkus-bot bot commented Jun 14, 2021

Thanks for your pull request!

The title of your pull request does not follow our editorial rules. Could you have a look?

This message is automatically generated by a bot.

@afedotov afedotov changed the title [Issue#17893] mongodb-client BuildStep that adds org.bson.types.* classes to Jandex index Add mongodb-client BuildStep that includes org.bson.types.* classes to Jandex index Jun 14, 2021
geoand
geoand approved these changes Jun 15, 2021
View reviewed changes
Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, thanks!

@geoand geoand requested a review from loicmathieu June 15, 2021 07:24
@geoand geoand mentioned this pull request Jun 15, 2021
Merged
loicmathieu
loicmathieu approved these changes Jun 15, 2021
View reviewed changes
Copy link
Contributor

@loicmathieu loicmathieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I remember doing something specific for MongoDB with Panache for this issue but it seems to disapear some times ago.

@loicmathieu loicmathieu added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jun 15, 2021
@loicmathieu loicmathieu added this to the 2.1 - main milestone Jun 15, 2021
@gastaldi gastaldi merged commit 6f753a6 into quarkusio:main Jun 15, 2021
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jun 15, 2021
@gsmet gsmet modified the milestones: 2.1 - main, 2.0.0.Final Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoand geoand geoand approved these changes

@loicmathieu loicmathieu loicmathieu approved these changes

Assignees
No one assigned
Labels
area/mongodb
Projects
None yet
Milestone
2.0.0.Final
Development

Successfully merging this pull request may close these issues.

MongoDB BSON types are not in the Jandex index
5 participants
@afedotov @loicmathieu @geoand @gastaldi @gsmet