Fix 'Failed to index' warnings for arrays from entities #17890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quarkus-bot
bot
added
area/hibernate-orm
yrodiere
approved these changes
Jun 14, 2021
yrodiere
added
the
triage/waiting-for-ci
quarkus-bot
bot
removed
the
triage/waiting-for-ci
mkouba
reviewed
Jul 14, 2021
| @@ -350,7 +350,8 @@ private void addClassHierarchyToReflectiveList(Collector collector, DotName clas | |||
| // we need to check for enums | |||
| for (FieldInfo fieldInfo : classInfo.fields()) { | |||
| Type fieldType = fieldInfo.type(); | |||
| if (Type.Kind.PRIMITIVE == fieldType.kind()) { | |||
| if (Type.Kind.CLASS != fieldType.kind()) { | |||
There was a problem hiding this comment.
Hm, this would also skip parameterized types. I don't know if it could be a problem in the context of hibernate extension... just saying.
There was a problem hiding this comment.
This loop is about registering enum types for reflection. I don't think an enum can even be parameterized? Even if it can, I don't think the code below would work.
Regardless... I'm sure there are problems with this code (I mean the whole class), in particular with complex models involving generics. IMO our best way forward is to just avoid the need for registering types for reflection. Which is something we've been working on :)
There was a problem hiding this comment.
Ok np, I didn't know it's for enums only ;-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://quarkusio.zulipchat.com/#narrow/stream/187030-users/topic/.5B2.2E0.2E0.2ECR3.2B.5D.20.22Failed.20to.20index.22.20warnings
Fix as suggested by @yrodiere