-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TLS: Introduce *-alias to select specific key to use (or cert to trust) #17884
Conversation
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building 68bedec
Full information is available in the Build summary check run. Test Failures⚙️ JVM Tests - JDK 16 #📦 extensions/vertx-http/deployment✖ |
...nsions/vertx-http/runtime/src/main/java/io/quarkus/vertx/http/runtime/CertificateConfig.java
Outdated
Show resolved
Hide resolved
I had a talk with my colleague @mickroll and I think this parameter naming question becomes more relevant: Maybe it would be better to have:
?
? WDYT? |
are definitely better, and for this PR in particular, |
Remarks have been addressed. Btw, I went with |
Resolves #17424 Notes on store modifications in integration-tests/vertx-http: - added key pair to server-keystore.jks with alias "anotherserver" (which comes before the existing "server" pair) - added key pair to new client-keystore-2.jks and added its cert chain to server-truststore.jks with alias "mykey-2" - renamed existing "mykey" to "mykey-1" in server-truststore.jks - renamed client-keystore.jks to client-keystore-1.jks
This workflow status is outdated as a new workflow run has been triggered. |
Failing Jobs - Building 0f68fa1
Full information is available in the Build summary check run. Test Failures⚙️ JVM Tests - JDK 11 Windows #📦 integration-tests/resteasy-reactive-rest-client✖ |
Looks it is OK to merge, Clement @cescoffier has also approved, the failing test on Windows is not related to this PR |
Resolves #17424
Notes on store modifications in integration-tests/vertx-http:
More notes:
KeyStoreOptions
in the recorder