Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move some of the test deps out of quarkus-bom #17772

Merged
merged 1 commit into from
Jun 28, 2021
Merged

Move some of the test deps out of quarkus-bom #17772

merged 1 commit into from
Jun 28, 2021

Conversation

aloubyansky
Copy link
Member

Move some of the test-related dependencies out of quarkus-bom to either quarkus-bom-test or quarkus-build-parent.

@quarkus-bot quarkus-bot bot added the area/dependencies Pull requests that update a dependency file label Jun 8, 2021
gsmet
gsmet requested changes Jun 8, 2021
View reviewed changes
bom/application/pom.xml Outdated
<jaxb-runtime.version>2.3.3-b02</jaxb-runtime.version>
<!-- just for test dependency convergence -->
<jaxb-api.version>2.3.1</jaxb-api.version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about this one and the one above. I think we'd better keep them as there's a good chance it could break dependency convergence.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

None of them appear to be a dependency of any extension (runtime or deployment).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, they are back.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is looking ok now to you @gsmet ?

@quarkus-bot
Copy link

quarkus-bot bot commented Jun 8, 2021 •
edited
Loading

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 39370ac

Status Name Step Test failures Logs Raw logs
⌛ MicroProfile TCKs Tests Verify ⚠️ Check → Logs Raw logs

gsmet
gsmet approved these changes Jun 28, 2021
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll let you rebase it.

@quarkus-bot
Copy link

quarkus-bot bot commented Jun 28, 2021 •
edited
Loading

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building c35911d

Status Name Step Test failures Logs Raw logs
✖ Initial JDK 11 Build Build ⚠️ Check → Logs Raw logs

@gsmet gsmet added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jun 28, 2021
@aloubyansky aloubyansky merged commit a2729a3 into quarkusio:main Jun 28, 2021
@quarkus-bot quarkus-bot bot added this to the 2.1 - main milestone Jun 28, 2021
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jun 28, 2021
@rsvoboda
Copy link
Member

rsvoboda commented Jul 9, 2021

We have hit the issue with htmlunit no longer present in quarkus-bom, we have defined the version explicitly in dependencyManagement of the project we use.

I think migration guide should mention these removals from quarkus-bom as people may use those dependencies from our bom file. @aloubyansky / @gsmet wdyt?

@aloubyansky
Copy link
Member Author

Makes sense. @gsmet which migration guide should I add it too?

@pjgg pjgg mentioned this pull request Jul 9, 2021
Merged
@rsvoboda
Copy link
Member

rsvoboda commented Jul 9, 2021

There is no https://github.com/quarkusio/quarkus/wiki/Migration-Guide-2.1 yet

@rsvoboda
Copy link
Member

@aloubyansky / @gsmet ^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet approved these changes

Assignees
No one assigned
Labels
area/dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
2.1.0.CR1
Development

Successfully merging this pull request may close these issues.
3 participants
@aloubyansky @rsvoboda @gsmet