Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give processes launched by @QuarkusIntegrationTest a chance to terminate normally #17757

Merged
merged 1 commit into from
Jun 8, 2021

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Jun 8, 2021

This is especially useful when launching a docker container because
the --rm flag of docker run ... takes only if the process is terminated
normally

Fixes: #17737

…ate normally

This is especially useful when launching a docker container because
the '--rm' flag of 'docker run' takes only if the process is terminated
normally

Fixes: quarkusio#17737
Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gastaldi gastaldi merged commit 0ef29e5 into quarkusio:main Jun 8, 2021
@quarkus-bot quarkus-bot bot added this to the 2.1 - main milestone Jun 8, 2021
@gastaldi gastaldi deleted the #17737 branch June 8, 2021 11:25
@gsmet gsmet modified the milestones: 2.1 - main, 2.0.0.Final Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

QuarkusIntegrationTest docker run, does not clean container after timeout
3 participants