-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce ci workflow for kubernetes/openshift end to end testing #17674
Conversation
Thanks for your pull request! The title of your pull request does not follow our editorial rules. Could you have a look?
|
This workflow status is outdated as a new workflow run has been triggered. |
This workflow status is outdated as a new workflow run has been triggered. |
This workflow status is outdated as a new workflow run has been triggered. |
This workflow status is outdated as a new workflow run has been triggered. |
This workflow status is outdated as a new workflow run has been triggered. |
This workflow status is outdated as a new workflow run has been triggered. |
This workflow status is outdated as a new workflow run has been triggered. |
This workflow status is outdated as a new workflow run has been triggered. |
This workflow status is outdated as a new workflow run has been triggered. |
This workflow status is outdated as a new workflow run has been triggered. |
branches: | ||
- main | ||
pull_request: | ||
types: [ opened, edited, labeled, reopened, synchronize ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a bit concerned abuot enabling this kinda run on all prs...wont we run out of resources quite quickly that way ? :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree, this is why the workflow is limited only to prs labelled with area/kubernetes
(see condition below)
- name: Run Openshift Invoker Tests | ||
run: | | ||
echo "${{ secrets.GITHUB_TOKEN }}" | docker login ghcr.io -u ${{ github.actor }} --password-stdin | ||
export QUARKUS_CONTAINER_IMAGE_GROUP=${{ github.actor }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wont you need a way to make the published image unique - i.e. based on which pr/branch its running againts to avoid collisions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a very good point. Maybe, we should set the version to something that includes the pr number, timestamp etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's try with the sha
@maxandersen @gsmet: I have nothing more to add! Can you please review? |
@maxandersen @gsmet: ping |
Looks good to me. @gsmet any concerns we enable this now or wait after 2.0 build ? |
@gsmet: ping |
This workflow status is outdated as a new workflow run has been triggered. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, very promising! It needs a bit more work though.
...ts/kubernetes/maven-invoker-way/src/it/kubernetes-docker-build-and-deploy/invoker.properties
Outdated
Show resolved
Hide resolved
This workflow status is outdated as a new workflow run has been triggered. 🚫 This workflow run has been cancelled. Failing Jobs - Building 5b41d8a
|
This comment has been minimized.
This comment has been minimized.
@gsmet: I think that all requested changes have been applied and related ci failures have been addressed. Still see some jobs failing, but they do seem irrelevant with the pr. |
@gsmet: howdy! is there anything else you need me to add? |
Sorry, my time was very limited until now and I never prioritized this one. I'm going to assign it to me and have a look in the next few days. Thanks for the patience. |
This comment has been minimized.
This comment has been minimized.
Just a heads up that I'm actively working on this one and making significant changes (also setting up the appropriate Quay infrastructure for testing). I'll ping you when I have a state that requires your attention. |
This comment has been minimized.
This comment has been minimized.
|
@iocanel I can see the version is fixed but I have a new failure in the Kubernetes tests:
Caused by:
And we still have the deployment issue I reported earlier in the OpenShift test:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And now it's all good! Woot!
Failing Jobs - Building 432ae34
Full information is available in the Build summary check run. Failures⚙️ Gradle Tests - JDK 11 #- Failing: integration-tests/gradle
📦 integration-tests/gradle✖
✖
✖
⚙️ JVM Tests - JDK 11 #- Failing: extensions/resteasy-reactive/quarkus-resteasy-reactive/deployment
! Skipped: extensions/avro/deployment extensions/grpc/deployment extensions/hibernate-reactive/deployment and 106 more 📦 extensions/resteasy-reactive/quarkus-resteasy-reactive/deployment✖
⚙️ JVM Tests - JDK 17 #- Failing: integration-tests/elasticsearch-rest-client
📦 integration-tests/elasticsearch-rest-client✖ ⚙️ JVM Tests - JDK 18 #- Failing: extensions/resteasy-reactive/quarkus-resteasy-reactive/deployment
! Skipped: extensions/avro/deployment extensions/grpc/deployment extensions/hibernate-reactive/deployment and 106 more 📦 extensions/resteasy-reactive/quarkus-resteasy-reactive/deployment✖
|
This pull request introduces a new workflow for running end to end tests using
minikube
andoc cluster up
(this limits us to v3.11 but its better than nothing).In detail:
The workflow is meant to be triggered only for pull requests labelled with the
kubernetes
label.When the workflow is triggered it will run two new jobs:
kubernetes
andopenshift
.The
kubernetes
job will spin upminikube
and then trigger the maven invoker intgration tests for kubernetes.The
openshift
job will spin upoc cluster up
and then trigger the maven invoker intgration tests for openshift.The integration tests have been also modified so that can be selected using profiles.