-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for platform streams in the registry client #17446
Conversation
Failing Jobs - Building 8324e61
Full information is available in the Build summary check run. Test Failures⚙️ Maven Tests - JDK 11 #📦 integration-tests/maven✖ |
@gastaldi can you have a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@gastaldi this will need changes in the registry. If we merge it now, the registry won't be usable with the devtools. |
@aloubyansky fair enough, can we get this in the CR1 release and have a PR for the registry? |
AFAIK,it's too late for cr1. |
That's fine, we just need to make sure the registry works in 2.0.0.Final, since it doesn't seem to be used ATM. @phillip-kruger might be interested in these changes too, as AFAIK he was working with @ia3andy on adapting code.quarkus.io to read from the registry |
Sure, @phillip-kruger let me know if you need my help with that. |
Thanks :) At this point I am not sure if I know enough to know what I don't know and where I need help :) I am still trying to figure out how to get a catalog of all extensions for a certain version and platform... |
Let's take it to zulip. |
This PR introduces the notion of platform streams to the registry client API.