Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for platform streams in the registry client #17446

Merged
merged 1 commit into from
May 26, 2021

Conversation

aloubyansky
Copy link
Member

This PR introduces the notion of platform streams to the registry client API.

@quarkus-bot quarkus-bot bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/maven area/platform Issues related to definition and interaction with Quarkus Platform labels May 25, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented May 25, 2021

Failing Jobs - Building 8324e61

Status Name Step Test failures Logs Raw logs
Maven Tests - JDK 11 Build Test failures Logs Raw logs

Full information is available in the Build summary check run.

Test Failures

⚙️ Maven Tests - JDK 11 #

📦 integration-tests/maven

io.quarkus.maven.it.DevMojoIT.testThatNewResourcesAreServed line 849 - More details - Source on GitHub

@gsmet
Copy link
Member

gsmet commented May 26, 2021

@gastaldi can you have a look?

Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aloubyansky
Copy link
Member Author

aloubyansky commented May 26, 2021

@gastaldi this will need changes in the registry. If we merge it now, the registry won't be usable with the devtools.

@gastaldi
Copy link
Contributor

@aloubyansky fair enough, can we get this in the CR1 release and have a PR for the registry?

@aloubyansky
Copy link
Member Author

AFAIK,it's too late for cr1.

@aloubyansky aloubyansky merged commit 3ebd950 into quarkusio:main May 26, 2021
@quarkus-bot quarkus-bot bot added this to the 2.0 - main milestone May 26, 2021
@gastaldi
Copy link
Contributor

AFAIK,it's too late for cr1.

That's fine, we just need to make sure the registry works in 2.0.0.Final, since it doesn't seem to be used ATM.

@phillip-kruger might be interested in these changes too, as AFAIK he was working with @ia3andy on adapting code.quarkus.io to read from the registry

@aloubyansky
Copy link
Member Author

Sure, @phillip-kruger let me know if you need my help with that.

@phillip-kruger
Copy link
Member

Thanks :) At this point I am not sure if I know enough to know what I don't know and where I need help :)

I am still trying to figure out how to get a catalog of all extensions for a certain version and platform...

@aloubyansky
Copy link
Member Author

Let's take it to zulip.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/maven area/platform Issues related to definition and interaction with Quarkus Platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants