Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support nonProxyHosts for Vault client #17369

Merged
merged 1 commit into from
May 25, 2021
Merged

Support nonProxyHosts for Vault client #17369

merged 1 commit into from
May 25, 2021

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented May 19, 2021

Fixes #16453

Draft as it will require a new version of Vert.x.

@gsmet gsmet mentioned this pull request May 19, 2021
Closed
@gsmet gsmet force-pushed the vault-nonProxyHosts branch from 7e4d38f to 2eea5ce Compare May 25, 2021 07:39
@gsmet gsmet marked this pull request as ready for review May 25, 2021 07:40
@quarkus-bot
Copy link

quarkus-bot bot commented May 25, 2021 •
edited
Loading

This workflow status is outdated as a new workflow run has been triggered.

🚫 This workflow run has been cancelled.

Failing Jobs - Building 2eea5ce

⚠️ Artifacts of the workflow run were not available thus the report misses some details.

Status Name Step Test failures Logs Raw logs
⌛ CI Sanity Check Build ⚠️ Check → Logs Raw logs

@gsmet
Copy link
Member Author

gsmet commented May 25, 2021

@vsevel with the Vert.x upgrade Clément just did, this one is now ready for review.

@quarkus-bot
Copy link

quarkus-bot bot commented May 25, 2021 •
edited
Loading

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 2eea5ce

Status Name Step Test failures Logs Raw logs
✖ JVM Tests - JDK 11 Build Test failures Logs Raw logs
✖ JVM Tests - JDK 11 Windows Build Test failures Logs Raw logs
✖ JVM Tests - JDK 16 Build Test failures Logs Raw logs
✖ Native Tests - Security3 Build Test failures Logs Raw logs

Full information is available in the Build summary check run.

Test Failures

⚙️ JVM Tests - JDK 11 #

📦 extensions/vault/runtime

✖ io.quarkus.vault.runtime.VaultAuthManagerTest.login line 42 - More details - Source on GitHub

✖ io.quarkus.vault.runtime.VaultDbManagerTest.getDynamicDbCredentials line 48 - More details - Source on GitHub

⚙️ JVM Tests - JDK 11 Windows #

📦 extensions/vault/runtime

✖ io.quarkus.vault.runtime.VaultAuthManagerTest.login line 42 - More details - Source on GitHub

✖ io.quarkus.vault.runtime.VaultDbManagerTest.getDynamicDbCredentials line 48 - More details - Source on GitHub

⚙️ JVM Tests - JDK 16 #

📦 extensions/vault/runtime

✖ io.quarkus.vault.runtime.VaultAuthManagerTest.login line 42 - More details - Source on GitHub

✖ io.quarkus.vault.runtime.VaultDbManagerTest.getDynamicDbCredentials line 48 - More details - Source on GitHub

⚙️ Native Tests - Security3 #

📦 integration-tests/vault-agroal

✖ io.quarkus.vault.AgroalVaultITCase. - More details - Source on GitHub

✖ io.quarkus.vault.AgroalVaultKv1ITCase. - More details - Source on GitHub

✖ io.quarkus.vault.VaultKv1ITCase. - More details - Source on GitHub

📦 integration-tests/vault-app

✖ io.quarkus.it.vault.VaultInGraalITCase.test - More details - Source on GitHub

📦 integration-tests/vault

✖ io.quarkus.vault.VaultAppRoleITCase. - More details - Source on GitHub

✖ io.quarkus.vault.VaultAppRoleWrapITCase. - More details - Source on GitHub

✖ io.quarkus.vault.VaultAuthITCase. - More details - Source on GitHub

✖ io.quarkus.vault.VaultClientTokenWrapITCase. - More details - Source on GitHub

✖ io.quarkus.vault.VaultEnterpriseITCase. - More details - Source on GitHub

✖ io.quarkus.vault.VaultITCase. - More details - Source on GitHub

✖ io.quarkus.vault.VaultKubernetesITCase. - More details - Source on GitHub

✖ io.quarkus.vault.VaultMultiPathConfigITCase. - More details - Source on GitHub

✖ io.quarkus.vault.VaultSysITCase. - More details - Source on GitHub

✖ io.quarkus.vault.VaultTOTPITCase. - More details - Source on GitHub

✖ io.quarkus.vault.VaultTransitITCase. - More details - Source on GitHub

✖ io.quarkus.vault.VaultUserpassKvv1WrapITCase. - More details - Source on GitHub

✖ io.quarkus.vault.VaultUserpassKvv2WrapITCase. - More details - Source on GitHub

@gsmet gsmet force-pushed the vault-nonProxyHosts branch from 2eea5ce to eb0a7ce Compare May 25, 2021 08:40
@quarkus-bot
Copy link

quarkus-bot bot commented May 25, 2021 •
edited
Loading

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building eb0a7ce

Status Name Step Test failures Logs Raw logs
✖ JVM Tests - JDK 11 Build Test failures Logs Raw logs
✖ JVM Tests - JDK 16 Build Test failures Logs Raw logs
✖ Native Tests - Security3 Build Test failures Logs Raw logs

Full information is available in the Build summary check run.

Test Failures

⚙️ JVM Tests - JDK 11 #

📦 integration-tests/vault-agroal

✖ io.quarkus.vault.AgroalVaultITCase. - More details - Source on GitHub

✖ io.quarkus.vault.AgroalVaultKv1ITCase. - More details - Source on GitHub

✖ io.quarkus.vault.VaultKv1ITCase. - More details - Source on GitHub

📦 integration-tests/vault-app

✖ io.quarkus.it.vault.VaultTest.test - More details - Source on GitHub

📦 integration-tests/vault

✖ io.quarkus.vault.VaultAppRoleITCase. - More details - Source on GitHub

✖ io.quarkus.vault.VaultAppRoleWrapITCase. - More details - Source on GitHub

✖ io.quarkus.vault.VaultAuthITCase. - More details - Source on GitHub

✖ io.quarkus.vault.VaultClientTokenWrapITCase. - More details - Source on GitHub

✖ io.quarkus.vault.VaultEnterpriseITCase. - More details - Source on GitHub

✖ io.quarkus.vault.VaultITCase. - More details - Source on GitHub

✖ io.quarkus.vault.VaultKubernetesITCase. - More details - Source on GitHub

✖ io.quarkus.vault.VaultMultiPathConfigITCase. - More details - Source on GitHub

✖ io.quarkus.vault.VaultSysITCase. - More details - Source on GitHub

✖ io.quarkus.vault.VaultTOTPITCase. - More details - Source on GitHub

✖ io.quarkus.vault.VaultTransitITCase. - More details - Source on GitHub

✖ io.quarkus.vault.VaultUserpassKvv1WrapITCase. - More details - Source on GitHub

✖ io.quarkus.vault.VaultUserpassKvv2WrapITCase. - More details - Source on GitHub

⚙️ JVM Tests - JDK 16 #

📦 integration-tests/vault-agroal

✖ io.quarkus.vault.AgroalVaultITCase. - More details - Source on GitHub

✖ io.quarkus.vault.AgroalVaultKv1ITCase. - More details - Source on GitHub

✖ io.quarkus.vault.VaultKv1ITCase. - More details - Source on GitHub

📦 integration-tests/vault-app

✖ io.quarkus.it.vault.VaultTest.test - More details - Source on GitHub

📦 integration-tests/vault

✖ io.quarkus.vault.VaultAppRoleITCase. - More details - Source on GitHub

✖ io.quarkus.vault.VaultAppRoleWrapITCase. - More details - Source on GitHub

✖ io.quarkus.vault.VaultAuthITCase. - More details - Source on GitHub

✖ io.quarkus.vault.VaultClientTokenWrapITCase. - More details - Source on GitHub

✖ io.quarkus.vault.VaultEnterpriseITCase. - More details - Source on GitHub

✖ io.quarkus.vault.VaultITCase. - More details - Source on GitHub

✖ io.quarkus.vault.VaultKubernetesITCase. - More details - Source on GitHub

✖ io.quarkus.vault.VaultMultiPathConfigITCase. - More details - Source on GitHub

✖ io.quarkus.vault.VaultSysITCase. - More details - Source on GitHub

✖ io.quarkus.vault.VaultTOTPITCase. - More details - Source on GitHub

✖ io.quarkus.vault.VaultTransitITCase. - More details - Source on GitHub

✖ io.quarkus.vault.VaultUserpassKvv1WrapITCase. - More details - Source on GitHub

✖ io.quarkus.vault.VaultUserpassKvv2WrapITCase. - More details - Source on GitHub

⚙️ Native Tests - Security3 #

📦 integration-tests/vault-agroal

✖ io.quarkus.vault.AgroalVaultITCase. - More details - Source on GitHub

✖ io.quarkus.vault.AgroalVaultKv1ITCase. - More details - Source on GitHub

✖ io.quarkus.vault.VaultKv1ITCase. - More details - Source on GitHub

📦 integration-tests/vault-app

✖ io.quarkus.it.vault.VaultInGraalITCase.test - More details - Source on GitHub

📦 integration-tests/vault

✖ io.quarkus.vault.VaultAppRoleITCase. - More details - Source on GitHub

✖ io.quarkus.vault.VaultAppRoleWrapITCase. - More details - Source on GitHub

✖ io.quarkus.vault.VaultAuthITCase. - More details - Source on GitHub

✖ io.quarkus.vault.VaultClientTokenWrapITCase. - More details - Source on GitHub

✖ io.quarkus.vault.VaultEnterpriseITCase. - More details - Source on GitHub

✖ io.quarkus.vault.VaultITCase. - More details - Source on GitHub

✖ io.quarkus.vault.VaultKubernetesITCase. - More details - Source on GitHub

✖ io.quarkus.vault.VaultMultiPathConfigITCase. - More details - Source on GitHub

✖ io.quarkus.vault.VaultSysITCase. - More details - Source on GitHub

✖ io.quarkus.vault.VaultTOTPITCase. - More details - Source on GitHub

✖ io.quarkus.vault.VaultTransitITCase. - More details - Source on GitHub

✖ io.quarkus.vault.VaultUserpassKvv1WrapITCase. - More details - Source on GitHub

✖ io.quarkus.vault.VaultUserpassKvv2WrapITCase. - More details - Source on GitHub

@gsmet gsmet force-pushed the vault-nonProxyHosts branch from eb0a7ce to 37604ad Compare May 25, 2021 09:19
vsevel
vsevel reviewed May 25, 2021
View reviewed changes
Copy link
Contributor

@vsevel vsevel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks fo handling this @gsmet . I have only 2 minor comments.

...nsions/vault/runtime/src/main/java/io/quarkus/vault/runtime/config/VaultBootstrapConfig.java Show resolved Hide resolved
...ns/vault/runtime/src/main/java/io/quarkus/vault/runtime/client/MutinyVertxClientFactory.java Show resolved Hide resolved
@gsmet gsmet merged commit 73767af into quarkusio:main May 25, 2021
@quarkus-bot quarkus-bot bot added this to the 2.0 - main milestone May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsevel vsevel vsevel approved these changes

Assignees
No one assigned
Labels
area/testing area/vault
Projects
None yet
Milestone
2.0.0.CR1
Development

Successfully merging this pull request may close these issues.

Upgrading from 1.11.x to 1.13.x breaks kubernetes authentication for quarkus-vault extension
2 participants
@gsmet @vsevel