Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional sort in REST Data Panache #17274

Merged
merged 2 commits into from
Jul 7, 2021

Conversation

gytis
Copy link

@gytis gytis commented May 17, 2021

Fixes: #16871

@quarkus-bot
Copy link

quarkus-bot bot commented May 17, 2021

Thanks for your pull request!

The title of your pull request does not follow our editorial rules. Could you have a look?

This message is automatically generated by a bot.

@gytis gytis force-pushed the 16871-optional-sort-usage branch from 1dcada7 to 5b516a3 Compare May 17, 2021 10:15
@gytis gytis force-pushed the 16871-optional-sort-usage branch from 5b516a3 to bdf3ad9 Compare May 17, 2021 10:15
@quarkus-bot
Copy link

quarkus-bot bot commented May 17, 2021

This workflow status is outdated as a new workflow run has been triggered.

🚫 This workflow run has been cancelled.

Failing Jobs - Building 1dcada7

⚠️ Artifacts of the workflow run were not available thus the report misses some details.

Status Name Step Test failures Logs Raw logs
Initial JDK 11 Build Reclaim Disk Space ⚠️ Check → Logs Raw logs

@quarkus-bot
Copy link

quarkus-bot bot commented May 17, 2021

This workflow status is outdated as a new workflow run has been triggered.

🚫 This workflow run has been cancelled.

Failing Jobs - Building 5b516a3

⚠️ Artifacts of the workflow run were not available thus the report misses some details.

Status Name Step Test failures Logs Raw logs
Initial JDK 11 Build Run actions/checkout@v2 ⚠️ Check → Logs Raw logs
CI Sanity Check Build ⚠️ Check → Logs Raw logs

@geoand geoand changed the title Optional sort in REST Data Panache #16871 Optional sort in REST Data Panache May 17, 2021
@geoand geoand requested a review from loicmathieu May 17, 2021 11:03
@FroMage
Copy link
Member

FroMage commented Jun 30, 2021

Huh, this fell through the cracks. I'll have to rebase it on main and add a test.

@FroMage FroMage force-pushed the 16871-optional-sort-usage branch from bdf3ad9 to edbc2b8 Compare July 6, 2021 15:43
@FroMage
Copy link
Member

FroMage commented Jul 6, 2021

Rebased and added test

@FroMage FroMage merged commit a4ab9b0 into quarkusio:main Jul 7, 2021
@quarkus-bot quarkus-bot bot added this to the 2.1 - main milestone Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rest Data with Panache check if "?sort" parameter is specified
2 participants