Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More test CL changes #17200

Merged
merged 1 commit into from
May 13, 2021
Merged

More test CL changes #17200

merged 1 commit into from
May 13, 2021

Conversation

stuartwdouglas
Copy link
Member

@stuartwdouglas stuartwdouglas commented May 13, 2021

This allows non-class resources to be loaded parent first
to work around ClassLoading issues in libraries.

Fixes #17175
Fixes #17195

@quarkus-bot quarkus-bot bot added the area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins label May 13, 2021
@geoand
Copy link
Contributor

geoand commented May 13, 2021

Any chance we can have a test for this?

This allows non-class resources to be loaded parent first
to work around ClassLoading issues in libraries.

Fixes quarkusio#17175
@stuartwdouglas
Copy link
Member Author

The picocli-native test effectively tests this out, as it has this problem, but I have added an explicit test.

Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great hack :)

@gastaldi gastaldi merged commit c133787 into quarkusio:main May 13, 2021
@quarkus-bot quarkus-bot bot added this to the 2.0 - main milestone May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins
Projects
None yet
3 participants