Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Honor GenerateResourceBuildItem while building UberJar #17199

Merged
merged 1 commit into from
May 13, 2021
Merged

Honor GenerateResourceBuildItem while building UberJar #17199

merged 1 commit into from
May 13, 2021

Conversation

gastaldi
Copy link
Contributor

@gastaldi gastaldi commented May 13, 2021 •
edited
Loading

Uber JARs should contain what's produced by GenerateResourceBuildItems instead of having them overwritten by files inside the transitive dependencies

This is a potential solution for quarkiverse/quarkus-cxf#194

This was referenced May 13, 2021
Closed
Closed
@gastaldi gastaldi requested review from geoand and gsmet May 13, 2021 01:13
@gastaldi
Copy link
Contributor Author

/cc @shumonsharif @dufoli

@gastaldi gastaldi force-pushed the generate_resources_uber branch from 1234fb7 to 50b9a4d Compare May 13, 2021 01:25
@quarkusio quarkusio deleted a comment from quarkus-bot bot May 13, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented May 13, 2021 •
edited
Loading

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 50b9a4d

Status Name Step Test failures Logs Raw logs
✖ Gradle Tests - JDK 11 Windows Build Test failures Logs Raw logs
✖ Maven Tests - JDK 11 Build Test failures Logs Raw logs

Full information is available in the Build summary check run.

Test Failures

⚙️ Gradle Tests - JDK 11 Windows #

📦 integration-tests/gradle

✖ io.quarkus.gradle.devmode.CustomQuarkusDevModeConfigurationTest.main() line 13 - More details - Source on GitHub

⚙️ Maven Tests - JDK 11 #

📦 integration-tests/maven

✖ io.quarkus.maven.it.DevMojoIT.testThatNewResourcesAreServed line 841 - More details - Source on GitHub

@geoand
Copy link
Contributor

geoand commented May 13, 2021

Seems reasonable, but let's let OPs confirm it fixes their problem

@dufoli
Copy link
Contributor

dufoli commented May 13, 2021 •
edited
Loading

indeed my initial patch use GenerateResourceBuildItems and it do not work with uberJar so great if there is a such solution.

@geoand
Copy link
Contributor

geoand commented May 13, 2021

@dufoli can you build Quarkus with this PR and check if it solves your problem?

@dufoli
Copy link
Contributor

dufoli commented May 13, 2021 •
edited
Loading

shumon test it on his branch and it works.
cf
quarkiverse/quarkus-cxf#194 (comment)
@geoand

@geoand
Copy link
Contributor

geoand commented May 13, 2021

Thanks @dufoli.

I am fine with this PR

@gastaldi gastaldi force-pushed the generate_resources_uber branch from 50b9a4d to d92300a Compare May 13, 2021 14:02
@gastaldi
Copy link
Contributor Author

I am fine with this PR

image

@gastaldi gastaldi added the triage/waiting-for-ci Ready to merge when CI successfully finishes label May 13, 2021
@gastaldi gastaldi merged commit 2c07f5c into quarkusio:main May 13, 2021
@gastaldi gastaldi deleted the generate_resources_uber branch May 13, 2021 18:18
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label May 13, 2021
@quarkus-bot quarkus-bot bot added this to the 2.0 - main milestone May 13, 2021
@gsmet gsmet modified the milestones: 2.0 - main, 1.13.5.Final May 20, 2021
@dufoli dufoli mentioned this pull request Jun 25, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoand geoand geoand approved these changes

@gsmet gsmet Awaiting requested review from gsmet

Assignees
No one assigned
Labels
area/core
Projects
None yet
Milestone
1.13.5.Final
Development

Successfully merging this pull request may close these issues.
4 participants
@gastaldi @geoand @dufoli @gsmet