Add support of several resource and test resource folders in dev mode #17184

essobedo · 2021-05-12T17:14:57Z

Motivation

So far, the dev mode supports at most one resource folder and one test resource folder. In some particular use cases, it can helpful to have more than one resource folder. For example to refer common resources from a parent directory or in case you use an external yaml configuration file that you don't want to ship in the final artifact but you want to use for the dev mode.

Modifications

Uses a PathsCollection instead of a String for the resource and test resource folders
Replaces Set of File or path with PathsCollection
Uses LinkedHashSet as Set implementation to keep the original order
Includes the resource folders and the test resources folders of the active profiles too

quarkus-bot · 2021-05-12T18:59:44Z

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building `76eddb4`

Status	Name	Step	Test failures	Logs	Raw logs
✖	Initial JDK 11 Build	`Build`	⚠️ Check →	Logs	Raw logs

essobedo · 2021-05-12T20:58:31Z

devtools/maven/src/main/java/io/quarkus/maven/DevMojo.java

-        if (Files.isDirectory(testResourcesSourcesDir)) {
-            testResourcePath = testResourcesSourcesDir.toAbsolutePath().toString();
+        resourcePaths = localProject.getResourcesSourcesDirs().stream()
+                .filter(Files::isDirectory)


I kept this filter to match with what was done before but do we rely need it? This will filter out non existing folders that could be added later while developing using the dev mode.

Maybe a better test could be notExists || isDirectory?

I'm not 100% sure but that may have been the intention to filter out dirs that don't exist.

If so it could be interesting to know why because in dev mode, you could want to add a new resource folder in the pom which would trigger an application restart then add a file in this new resource folder which won't be taken into account because of this filter (It is actually the scenario that I had in mind initially for the IT). Please also note that it seems to be inconsistent with Gradle according to what I understand from this part of the code, indeed it doesn't seem to apply any filter.

When a POM changes we re-calculate the model anyway. I think it should still work.
The Gradle impl will need to be fixed.

It would depend on the order, it would only work if you created the directory then added it to the pom.

It would depend on the order, it would only work if you created the directory then added it to the pom.

I confirm that it only works this way, if you modify the pom then create the directory it doesn't work that is why I was wondering if we could simply remove this filter because if we do it will work whatever the order.

@aloubyansky so what do you want me to do finally ? Keep this filter as it is and add it to the gradle part or remove it?

I guess if it doesn't break anything it can be removed. I guess a comment about this use-case could be useful.

quarkus-bot · 2021-05-12T21:00:05Z

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building `87d99fc`

Status	Name	Step	Test failures	Logs	Raw logs
✖	Initial JDK 11 Build	`Build`	⚠️ Check →	Logs	Raw logs

essobedo · 2021-05-12T21:00:56Z

...c/test/resources/projects/dev-mode-multiple-resource-dirs/src/main/resources-secondary/.keep

@@ -0,0 +1 @@
+# Just to be able to commit this empty folder needed for the test


This should not be needed if we don't filter out missing directories

quarkus-bot · 2021-05-13T04:54:12Z

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building `031630f`

Status	Name	Step	Test failures	Logs	Raw logs
✖	Initial JDK 11 Build	`Build`	⚠️ Check →	Logs	Raw logs

quarkus-bot · 2021-05-13T07:09:10Z

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building `baf154c`

Status	Name	Step	Test failures	Logs	Raw logs
✖	Initial JDK 11 Build	`Build`	⚠️ Check →	Logs	Raw logs

quarkus-bot · 2021-05-13T07:12:15Z

This workflow status is outdated as a new workflow run has been triggered.

🚫 This workflow run has been cancelled.

Failing Jobs - Building `59ca8cc`

⚠️ Artifacts of the workflow run were not available thus the report misses some details.

Status	Name	Step	Test failures	Logs	Raw logs
⌛	JVM Tests - JDK 11	`Build`	⚠️ Check →	Logs	Raw logs
⌛	JVM Tests - JDK 11 Windows	`Build`	⚠️ Check →	Logs	Raw logs
⌛	JVM Tests - JDK 16	`Build`	⚠️ Check →	Logs	Raw logs

quarkus-bot · 2021-05-13T10:35:15Z

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building `a16ece5`

Status	Name	Step	Test failures	Logs	Raw logs
✖	MicroProfile TCKs Tests	`Verify`	Test failures	Logs	Raw logs

Full information is available in the Build summary check run.

Test Failures

⚙️ MicroProfile TCKs Tests #

📦 tcks/microprofile-fault-tolerance

✖ org.eclipse.microprofile.fault.tolerance.tck.TimeoutUninterruptableTest.testTimeoutAsyncBulkhead line 190 - More details - Source on GitHub

essobedo · 2021-05-13T12:02:04Z

The build failure doesn't seem to be related to this PR since the tck passes locally. Maybe it is a random failure

essobedo · 2021-05-14T08:12:25Z

Hi @aloubyansky and/or @stuartwdouglas WDYT of this PR?

aloubyansky · 2021-05-14T21:50:04Z

...maven-resolver/src/main/java/io/quarkus/bootstrap/resolver/maven/workspace/LocalProject.java

@@ -228,20 +230,28 @@ public Path getSourcesDir() {
        return getSourcesSourcesDir().getParent();
    }

-    public Path getResourcesSourcesDir() {
+    public Set<Path> getResourcesSourcesDirs() {


About using Sets here and a few other places that represent resources of a single module, these paths will be used to compose a classpath, so it make it consistent, shouldn't we always use Lists instead? Is there really a high chance of finding duplicates in it?

I can change it for List everywhere if needed but I decided to use Set instead because:

I realized that in many places in this part of the code, Sets are used when a collection is needed like for example in SourceSet/SourceSetImpl or sourcePaths in DevMode

We could have duplicates for source directories for example when we use filtering and we would like to enable filtering for specific files only like this example

Now I'm wondering why we are using Set<File> in SourceSet when we already have https://github.com/quarkusio/quarkus/blob/main/independent-projects/bootstrap/app-model/src/main/java/io/quarkus/bootstrap/model/PathsCollection.java
Which could be enhanced to not add duplicates. While duplicate paths are possible I guess that'll still be rear. Another guess is that it's also unlikely we'll have to deal with more than a few resources dirs, in which case lists are more efficient than sets even for contains(item).
@stuartwdouglas do you see a problem switching to a list-based collection?

I think we should just define PathsCollection as an ordered collection of paths that does not contain duplicates and use it everywhere.

It should probably also be renamed to PathCollection.

It looks like they are in a separate commit, right? If so then, IMO, it should be ok in case we want to revert it for some reason after the merge.

Yes I separated the commits intentionally as I anticipated a little bit this possibility

If you have it all working then I am fine with it, I didn't look at the current state before I commented.

Because of the run task of Gradle, the methods of SourceSet need to return interface types to be able to create proxies on top of it otherwise you get error of the next type. I think that I have no other choices but to convert PathsCollection into an interface, Is that ok with you?

2021-05-18T11:24:09.3755726Z Exception in thread "main" java.lang.RuntimeException: java.lang.reflect.InvocationTargetException 2021-05-18T11:24:09.3757359Z at io.quarkus.launcher.QuarkusLauncher.launch(QuarkusLauncher.java:58) 2021-05-18T11:24:09.3758732Z at io.quarkus.runtime.Quarkus.launchFromIDE(Quarkus.java:96) 2021-05-18T11:24:09.3759816Z at io.quarkus.runtime.Quarkus.run(Quarkus.java:83) 2021-05-18T11:24:09.3761347Z at io.quarkus.runtime.Quarkus.run(Quarkus.java:42) 2021-05-18T11:24:09.3762280Z at io.quarkus.runtime.Quarkus.run(Quarkus.java:119) 2021-05-18T11:24:09.3763157Z at org.acme.EntryPoint.main(EntryPoint.java:9) 2021-05-18T11:24:09.3764548Z Caused by: java.lang.reflect.InvocationTargetException 2021-05-18T11:24:09.3766148Z at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) 2021-05-18T11:24:09.3768290Z at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) 2021-05-18T11:24:09.3770650Z at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) 2021-05-18T11:24:09.3772555Z at java.base/java.lang.reflect.Method.invoke(Method.java:566) 2021-05-18T11:24:09.3773843Z at io.quarkus.launcher.QuarkusLauncher.launch(QuarkusLauncher.java:56) 2021-05-18T11:24:09.3775191Z ... 5 more 2021-05-18T11:24:10.1218864Z Caused by: java.lang.RuntimeException: java.lang.IllegalArgumentException: io.quarkus.bootstrap.model.PathsCollection is not an interface 2021-05-18T11:24:10.1234536Z at io.quarkus.bootstrap.IDELauncherImpl.launch(IDELauncherImpl.java:85) 2021-05-18T11:24:10.1235855Z ... 10 more 2021-05-18T11:24:10.1237283Z Caused by: java.lang.IllegalArgumentException: io.quarkus.bootstrap.model.PathsCollection is not an interface 2021-05-18T11:24:10.1239583Z at java.base/java.lang.reflect.Proxy$ProxyBuilder.validateProxyInterfaces(Proxy.java:688) 2021-05-18T11:24:10.1241123Z at java.base/java.lang.reflect.Proxy$ProxyBuilder.<init>(Proxy.java:627) 2021-05-18T11:24:10.1242321Z at java.base/java.lang.reflect.Proxy$ProxyBuilder.<init>(Proxy.java:635) 2021-05-18T11:24:10.1243802Z at java.base/java.lang.reflect.Proxy.lambda$getProxyConstructor$0(Proxy.java:415) 2021-05-18T11:24:10.1249164Z at java.base/jdk.internal.loader.AbstractClassLoaderValue$Memoizer.get(AbstractClassLoaderValue.java:329) 2021-05-18T11:24:10.1252515Z at java.base/jdk.internal.loader.AbstractClassLoaderValue.computeIfAbsent(AbstractClassLoaderValue.java:205) 2021-05-18T11:24:10.1258098Z at java.base/java.lang.reflect.Proxy.getProxyConstructor(Proxy.java:413) 2021-05-18T11:24:10.1260384Z at java.base/java.lang.reflect.Proxy.newProxyInstance(Proxy.java:1006) 2021-05-18T11:24:10.1264309Z at org.gradle.tooling.internal.adapter.ProtocolToModelAdapter.createView(ProtocolToModelAdapter.java:160) 2021-05-18T11:24:10.1267630Z at org.gradle.tooling.internal.adapter.ProtocolToModelAdapter.convert(ProtocolToModelAdapter.java:276) 2021-05-18T11:24:10.1280517Z at org.gradle.tooling.internal.adapter.ProtocolToModelAdapter.access$1500(ProtocolToModelAdapter.java:56) 2021-05-18T11:24:10.1283751Z at org.gradle.tooling.internal.adapter.ProtocolToModelAdapter$AdaptingMethodInvoker.invoke(ProtocolToModelAdapter.java:477) 2021-05-18T11:24:10.1287361Z at org.gradle.tooling.internal.adapter.ProtocolToModelAdapter$PropertyCachingMethodInvoker.invoke(ProtocolToModelAdapter.java:705) 2021-05-18T11:24:10.1290567Z at org.gradle.tooling.internal.adapter.ProtocolToModelAdapter$SafeMethodInvoker.invoke(ProtocolToModelAdapter.java:742) 2021-05-18T11:24:10.1305810Z at org.gradle.tooling.internal.adapter.ProtocolToModelAdapter$SupportedPropertyInvoker.invoke(ProtocolToModelAdapter.java:766) 2021-05-18T11:24:10.1309379Z at org.gradle.tooling.internal.adapter.ProtocolToModelAdapter$InvocationHandlerImpl.invoke(ProtocolToModelAdapter.java:432) 2021-05-18T11:24:10.1311418Z at com.sun.proxy.$Proxy17.getSourceDirectories(Unknown Source) 2021-05-18T11:24:10.1312963Z at io.quarkus.bootstrap.util.QuarkusModelHelper.convert(QuarkusModelHelper.java:147) 2021-05-18T11:24:10.1315315Z at io.quarkus.bootstrap.util.QuarkusModelHelper.serializeAppModel(QuarkusModelHelper.java:62) 2021-05-18T11:24:10.1317757Z at io.quarkus.bootstrap.util.QuarkusModelHelper.exportModel(QuarkusModelHelper.java:50) 2021-05-18T11:24:10.1353249Z at io.quarkus.bootstrap.utils.BuildToolHelper.enableGradleAppModelForDevMode(BuildToolHelper.java:120) 2021-05-18T11:24:10.1355698Z at io.quarkus.bootstrap.IDELauncherImpl.launch(IDELauncherImpl.java:41)

The corresponding logs

Oh, right. Yes.

quarkus-bot · 2021-05-17T22:50:44Z

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building `6ad1612`

Status	Name	Step	Test failures	Logs	Raw logs
✖	Devtools Tests - JDK 11	`Build`	Test failures	Logs	Raw logs
✖	Devtools Tests - JDK 11 Windows	`Build`	Test failures	Logs	Raw logs
✖	Gradle Tests - JDK 11	`Build`	⚠️ Check →	Logs	Raw logs
✖	Gradle Tests - JDK 11 Windows	`Build`	⚠️ Check →	Logs	Raw logs
✖	JVM Tests - JDK 11	`Build`	Test failures	Logs	Raw logs
✖	JVM Tests - JDK 11 Windows	`Build`	Test failures	Logs	Raw logs
✔️	JVM Tests - JDK 16

Full information is available in the Build summary check run.

Test Failures

⚙️ Devtools Tests - JDK 11 #

📦 integration-tests/devtools

✖ io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartBuildIT.testGradle(String)[1] line 75 - More details - Source on GitHub

✖ io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartBuildIT.testGradle(String)[2] line 75 - More details - Source on GitHub

✖ io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartBuildIT.testGradle(String)[3] line 75 - More details - Source on GitHub

✖ io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartBuildIT.testGradleKotlinDSL(String)[1] line 83 - More details - Source on GitHub

✖ io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartBuildIT.testGradleKotlinDSL(String)[2] line 83 - More details - Source on GitHub

✖ io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartBuildIT.testGradleKotlinDSL(String)[3] line 83 - More details - Source on GitHub

⚙️ Devtools Tests - JDK 11 Windows #

📦 integration-tests/devtools

✖ io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartBuildIT.testGradle(String)[1] line 75 - More details - Source on GitHub

✖ io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartBuildIT.testGradle(String)[2] line 75 - More details - Source on GitHub

✖ io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartBuildIT.testGradle(String)[3] line 75 - More details - Source on GitHub

✖ io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartBuildIT.testGradleKotlinDSL(String)[1] line 83 - More details - Source on GitHub

✖ io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartBuildIT.testGradleKotlinDSL(String)[2] line 83 - More details - Source on GitHub

✖ io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartBuildIT.testGradleKotlinDSL(String)[3] line 83 - More details - Source on GitHub

⚙️ JVM Tests - JDK 11 #

📦 devtools/cli

✖ io.quarkus.cli.CliTest.testGradleBuild line 318 - More details - Source on GitHub

⚙️ JVM Tests - JDK 11 Windows #

📦 devtools/cli

✖ io.quarkus.cli.CliTest.testGradleBuild line 318 - More details - Source on GitHub

aloubyansky · 2021-05-18T20:30:28Z

If I move, e.g. Dependency and DependencyImpl from the gradle-resolver to app-model, the test will fail on them in the same way.

essobedo · 2021-05-18T20:54:59Z

Good to know, I will move the interface tomorrow

quarkus-bot · 2021-05-18T22:22:21Z

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building `a9bc97f`

Status	Name	Step	Test failures	Logs	Raw logs
✖	Gradle Tests - JDK 11	`Build`	Test failures	Logs	Raw logs
✖	Gradle Tests - JDK 11 Windows	`Build`	Test failures	Logs	Raw logs

Full information is available in the Build summary check run.

Test Failures

⚙️ Gradle Tests - JDK 11 #

📦 integration-tests/gradle

✖ io.quarkus.gradle.builder.QuarkusModelBuilderTest.shouldLoadMultiModuleModel() line 59 - More details - Source on GitHub

✖ io.quarkus.gradle.builder.QuarkusModelBuilderTest.shouldLoadSimpleModuleModel() line 46 - More details - Source on GitHub

⚙️ Gradle Tests - JDK 11 Windows #

📦 integration-tests/gradle

✖ io.quarkus.gradle.builder.QuarkusModelBuilderTest.shouldLoadMultiModuleModel() line 59 - More details - Source on GitHub

✖ io.quarkus.gradle.builder.QuarkusModelBuilderTest.shouldLoadSimpleModuleModel() line 46 - More details - Source on GitHub

aloubyansky · 2021-05-19T04:40:45Z

You mean moving PathsCollection to the gradle-resolver? It doesn't seems like a good idea. I'd prefer moving the QuarkusModel to the app-model, assuming it works, I'll check today. I'm puzzled what makes the gradle-resolver module special. It looks like it really prevents us having a common app model API between Maven and Gradle.

aloubyansky · 2021-05-19T07:28:29Z

Ok, moving all the interfaces and the impl classes to the app-model works. Weird. But ok. We should move all the "model" interfaces and impl in the app-model then.
@essobedo I can do the move today if you don't mind waiting a bit? I have another PR that is affected by this.

essobedo · 2021-05-19T07:32:14Z

@aloubyansky I can do it if you want in a separated commit within the context of this PR, WDYT?

aloubyansky · 2021-05-19T07:35:45Z

I just already have it moved in my branch already. I didn't touch the PathsCollection though. I just need to push it.

essobedo · 2021-05-19T07:45:35Z

@aloubyansky ok then ping me when it's merged

aloubyansky · 2021-05-19T11:46:48Z

@essobedo it's in

essobedo · 2021-05-19T13:10:52Z

@aloubyansky rebase done, let's see if it works now

quarkus-bot · 2021-05-19T13:18:46Z

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building `ca25d8d`

Status	Name	Step	Test failures	Logs	Raw logs
✖	Initial JDK 11 Build	`Build`	⚠️ Check →	Logs	Raw logs

quarkus-bot · 2021-05-19T17:03:32Z

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building `ef54b02`

Status	Name	Step	Test failures	Logs	Raw logs
✖	Gradle Tests - JDK 11	`Build`	Test failures	Logs	Raw logs
✖	Gradle Tests - JDK 11 Windows	`Build`	Test failures	Logs	Raw logs
✔️	JVM Tests - JDK 11
✖	JVM Tests - JDK 11 Windows	`Build`	Test failures	Logs	Raw logs
✔️	JVM Tests - JDK 16

Full information is available in the Build summary check run.

Test Failures

⚙️ Gradle Tests - JDK 11 #

📦 integration-tests/gradle

✖ io.quarkus.gradle.builder.QuarkusModelBuilderTest.shouldLoadMultiModuleModel() line 65 - More details - Source on GitHub

✖ io.quarkus.gradle.builder.QuarkusModelBuilderTest.shouldLoadSimpleModuleModel() line 50 - More details - Source on GitHub

⚙️ Gradle Tests - JDK 11 Windows #

📦 integration-tests/gradle

✖ io.quarkus.gradle.builder.QuarkusModelBuilderTest.shouldLoadMultiModuleModel() line 65 - More details - Source on GitHub

✖ io.quarkus.gradle.builder.QuarkusModelBuilderTest.shouldLoadSimpleModuleModel() line 50 - More details - Source on GitHub

⚙️ JVM Tests - JDK 11 Windows #

📦 integration-tests/resteasy-reactive-rest-client-standalone

✖ io.quarkus.it.rest.client.BasicTest.shouldWork - More details - Source on GitHub

quarkus-bot · 2021-05-19T23:28:02Z

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building `f7094fd`

Status	Name	Step	Test failures	Logs	Raw logs
✖	Gradle Tests - JDK 11	`Build`	Test failures	Logs	Raw logs
✖	Gradle Tests - JDK 11 Windows	`Build`	Test failures	Logs	Raw logs

Full information is available in the Build summary check run.

Test Failures

⚙️ Gradle Tests - JDK 11 #

📦 integration-tests/gradle

✖ io.quarkus.gradle.builder.QuarkusModelBuilderTest.shouldLoadSimpleModuleModel() line 50 - More details - Source on GitHub

⚙️ Gradle Tests - JDK 11 Windows #

📦 integration-tests/gradle

✖ io.quarkus.gradle.builder.QuarkusModelBuilderTest.shouldLoadSimpleModuleModel() line 50 - More details - Source on GitHub

essobedo · 2021-05-20T13:04:14Z

@aloubyansky It should be fine now, the Gradle tests pass locally so I think that the PR is ready for review

essobedo · 2021-05-20T16:04:11Z

At last, the build is finally green 😅

aloubyansky · 2021-05-20T16:04:47Z

Congrats!

aloubyansky · 2021-05-20T19:13:42Z

core/deployment/src/main/java/io/quarkus/deployment/dev/IDEDevModeMain.java

-        Set<String> sourceParents = new HashSet<>();
-        for (File srcDir : module.getSourceSourceSet().getSourceDirectories()) {
-            sourceDirectories.add(srcDir.getPath());
+        final Set<Path> sourceParents = new LinkedHashSet<>();


Why not create PathsCollection directly here? Is it because it still allows duplicates?

aloubyansky · 2021-05-20T19:25:26Z

Thanks @essobedo, great work!

quarkus-bot bot added area/core area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/gradle Gradle area/maven area/testing labels May 12, 2021

glefloch requested a review from aloubyansky May 12, 2021 17:21

essobedo marked this pull request as ready for review May 12, 2021 18:56

essobedo force-pushed the multiple-resources-dirs branch from 76eddb4 to 87d99fc Compare May 12, 2021 20:55

essobedo commented May 12, 2021

View reviewed changes

essobedo force-pushed the multiple-resources-dirs branch from 87d99fc to 031630f Compare May 13, 2021 04:49

essobedo force-pushed the multiple-resources-dirs branch 2 times, most recently from 59ca8cc to baf154c Compare May 13, 2021 07:04

essobedo force-pushed the multiple-resources-dirs branch from baf154c to a16ece5 Compare May 13, 2021 07:13

essobedo mentioned this pull request May 14, 2021

Enable quarkus:dev to hot-reload resources from non-standard paths #10298

Closed

aloubyansky reviewed May 14, 2021

View reviewed changes

quarkus-bot bot added area/arc Issue related to ARC (dependency injection) area/kotlin area/scala labels May 17, 2021

essobedo force-pushed the multiple-resources-dirs branch 2 times, most recently from ab84c01 to 42c0337 Compare May 18, 2021 08:29

Add support of several resource and test resource folders in dev mode

e25af73

essobedo force-pushed the multiple-resources-dirs branch from a9bc97f to ca25d8d Compare May 19, 2021 13:10

essobedo force-pushed the multiple-resources-dirs branch from ca25d8d to ef54b02 Compare May 19, 2021 13:36

essobedo force-pushed the multiple-resources-dirs branch from ef54b02 to f7094fd Compare May 19, 2021 20:17

Replace Set of paths to PathsCollection

15145b7

essobedo force-pushed the multiple-resources-dirs branch from f7094fd to 15145b7 Compare May 20, 2021 12:36

aloubyansky reviewed May 20, 2021

View reviewed changes

aloubyansky approved these changes May 20, 2021

View reviewed changes

aloubyansky merged commit bce6a9e into quarkusio:main May 20, 2021

quarkus-bot bot added this to the 2.0 - main milestone May 20, 2021

essobedo deleted the multiple-resources-dirs branch May 20, 2021 19:31

aloubyansky mentioned this pull request May 21, 2021

Turn the PathsCollection back into a class to not break binary backward compatibility #17403

Merged

glefloch mentioned this pull request Jun 1, 2021

build failed with multiple resource source dirs configured by gradle #17008

Closed

		@@ -0,0 +1 @@
		# Just to be able to commit this empty folder needed for the test

Add support of several resource and test resource folders in dev mode #17184

Add support of several resource and test resource folders in dev mode #17184

Conversation

essobedo commented May 12, 2021 • edited Loading

Motivation

Modifications

quarkus-bot bot commented May 12, 2021 • edited Loading

Failing Jobs - Building 76eddb4

essobedo May 12, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

essobedo May 15, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

quarkus-bot bot commented May 12, 2021 • edited Loading

Failing Jobs - Building 87d99fc

Choose a reason for hiding this comment

quarkus-bot bot commented May 13, 2021 • edited Loading

Failing Jobs - Building 031630f

quarkus-bot bot commented May 13, 2021 • edited Loading

Failing Jobs - Building baf154c

quarkus-bot bot commented May 13, 2021 • edited Loading

Failing Jobs - Building 59ca8cc

quarkus-bot bot commented May 13, 2021 • edited Loading

Failing Jobs - Building a16ece5

Test Failures

⚙️ MicroProfile TCKs Tests #

📦 tcks/microprofile-fault-tolerance

essobedo commented May 13, 2021

essobedo commented May 14, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

quarkus-bot bot commented May 17, 2021 • edited Loading

Failing Jobs - Building 6ad1612

Test Failures

⚙️ Devtools Tests - JDK 11 #

📦 integration-tests/devtools

⚙️ Devtools Tests - JDK 11 Windows #

📦 integration-tests/devtools

⚙️ JVM Tests - JDK 11 #

📦 devtools/cli

⚙️ JVM Tests - JDK 11 Windows #

📦 devtools/cli

aloubyansky commented May 18, 2021

essobedo commented May 18, 2021

quarkus-bot bot commented May 18, 2021 • edited Loading

Failing Jobs - Building a9bc97f

Test Failures

⚙️ Gradle Tests - JDK 11 #

📦 integration-tests/gradle

⚙️ Gradle Tests - JDK 11 Windows #

📦 integration-tests/gradle

aloubyansky commented May 19, 2021

aloubyansky commented May 19, 2021

essobedo commented May 19, 2021

aloubyansky commented May 19, 2021

essobedo commented May 19, 2021

aloubyansky commented May 19, 2021

essobedo commented May 19, 2021

quarkus-bot bot commented May 19, 2021 • edited Loading

Failing Jobs - Building ca25d8d

quarkus-bot bot commented May 19, 2021 • edited Loading

Failing Jobs - Building ef54b02

Test Failures

⚙️ Gradle Tests - JDK 11 #

📦 integration-tests/gradle

⚙️ Gradle Tests - JDK 11 Windows #

essobedo commented May 12, 2021 •

edited

Loading

quarkus-bot bot commented May 12, 2021 •

edited

Loading

Failing Jobs - Building `76eddb4`

essobedo May 12, 2021 •

edited

Loading

essobedo May 15, 2021 •

edited

Loading

quarkus-bot bot commented May 12, 2021 •

edited

Loading

Failing Jobs - Building `87d99fc`

quarkus-bot bot commented May 13, 2021 •

edited

Loading

Failing Jobs - Building `031630f`

quarkus-bot bot commented May 13, 2021 •

edited

Loading

Failing Jobs - Building `baf154c`

quarkus-bot bot commented May 13, 2021 •

edited

Loading

Failing Jobs - Building `59ca8cc`

quarkus-bot bot commented May 13, 2021 •

edited

Loading

Failing Jobs - Building `a16ece5`

quarkus-bot bot commented May 17, 2021 •

edited

Loading

Failing Jobs - Building `6ad1612`

quarkus-bot bot commented May 18, 2021 •

edited

Loading

Failing Jobs - Building `a9bc97f`

quarkus-bot bot commented May 19, 2021 •

edited

Loading

Failing Jobs - Building `ca25d8d`

quarkus-bot bot commented May 19, 2021 •

edited

Loading

Failing Jobs - Building `ef54b02`

quarkus-bot bot commented May 19, 2021 •

edited

Loading

Failing Jobs - Building `f7094fd`