Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve adding extension xp in all tooling #17111

Merged
merged 1 commit into from
May 11, 2021

Conversation

ia3andy
Copy link
Contributor

@ia3andy ia3andy commented May 10, 2021

$ qss add resteasy foo bar        
[ERROR] ❗ Nothing installed because some keyword(s) 'foo', 'bar' were not matched in our catalog.
  • Show detailed info about how extensions have been added (platform or extension) and which were already installed:
$ qss add resteasy resteasy-qute quarkus-hibernate-validator
[SUCCESS] ✅ Extension io.quarkus:quarkus-resteasy-qute has been installed
 👍 Extension io.quarkus:quarkus-hibernate-validator was already installed
 👍 Extension io.quarkus:quarkus-resteasy was already installed

Closes #16353
Closes #6108

@ia3andy ia3andy requested a review from aloubyansky May 10, 2021 13:11
@quarkus-bot quarkus-bot bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/platform Issues related to definition and interaction with Quarkus Platform labels May 10, 2021
@ia3andy ia3andy force-pushed the improve-add-extension branch from 63a2c23 to 087eaed Compare May 10, 2021 13:12
@quarkusio quarkusio deleted a comment from quarkus-bot bot May 10, 2021
@ia3andy ia3andy requested a review from gastaldi May 10, 2021 13:38
Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ia3andy ia3andy force-pushed the improve-add-extension branch 2 times, most recently from c18f20c to 36eff53 Compare May 10, 2021 14:24
@quarkusio quarkusio deleted a comment from quarkus-bot bot May 10, 2021
@quarkusio quarkusio deleted a comment from quarkus-bot bot May 10, 2021
Copy link
Member

@aloubyansky aloubyansky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ia3andy ia3andy force-pushed the improve-add-extension branch from 36eff53 to 137f321 Compare May 10, 2021 16:39
@quarkus-bot
Copy link

quarkus-bot bot commented May 10, 2021

This workflow status is outdated as a new workflow run has been triggered.

🚫 This workflow run has been cancelled.

Failing Jobs - Building 36eff53

⚠️ Artifacts of the workflow run were not available thus the report misses some details.

Status Name Step Test failures Logs Raw logs
Gradle Tests - JDK 11 Linux Build Test failures Logs Raw logs
Gradle Tests - JDK 11 Windows Build Test failures Logs Raw logs
JVM Tests - JDK 11 Build ⚠️ Check → Logs Raw logs
JVM Tests - JDK 11 Windows Build ⚠️ Check → Logs Raw logs
JVM Tests - JDK 16 Build ⚠️ Check → Logs Raw logs

Full information is available in the Build summary check run.

Test Failures

⚙️ Gradle Tests - JDK 11 Linux #

📦 integration-tests/gradle

io.quarkus.gradle.BeanInTestSourcesTest.testBasicMultiModuleBuild() line 15 - More details - Source on GitHub

io.quarkus.gradle.KotlinGRPCProjectBuildTest.testBasicMultiModuleBuild() line 16 - More details - Source on GitHub

io.quarkus.gradle.MultiModuleKotlinProjectBuildTest.testBasicMultiModuleBuild() line 15 - More details - Source on GitHub

io.quarkus.gradle.MultiSourceProjectTest.shouldRunTest() line 16 - More details - Source on GitHub

io.quarkus.gradle.devmode.MultiModuleKotlinProjectDevModeTest.main() line 22 - More details - Source on GitHub


⚙️ Gradle Tests - JDK 11 Windows #

📦 integration-tests/gradle

io.quarkus.gradle.BeanInTestSourcesTest.testBasicMultiModuleBuild() line 15 - More details - Source on GitHub

io.quarkus.gradle.KotlinGRPCProjectBuildTest.testBasicMultiModuleBuild() line 16 - More details - Source on GitHub

io.quarkus.gradle.MultiModuleKotlinProjectBuildTest.testBasicMultiModuleBuild() line 15 - More details - Source on GitHub

io.quarkus.gradle.MultiSourceProjectTest.shouldRunTest() line 16 - More details - Source on GitHub

io.quarkus.gradle.devmode.MultiModuleKotlinProjectDevModeTest.main() line 22 - More details - Source on GitHub

@ia3andy
Copy link
Contributor Author

ia3andy commented May 10, 2021

The gradle tests seems to be failing for an unrelated reason (fix seems to be #17115)

@quarkus-bot
Copy link

quarkus-bot bot commented May 10, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 137f321

Status Name Step Test failures Logs Raw logs
Gradle Tests - JDK 11 Linux Build Test failures Logs Raw logs
Gradle Tests - JDK 11 Windows Build Test failures Logs Raw logs

Full information is available in the Build summary check run.

Test Failures

⚙️ Gradle Tests - JDK 11 Linux #

📦 integration-tests/gradle

io.quarkus.gradle.BeanInTestSourcesTest.testBasicMultiModuleBuild() line 15 - More details - Source on GitHub

io.quarkus.gradle.KotlinGRPCProjectBuildTest.testBasicMultiModuleBuild() line 16 - More details - Source on GitHub

io.quarkus.gradle.MultiModuleKotlinProjectBuildTest.testBasicMultiModuleBuild() line 15 - More details - Source on GitHub

io.quarkus.gradle.MultiSourceProjectTest.shouldRunTest() line 16 - More details - Source on GitHub

io.quarkus.gradle.devmode.MultiModuleKotlinProjectDevModeTest.main() line 22 - More details - Source on GitHub


⚙️ Gradle Tests - JDK 11 Windows #

📦 integration-tests/gradle

io.quarkus.gradle.BeanInTestSourcesTest.testBasicMultiModuleBuild() line 15 - More details - Source on GitHub

io.quarkus.gradle.KotlinGRPCProjectBuildTest.testBasicMultiModuleBuild() line 16 - More details - Source on GitHub

io.quarkus.gradle.MultiModuleKotlinProjectBuildTest.testBasicMultiModuleBuild() line 15 - More details - Source on GitHub

io.quarkus.gradle.MultiSourceProjectTest.shouldRunTest() line 16 - More details - Source on GitHub

io.quarkus.gradle.devmode.MultiModuleKotlinProjectDevModeTest.main() line 22 - More details - Source on GitHub

@ia3andy ia3andy force-pushed the improve-add-extension branch from 137f321 to d50150d Compare May 10, 2021 21:15
@ia3andy ia3andy merged commit 100ede5 into quarkusio:main May 11, 2021
@ia3andy ia3andy deleted the improve-add-extension branch May 11, 2021 05:32
@quarkus-bot quarkus-bot bot added this to the 2.0 - main milestone May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/platform Issues related to definition and interaction with Quarkus Platform
Projects
None yet
3 participants