Upgrade to Gradle 7.2 and enable Gradle modules on JDK EA build #17102
Conversation
quarkus-bot
bot
added
the
area/infra-automation
|
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building 368a99c
Full information is available in the Build summary check run. Test Failures⚙️ Gradle Tests - JDK 11 Linux #📦 integration-tests/gradle✖ ✖ ✖ ✖ ✖ ⚙️ Gradle Tests - JDK 11 Windows #📦 integration-tests/gradle✖ ✖ ✖ ✖ ✖ ⚙️ JVM Tests - JDK 16 #📦 extensions/vertx-http/deployment✖ |
|
There is also something left here: https://github.com/quarkusio/quarkus/blob/main/.github/workflows/ci-actions-incremental.yml#L243 (remove |
quarkus-bot
bot
added
area/cli
There was a problem hiding this comment.
It seems my previous comment still needs to be addressed as well: #17102 (comment)
Additionally, I think the other failing Gradle tests should be fixed first - if possible.
|
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building 1e786d4
Full information is available in the Build summary check run. Test Failures⚙️ Gradle Tests - JDK 11 Linux #📦 integration-tests/gradle✖ ✖ ✖ ✖ ✖ ⚙️ Gradle Tests - JDK 11 Windows #📦 integration-tests/gradle✖ ✖ ✖ ✖ ✖ |
|
Something must be wrong with my comment #17102 (comment) because you keep missing it. 😉 Btw, you sould rebase on |
| @@ -57,7 +57,6 @@ public void testRunTogetherCodestartsJava() throws Exception { | |||
| } | |||
|
|
|||
| @Test | |||
| @org.junit.jupiter.api.Tag("failsOnJDK16") | |||
There was a problem hiding this comment.
I don't think this will work just yet. We need Kotlin 1.5 to make this pass.
| @@ -91,7 +88,6 @@ public void testRunAloneCodestartsJava(String codestart) throws Exception { | |||
|
|
|||
| @ParameterizedTest | |||
| @MethodSource("provideRunAloneCodestarts") | |||
| @org.junit.jupiter.api.Tag("failsOnJDK16") | |||
There was a problem hiding this comment.
Same as https://github.com/quarkusio/quarkus/pull/17102/files#r629535969, needs Kotlin 1.5.
| public void testGradle(String language) throws Exception { | ||
| final List<String> codestarts = getExtensionCodestarts(); | ||
| generateProjectRunTests("gradle", language, codestarts, Collections.emptyMap()); | ||
| } | ||
|
|
||
| @ParameterizedTest | ||
| @MethodSource("provideLanguages") | ||
| @org.junit.jupiter.api.Tag("failsOnJDK16") |
There was a problem hiding this comment.
This probably needs Kotlin 1.5 as well.
|
@glefloch I'm sorry for all those iterations, but it is all intermingled (Gradle, Kotlin etc.), hence a bit complex. |
|
@famod no problem ;) I should be good now. |
|
I'm afraid this is not complete yet (have you really pushed your latest changes?):
TBH, it doesn't look like the Gradle 6.9 update changed that much in terms of Java 16 compatibility.
|
|
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building a672589
Full information is available in the Build summary check run. Test Failures⚙️ JVM Tests - JDK 16 #📦 devtools/cli✖ ✖ |
|
Hmm not sure how we can handle this, the project are generated using codestart. But I'm not sure the codestart target has been updated to use gradle 6.9. I will have a look. |
|
@glefloch any news on this one? |
|
I have been in a rush for last few weeks, I should have time to look down to it this week. |
|
Cool! No stress, just wanted to prevent this from falling through the cracks. |
|
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building e87b61a
Full information is available in the Build summary check run. Test Failures⚙️ Gradle Tests - JDK 11 #📦 integration-tests/gradle✖ ✖ ✖ ✖ ✖ ✖ ✖ ⚙️ Gradle Tests - JDK 11 Windows #📦 integration-tests/gradle✖ ✖ ✖ ✖ ✖ ✖ ✖ |
|
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building e87b61a
Full information is available in the Build summary check run. Test Failures⚙️ Gradle Tests - JDK 11 #📦 integration-tests/gradle✖ ✖ ✖ ✖ ✖ ✖ ✖ ⚙️ Gradle Tests - JDK 11 Windows #📦 integration-tests/gradle✖ ✖ ✖ ✖ ✖ ✖ ✖ |
There was a problem hiding this comment.
Great to see this coming to an end! 👍
AFAICS, the only thing left (apart from that on disabled test I mentioned previously) is to remove -pl '!devtools/gradle' here: https://github.com/quarkusio/quarkus/blob/main/.github/workflows/ci-actions-incremental.yml#L253
|
Right @famod, I enabled the cli test and the |
glefloch
added
the
triage/waiting-for-ci
gsmet
changed the title
|
@glefloch CI says: |
glefloch
force-pushed
the
fix/17081
branch
2 times, most recently
from
b3e9347 to
9d5853d
Compare
|
@glefloch one test of Since this hasn't happend here before and since it seems to pass on |
|
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building 9d5853d
Full information is available in the Build summary check run. Test Failures⚙️ JVM Tests - JDK 11 Windows #📦 devtools/cli✖ ⚙️ MicroProfile TCKs Tests #📦 tcks/microprofile-fault-tolerance✖ |
I have a CI run in progress in my fork that also incorporates this change and if that run does not have the same |
|
@glefloch Too bad, it failed in my fork as well. 😞 Looking at the trace, I'd bet it's a "some process is still locking files" windows problem: |
|
Hm, I cannot reproduce that test failure on my windows box. I'll push an update to Gradle 7.2 and see how it goes... |
famod
changed the title
|
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building 0d1098f
Full information is available in the Build summary check run. Test Failures⚙️ JVM Tests - JDK 11 #📦 extensions/smallrye-reactive-messaging-kafka/deployment✖ ⚙️ JVM Tests - JDK 11 Windows #📦 devtools/cli✖ |
|
|
|
Yes, I think this is due to the daemon locking the directory. I will look if we can delete the projet after all tests. |
|
Yay, all green! 🎉 |
quarkus-bot
bot
removed
the
triage/waiting-for-ci
|
This won't be backported for now and will be part of 2.3. |
This branch enables gradle modules build in
jdk-early-access-buildworkflow.close #17081
close #19256