Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update SmallRye Config to 2.3.0 #17073

Merged
merged 1 commit into from
May 17, 2021
Merged

Update SmallRye Config to 2.3.0 #17073

merged 1 commit into from
May 17, 2021

Conversation

radcortez
Copy link
Member

@radcortez radcortez commented May 7, 2021 •
edited
Loading

@quarkus-bot quarkus-bot bot added area/arc Issue related to ARC (dependency injection) area/config area/core area/dependencies Pull requests that update a dependency file area/hibernate-validator Hibernate Validator labels May 7, 2021
@radcortez radcortez marked this pull request as ready for review May 12, 2021 17:56
@quarkus-bot
Copy link

quarkus-bot bot commented May 12, 2021 •
edited
Loading

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 97e9ef0

Status Name Step Test failures Logs Raw logs
✖ Maven Tests - JDK 11 Build Test failures Logs Raw logs

Full information is available in the Build summary check run.

Test Failures

⚙️ Maven Tests - JDK 11 #

📦 integration-tests/maven

✖ io.quarkus.maven.it.DevMojoIT.testThatNewResourcesAreServed line 841 - More details - Source on GitHub

gastaldi
gastaldi approved these changes May 13, 2021
View reviewed changes
Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gastaldi
Copy link
Contributor

@radcortez can you rebase just so CI can be triggered again and we can certify that the failed test is not caused by this PR?

@radcortez
Copy link
Member Author

@radcortez can you rebase just so CI can be triggered again and we can certify that the failed test is not caused by this PR?

Sure.

@quarkus-bot
Copy link

quarkus-bot bot commented May 14, 2021 •
edited
Loading

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 1ce1337

Status Name Step Test failures Logs Raw logs
✔️ JVM Tests - JDK 11
✖ JVM Tests - JDK 11 Windows Build ⚠️ Check → Logs Raw logs
✔️ JVM Tests - JDK 16

gsmet
gsmet requested changes May 17, 2021
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@radcortez I spotted a small thing, could you adjust? Then we will merge.

extensions/arc/runtime/src/main/java/io/quarkus/arc/config/ConfigPrefix.java Show resolved Hide resolved
@gsmet gsmet merged commit d06f70d into quarkusio:main May 17, 2021
@quarkus-bot quarkus-bot bot added this to the 2.0 - main milestone May 17, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented May 17, 2021

Milestone is already set for some of the items:

We haven't automatically updated the milestones for these items.

This message is automatically generated by a bot.

@radcortez radcortez deleted the sr-config-230 branch May 26, 2021 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet approved these changes

@gastaldi gastaldi gastaldi approved these changes

Assignees
No one assigned
Labels
area/arc Issue related to ARC (dependency injection) area/config area/core area/dependencies Pull requests that update a dependency file area/hibernate-validator Hibernate Validator
Projects
None yet
Milestone
2.0.0.Alpha3
3 participants
@radcortez @gastaldi @gsmet