Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to GraalVM 21.1 #17014

Merged
merged 2 commits into from
May 7, 2021
Merged

Update to GraalVM 21.1 #17014

merged 2 commits into from
May 7, 2021

Conversation

zakkak
Copy link
Contributor

@zakkak zakkak commented May 5, 2021

No description provided.

@quarkus-bot quarkus-bot bot added area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/documentation area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure labels May 5, 2021
@zakkak
Copy link
Contributor Author

zakkak commented May 5, 2021

Marking as draft until the tests complete on my fork.

gsmet
gsmet approved these changes May 5, 2021
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks!

@zakkak zakkak marked this pull request as ready for review May 5, 2021 17:40
@zakkak
Copy link
Contributor Author

zakkak commented May 5, 2021

Things look good. The only failure I see is related to #14139

@gsmet
Copy link
Member

gsmet commented May 5, 2021

@zakkak so shouldn't we disable the test? I don't see it in your PR?

@quarkus-bot
Copy link

quarkus-bot bot commented May 5, 2021 •
edited
Loading

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building f2d5551

Status Name Step Test failures Logs Raw logs
✔️ JVM Tests - JDK 11
✖ JVM Tests - JDK 11 Windows Build ⚠️ Check → Logs Raw logs
✔️ JVM Tests - JDK 15
✖ Native Tests - Security1 Build Test failures Logs Raw logs

Full information is available in the Build summary check run.

Test Failures

⚙️ Native Tests - Security1 #

📦 integration-tests/bouncycastle-jsse

✖ io.quarkus.it.bouncycastle.BouncyCastleJsseITCase.testListProviders line 12 - More details - Source on GitHub

@zakkak
Copy link
Contributor Author

zakkak commented May 6, 2021

@zakkak so shouldn't we disable the test? I don't see it in your PR?

@gsmet can you please advise on how to disable it? Should I just remove the test from native-tests.json?

@gsmet
Copy link
Member

gsmet commented May 6, 2021

You should be able to use @DisabledOnNativeImage and make @sberyozkin aware of it so he doesn't forget to remove it when he fixes the issue.

@zakkak
Copy link
Contributor Author

zakkak commented May 6, 2021

Things look good. The only failure I see is related to #14139

It looks like I am wrong about this, there is another failure on bouncycastle-jsse, see #17046

The test is now disabled.

@sberyozkin
Copy link
Member

@zakkak Thanks

@gsmet gsmet merged commit a590bb3 into quarkusio:main May 7, 2021
@quarkus-bot quarkus-bot bot added this to the 2.0 - main milestone May 7, 2021
@gsmet
Copy link
Member

gsmet commented May 7, 2021

Thanks!

@zakkak zakkak deleted the graalvm21.1-update branch May 7, 2021 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet approved these changes

Assignees
No one assigned
Labels
area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/documentation area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure release/noteworthy-feature
Projects
None yet
Milestone
2.0.0.Alpha3
Development

Successfully merging this pull request may close these issues.
3 participants
@zakkak @gsmet @sberyozkin