Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable synthetic beans to be application classes #16984

Merged
merged 1 commit into from
May 5, 2021

Conversation

stuartwdouglas
Copy link
Member

Even if the superclass is not ann application class if
the generated bytecode references application classes then
it may be nessesary for the synthetic bean to be an
application class.

@stuartwdouglas stuartwdouglas requested a review from mkouba May 4, 2021 23:38
@quarkus-bot quarkus-bot bot added the area/arc Issue related to ARC (dependency injection) label May 4, 2021
@stuartwdouglas
Copy link
Member Author

@gsmet it would be good to get this into the alpha as it is needed to fix and Optaplanner issue: #11563

@quarkus-bot
Copy link

quarkus-bot bot commented May 5, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building f5da408

Status Name Step Test failures Logs Raw logs
🚫 Devtools Tests - JDK ${{ matrix.java.name }}
🚫 Devtools Tests - JDK 11 Windows
JVM Tests - JDK 11 Build Test failures Logs Raw logs
JVM Tests - JDK 11 Windows Build Test failures Logs Raw logs
JVM Tests - JDK 15 Build Test failures Logs Raw logs
🚫 Maven Tests - JDK ${{ matrix.java.name }}
🚫 Maven Tests - JDK 11 Windows

Full information is available in the Build summary check run.

Test Failures

⚙️ JVM Tests - JDK 11 #

📦 core/test-extension/deployment

io.quarkus.extest.ConfiguredBeanTest.testConfigDefaultValuesSourceOrdinal line 346 - More details - Source on GitHub


⚙️ JVM Tests - JDK 11 Windows #

📦 core/test-extension/deployment

io.quarkus.extest.ConfiguredBeanTest.testConfigDefaultValuesSourceOrdinal line 346 - More details - Source on GitHub


⚙️ JVM Tests - JDK 15 #

📦 core/test-extension/deployment

io.quarkus.extest.ConfiguredBeanTest.testConfigDefaultValuesSourceOrdinal line 346 - More details - Source on GitHub

Even if the superclass is not ann application class if
the generated bytecode references application classes then
it may be nessesary for the synthetic bean to be an
application class.
Copy link
Contributor

@mkouba mkouba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@stuartwdouglas stuartwdouglas merged commit d7048f3 into quarkusio:main May 5, 2021
@quarkus-bot quarkus-bot bot added this to the 2.0 - main milestone May 5, 2021
@gsmet gsmet modified the milestones: 2.0.0.Alpha2, 1.13.4.Final May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/arc Issue related to ARC (dependency injection)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants