Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the multi-stage Docker build example #16938

Merged
merged 1 commit into from
May 3, 2021

Conversation

cescoffier
Copy link
Member

The change follows the discussion from #16881.
It avoids relying on the centos-quarkus-maven image that should be deprecated.
Instead, it relies on the native-image image and uses the maven/gradle wrappers.
It also allows using Mandrel easily.

Fix #16881.

Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I added two tiny comments

The change follows the discussion from quarkusio#16881.
It avoids relying on the centos-quarkus-maven image that should be deprecated.
Instead, it relies on the native-image image, and uses the maven/gradle wrappers.
It also allows using Mandrel easily.

Fix quarkusio#16881.
@cescoffier cescoffier force-pushed the new-multi-stage-docker-build branch from 2b13399 to abaeeac Compare May 3, 2021 05:43
@cescoffier cescoffier merged commit 15f8ebb into quarkusio:main May 3, 2021
@quarkus-bot quarkus-bot bot added this to the 2.0 - main milestone May 3, 2021
@cescoffier cescoffier deleted the new-multi-stage-docker-build branch May 3, 2021 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redesign the multi-stage docker build
2 participants