gRPC - rework annotations #16908
Merged
gRPC - rework annotations #16908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- rename io.quarkus.grpc.runtime.annotations.GrpcService to io.quarkus.grpc.GrpcClient - the relevant literal class is now a static nested class - GrpcClient.value() is optional and the service name can be derived from the annotated element - introduce the io.quarkus.grpc.GrpcService CDI stereotype that can be used to mark a gRPC service class (instead of @singleton) - update docs and tests - resolves quarkusio#16872
| throw new DeploymentException( | ||
| "Invalid @GrpcService `" + injectionPoint.getTargetInfo() + "` - missing configuration key"); | ||
| "Invalid @GrpcClient `" + injectionPoint.getTargetInfo() + "` - service name cannot be empty"); |
There was a problem hiding this comment.
blank may be a better word
michalszynkiewicz
approved these changes
Apr 30, 2021
|
Thanks @mkouba ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
io.quarkus.grpc.runtime.annotations.GrpcServicetoio.quarkus.grpc.GrpcClientGrpcClient.value()is optional and the service name can be derivedfrom the annotated element
used to mark a gRPC service class (instead of
@Singleton)