Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autodetect Kafka serializer/deserializer with Reactive Messaging #16841

Merged
merged 1 commit into from
Apr 29, 2021
Merged

Autodetect Kafka serializer/deserializer with Reactive Messaging #16841

merged 1 commit into from
Apr 29, 2021

Conversation

Ladicek
Copy link
Contributor

@Ladicek Ladicek commented Apr 27, 2021 •
edited
Loading

Resolves #16544

@Ladicek Ladicek requested a review from cescoffier April 27, 2021 15:32
@Ladicek Ladicek force-pushed the kafka-serde-autodetection branch from 932424b to c4e1c94 Compare April 28, 2021 08:46
@Ladicek
Copy link
Contributor Author

Ladicek commented Apr 28, 2021

I just found that in addition to V, Record<K, V> and KafkaRecord<K, V>, we also support ConsumerRecord<K, V>. Gonna add support for that as well.

@Ladicek Ladicek force-pushed the kafka-serde-autodetection branch from c4e1c94 to d60c8a6 Compare April 28, 2021 10:58
@Ladicek
Copy link
Contributor Author

Ladicek commented Apr 28, 2021

Done.

cescoffier
cescoffier approved these changes Apr 28, 2021
View reviewed changes
Copy link
Member

@cescoffier cescoffier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I've added a few minor comments.

docs/src/main/asciidoc/kafka.adoc Outdated Show resolved Hide resolved
...kafka-client/deployment/src/main/java/io/quarkus/kafka/client/deployment/KafkaProcessor.java Show resolved Hide resolved
.../java/io/quarkus/smallrye/reactivemessaging/kafka/deployment/DefaultSerdeDiscoveryState.java Outdated Show resolved Hide resolved
.../java/io/quarkus/smallrye/reactivemessaging/kafka/deployment/DefaultSerdeDiscoveryState.java Show resolved Hide resolved
@Ladicek Ladicek force-pushed the kafka-serde-autodetection branch from d60c8a6 to 4fa0137 Compare April 29, 2021 07:53
@Ladicek Ladicek force-pushed the kafka-serde-autodetection branch from 4fa0137 to c919ccd Compare April 29, 2021 08:40
@quarkus-bot
Copy link

quarkus-bot bot commented Apr 29, 2021 •
edited
Loading

This workflow status is outdated as a new workflow run has been triggered.

🚫 This workflow run has been cancelled.

Failing Jobs - Building 4fa0137

⚠️ Artifacts of the workflow run were not available thus the report misses some details.

Status Name Step Test failures Logs Raw logs
⌛ Native Tests - Messaging1 Build ⚠️ Check → Logs Raw logs
⌛ Native Tests - gRPC Reclaim Disk Space ⚠️ Check → Logs Raw logs

@cescoffier cescoffier merged commit 8626b87 into quarkusio:main Apr 29, 2021
@quarkus-bot quarkus-bot bot added this to the 2.0 - main milestone Apr 29, 2021
@cescoffier
Copy link
Member

Thanks!

@Ladicek Ladicek deleted the kafka-serde-autodetection branch April 29, 2021 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoand geoand geoand left review comments

@gsmet gsmet gsmet left review comments

@cescoffier cescoffier cescoffier approved these changes

Assignees
No one assigned
Labels
area/documentation area/kafka area/reactive-messaging area/smallrye
Projects
None yet
Milestone
2.0.0.Alpha2
Development

Successfully merging this pull request may close these issues.

Improve serializer / deserializer detection the Kafka connector
4 participants
@Ladicek @cescoffier @gsmet @geoand